diff options
author | Mihai Moldovan <ionic@ionic.de> | 2023-09-19 15:36:13 +0200 |
---|---|---|
committer | Mihai Moldovan <ionic@ionic.de> | 2023-09-19 17:23:30 +0200 |
commit | f2f92d4da533b047174fa9d8a90303003a6c2d51 (patch) | |
tree | b7873da5fa84340aa6829e97fe1a592cf50a248d /src/Makefile.am | |
parent | c57a53ea271175876ab86ad4ca7549d5d8e371c2 (diff) | |
download | arctica-greeter-f2f92d4da533b047174fa9d8a90303003a6c2d51.tar.gz arctica-greeter-f2f92d4da533b047174fa9d8a90303003a6c2d51.tar.bz2 arctica-greeter-f2f92d4da533b047174fa9d8a90303003a6c2d51.zip |
src/settings.vala: remove default_theme_name_ private variable.
This functionality doesn't make sense, for two reasons:
- If we query the gtk-theme-name property before setting anything
else, we will certainly get the default theme name. But that is
hardcoded in GTK and not exactly secret. It can't be configured
directly, only by changing specific macros in GTK's source code and
recompiling it. The chances of someone doing that are... very small.
Thus, we can also just hardcode "Adwaita" in AG.
- If we query the gtk-theme-name property after setting it to a
different value... we will fetch the value we just set. That's
totally useless. My initial idea was that GTK is doing some input
sanitization on the provided theme name and handles an invalid name
by falling back to its built-in default and setting the
gtk-theme-name property to this built-in default as well. This,
however, is not true. Setting an invalid theme name will just mean
that GTK will fail loading the new theme and stay on whatever theme
it was before, copying the new value to the gtk-theme-name property
regardless. Unfortunately, querying the property is not something we
could use for error handling, which makes it completely useless.
It's better to just get rid of this.
Diffstat (limited to 'src/Makefile.am')
0 files changed, 0 insertions, 0 deletions