From 20836a6021de0c7f4675881e56f62b32fa78726c Mon Sep 17 00:00:00 2001 From: Mihai Moldovan Date: Wed, 22 Mar 2023 04:17:50 +0100 Subject: src/prompt-box.vala: set background color for error messages to pure white. While this might look ugly, it is important that error messages can be read well and a transparent background might be a bad fit with a static red text color, if the background is also quite red. --- src/prompt-box.vala | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) (limited to 'src/prompt-box.vala') diff --git a/src/prompt-box.vala b/src/prompt-box.vala index 6953c1b..d925739 100644 --- a/src/prompt-box.vala +++ b/src/prompt-box.vala @@ -573,10 +573,21 @@ public class PromptBox : FadableBox } Gdk.RGBA color = { 1.0f, 1.0f, 1.0f, 1.0f }; - if (is_error) + if (is_error) { color.parse ("#df382c"); + + /* + * Overriding the background color will look ugly, but at least + * always make the text readable, which is probably important for + * error messages. + * We probably want to find a better way of handling this. + */ + Gdk.RGBA bg_color = { 1.0f, 1.0f, 1.0f, 1.0f }; + label.override_background_color (Gtk.StateFlags.NORMAL, bg_color); + } label.override_color (Gtk.StateFlags.NORMAL, color); + label.xalign = 0.0f; label.set_data ("prompt-box-is-error", is_error); -- cgit v1.2.3