aboutsummaryrefslogtreecommitdiff
path: root/MERGE-REVIEW
blob: da81ebd749d1f6468735d1cc7e462d2c473427b2 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15

This documents the expections that the project has on what both submitters
and reviewers should ensure that they've done for a merge into the project.

== Submitter Responsibilities ==

 * Ensure the project compiles and the test suite executes without error
 * Ensure that non-obvious code has comments explaining it

== Reviewer Responsibilities ==

 * Did the Jenkins build compile?  Pass?  Run unit tests successfully?
 * Are there appropriate tests to cover any new functionality?
 * Run all the appropriate manual tests