From a140461aa560bb000853903787d7e4643858767e Mon Sep 17 00:00:00 2001 From: Ryan Lortie Date: Fri, 2 Mar 2012 00:16:38 -0500 Subject: make proper use of g_variant_builder_init() GVariantBuilder can only infer the proper type for non-empty arrays. If an array may be empty, the full definite type must be given to g_variant_builder_init(). --- src/application-service-appstore.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/application-service-appstore.c b/src/application-service-appstore.c index 2f456f4..5d4296d 100644 --- a/src/application-service-appstore.c +++ b/src/application-service-appstore.c @@ -1348,7 +1348,7 @@ get_applications (ApplicationServiceAppstore * appstore) GList * listpntr; gint position = 0; - g_variant_builder_init(&builder, G_VARIANT_TYPE_ARRAY); + g_variant_builder_init(&builder, G_VARIANT_TYPE ("a(sisossssss)")); for (listpntr = priv->applications; listpntr != NULL; listpntr = g_list_next(listpntr)) { Application * app = (Application *)listpntr->data; -- cgit v1.2.3 From 5960d8f7683d83a8e20a4eb924a506afa33e8adc Mon Sep 17 00:00:00 2001 From: Ted Gould Date: Fri, 2 Mar 2012 17:02:32 -0600 Subject: Cleaning up switch statement to be more readable --- src/application-service-appstore.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/application-service-appstore.c b/src/application-service-appstore.c index 5d4296d..2663003 100644 --- a/src/application-service-appstore.c +++ b/src/application-service-appstore.c @@ -284,14 +284,23 @@ bus_method_call (GDBusConnection * connection, const gchar * sender, switch (direction) { case INDICATOR_OBJECT_SCROLL_UP: delta = -delta; + orientation = "vertical"; + break; case INDICATOR_OBJECT_SCROLL_DOWN: + /* delta unchanged */ orientation = "vertical"; break; - case INDICATOR_OBJECT_SCROLL_LEFT: delta = -delta; + orientation = "horizontal"; + break; case INDICATOR_OBJECT_SCROLL_RIGHT: + /* delta unchanged */ orientation = "horizontal"; + break; + default: + g_assert_not_reached(); + break; } app = find_application_by_menu(service, dbusaddress, dbusmenuobject); -- cgit v1.2.3 From 29bf37b41e425feac66cd634d78d92c9ebb1af9e Mon Sep 17 00:00:00 2001 From: Ted Gould Date: Fri, 9 Mar 2012 15:09:19 -0600 Subject: 0.4.92 --- configure.ac | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index d32c95f..3e714eb 100644 --- a/configure.ac +++ b/configure.ac @@ -1,11 +1,11 @@ -AC_INIT(indicator-application, 0.4.91, ted@canonical.com) +AC_INIT(indicator-application, 0.4.92, ted@canonical.com) AC_COPYRIGHT([Copyright 2009, 2010 Canonical]) AC_PREREQ(2.53) AM_CONFIG_HEADER(config.h) -AM_INIT_AUTOMAKE(indicator-application, 0.4.91) +AM_INIT_AUTOMAKE(indicator-application, 0.4.92) AM_MAINTAINER_MODE -- cgit v1.2.3