aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Tari <robert@tari.in>2022-02-11 15:24:06 +0100
committerMike Gabriel <mike.gabriel@das-netzwerkteam.de>2022-02-16 11:41:25 +0100
commitbfc0251b1e448ea595b5837c46cb5656bc666ec4 (patch)
tree3e3b2e2b0fd29075f17334a52bea2cce08b0895f
parentadb447d7067f73db4040ad3119a2a52cd08879a2 (diff)
downloadayatana-indicator-datetime-bfc0251b1e448ea595b5837c46cb5656bc666ec4.tar.gz
ayatana-indicator-datetime-bfc0251b1e448ea595b5837c46cb5656bc666ec4.tar.bz2
ayatana-indicator-datetime-bfc0251b1e448ea595b5837c46cb5656bc666ec4.zip
Fix build warnings
-rw-r--r--CMakeLists.txt2
-rw-r--r--include/datetime/timezone-geoclue.h4
-rw-r--r--src/wakeup-timer-powerd.cpp4
3 files changed, 6 insertions, 4 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt
index ba6ebfa..6daef80 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -33,6 +33,8 @@ else()
add_definitions("-Wall")
endif()
+add_definitions("-Wno-sign-compare") # Needed for GTest on Ubuntu
+
##
## GNU standard installation directories
##
diff --git a/include/datetime/timezone-geoclue.h b/include/datetime/timezone-geoclue.h
index 18fc159..d25d3e5 100644
--- a/include/datetime/timezone-geoclue.h
+++ b/include/datetime/timezone-geoclue.h
@@ -1,5 +1,6 @@
/*
* Copyright 2013 Canonical Ltd.
+ * Copyright 2022 Robert Tari
*
* This program is free software: you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 3, as published
@@ -15,6 +16,7 @@
*
* Authors:
* Charles Kerr <charles.kerr@canonical.com>
+ * Robert Tari <robert@tari.in>
*/
#ifndef INDICATOR_DATETIME_GEOCLUE_TIMEZONE_H
@@ -36,7 +38,7 @@ public:
~GeoclueTimezone();
private:
- struct Impl;
+ class Impl;
std::unique_ptr<Impl> impl;
// we've got pointers in here, so don't allow copying
diff --git a/src/wakeup-timer-powerd.cpp b/src/wakeup-timer-powerd.cpp
index f775999..77893c8 100644
--- a/src/wakeup-timer-powerd.cpp
+++ b/src/wakeup-timer-powerd.cpp
@@ -1,6 +1,6 @@
/*
* Copyright 2014 Canonical Ltd.
- * Copyright 2021 Robert Tari
+ * Copyright 2021-2022 Robert Tari
*
* This program is free software: you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 3, as published
@@ -41,7 +41,6 @@ class PowerdWakeupTimer::Impl
public:
explicit Impl(const std::shared_ptr<Clock>& clock):
- m_clock(clock),
m_cancellable(g_cancellable_new())
{
g_bus_get(G_BUS_TYPE_SYSTEM, m_cancellable, on_bus_ready, this);
@@ -271,7 +270,6 @@ private:
***/
core::Signal<> m_timeout;
- const std::shared_ptr<Clock>& m_clock;
DateTime m_wakeup_time;
std::shared_ptr<GDBusConnection> m_bus;