aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorCharles Kerr <charles.kerr@canonical.com>2016-02-01 18:08:52 -0600
committerRobert Tari <robert@tari.in>2021-07-01 00:48:33 +0200
commit336dffcf117e4836d38c5c17ef408261cec7a2a9 (patch)
treeb0286e0acaa91fd02cefe05f45daa027f1c98ab4
parent12c6fdc0676521cf5ce6e7b92c9cc2da44a7c3db (diff)
downloadayatana-indicator-datetime-336dffcf117e4836d38c5c17ef408261cec7a2a9.tar.gz
ayatana-indicator-datetime-336dffcf117e4836d38c5c17ef408261cec7a2a9.tar.bz2
ayatana-indicator-datetime-336dffcf117e4836d38c5c17ef408261cec7a2a9.zip
add combinatorial tests to check how snap behaves under system settings, event types, etc
-rw-r--r--tests/test-snap.cpp103
1 files changed, 86 insertions, 17 deletions
diff --git a/tests/test-snap.cpp b/tests/test-snap.cpp
index e8c005b..bdbad0b 100644
--- a/tests/test-snap.cpp
+++ b/tests/test-snap.cpp
@@ -548,50 +548,119 @@ TEST_F(SnapFixture, ForceScreen)
****
***/
-TEST_F(SnapFixture,Vibrate)
+TEST_F(SnapFixture,Notification)
{
auto settings = std::make_shared<Settings>();
auto ne = std::make_shared<ayatana::indicator::notifications::Engine>(APP_NAME);
+ auto sb = std::make_shared<ayatana::indicator::notifications::DefaultSoundBuilder>();
auto func = [this](const Appointment&, const Alarm&){g_idle_add(quit_idle, loop);};
- GError * error = nullptr;
struct {
- bool other_vibrations; // the com.ubuntu.touch.AccountsService.Sound "other vibrations" setting
- const char* haptic_mode; // supported values: "none", "pulse"
- bool expected_vibrate_called; // do we expect the phone to vibrate?
- } test_cases[] = {
- { false, "none", false },
- { true, "none", false },
- { false, "pulse", false },
- { true, "pulse", true }
+ Appointment appt;
+ bool expected_notify_called;
+ bool expected_vibrate_called;
+ } test_appts[] = {
+ { appt, true, true },
+ { ualarm, true, true }
};
- auto snap = create_snap(ne, sb, settings);
+ struct {
+ const char* haptic_mode;
+ bool expected_notify_called;
+ bool expected_vibrate_called;
+ } test_haptics[] = {
+ { "none", true, false },
+ { "pulse", true, true }
+ };
+
+ struct {
+ bool other_vibrations; // the com.lomiri.touch.AccountsService.Sound "other vibrations" setting
+ bool expected_notify_called;
+ bool expected_vibrate_called;
+ } test_other_vibrations[] = {
+ { true, true, true },
+ { false, true, false }
+ };
+
+ const std::set<std::pair<std::string,std::string>> blacklist_calendar { std::make_pair(std::string{"com.lomiri.calendar"}, std::string{"calendar-app"}) };
+ const std::set<std::pair<std::string,std::string>> blacklist_empty;
+ struct {
+ std::set<std::pair<std::string,std::string>> muted_apps; // apps that should not trigger notifications
+ bool expected_notify_called; // do we expect the notification tho show?
+ bool expected_vibrate_called; // do we expect the phone to vibrate?
+ } test_muted_apps[] = {
+ { blacklist_calendar, false, false },
+ { blacklist_empty, true, true }
+ };
- for(const auto& test_case : test_cases)
+ for (const auto& test_appt : test_appts)
+ {
+ for (const auto& test_haptic : test_haptics)
+ {
+ for (const auto& test_vibes : test_other_vibrations)
+ {
+ for (const auto& test_muted : test_muted_apps)
{
+ auto snap = create_snap(ne, sb, settings);
+
+ const bool expected_notify_called = test_appt.expected_notify_called
+ && test_vibes.expected_notify_called
+ && test_muted.expected_notify_called
+ && test_haptic.expected_notify_called;
+
+ const bool expected_vibrate_called = test_appt.expected_vibrate_called
+ && test_vibes.expected_vibrate_called
+ && test_muted.expected_vibrate_called
+ && test_haptic.expected_vibrate_called;
+
+g_message("appt:%s", test_appt.appt.summary.c_str());
+g_message("haptic_mode:%s", test_haptic.haptic_mode);
+g_message("other_vibrations:%d", (int)test_vibes.other_vibrations);
+g_message("muted_apps.size():%d", (int)test_muted.muted_apps.size());
+g_message("expected_notify_called %d (%d %d %d %d)", (int)expected_notify_called, (int)test_appt.expected_notify_called, (int)test_vibes.expected_notify_called, (int)test_muted.expected_notify_called, (int)test_haptic.expected_notify_called);
+g_message("expected_vibrate_called %d (%d %d %d %d)", (int)expected_vibrate_called, (int)test_appt.expected_vibrate_called, (int)test_vibes.expected_vibrate_called, (int)test_muted.expected_vibrate_called, (int)test_haptic.expected_vibrate_called);
+
// clear out any previous iterations' noise
+ GError * error = nullptr;
dbus_test_dbus_mock_object_clear_method_calls(haptic_mock, haptic_obj, &error);
+ g_assert_no_error(error);
+ dbus_test_dbus_mock_object_clear_method_calls(notify_mock, notify_obj, &error);
+ g_assert_no_error(error);
// set the properties to match the test case
- settings->alarm_haptic.set(test_case.haptic_mode);
+ settings->muted_apps.set(test_muted.muted_apps);
+ settings->alarm_haptic.set(test_haptic.haptic_mode);
dbus_test_dbus_mock_object_update_property(as_mock,
as_obj,
PROP_OTHER_VIBRATIONS,
- g_variant_new_boolean(test_case.other_vibrations),
+ g_variant_new_boolean(test_vibes.other_vibrations),
&error);
g_assert_no_error(error);
- wait_msec(100);
+ wait_msec(200);
// run the test
(*snap)(appt, appt.alarms.front(), func, func);
- wait_msec(100);
+ wait_msec(200);
+
+ // test that the notification was as expected
+ const bool notify_called = dbus_test_dbus_mock_object_check_method_call(notify_mock,
+ notify_obj,
+ METHOD_NOTIFY,
+ nullptr,
+ &error);
+ g_assert_no_error(error);
+ EXPECT_EQ(expected_notify_called, notify_called);
+
+ // test that the vibration was as expected
const bool vibrate_called = dbus_test_dbus_mock_object_check_method_call(haptic_mock,
haptic_obj,
HAPTIC_METHOD_VIBRATE_PATTERN,
nullptr,
&error);
g_assert_no_error(error);
- EXPECT_EQ(test_case.expected_vibrate_called, vibrate_called);
+ EXPECT_EQ(expected_vibrate_called, vibrate_called);
+ }
+ }
+ }
}
}