Prefer to use ubuntu-platform-hardware-api for wakeups when possible s.t. user-defined alarms/appointments can wake up the phone from sleep to give a snap decision. Fixes: 1299916

1 files changed, 30 insertions, 5 deletions

diff --git a/MERGE-REVIEW b/MERGE-REVIEW
index 5e40f45..1a5815c 100644
--- a/MERGE-REVIEW
+++ b/MERGE-REVIEW
@@ -6,14 +6,39 @@ and reviewers should ensure that they've done for a merge into the project.
 
  * Ensure the project compiles and the test suite executes without error
  * Ensure that non-obvious code has comments explaining it
- * If the change works on specific profiles, please include those in the merge description.
+ * If the change affects specific features, please reference the appropriate
+   tags in the merge description so reviewers can test appropriately:
+   [phone profile], [desktop profile], [alarms]
 
 == Reviewer Responsibilities ==
 
  * Did the Jenkins build compile?  Pass?  Run unit tests successfully?
  * Are there appropriate tests to cover any new functionality?
- * If the description says this effects the phone profile:
-   * Run tests indicator-datetime/unity8*
- * If the description says this effects the desktop profile:
-   * Run tests indicator-datetime/unity7*
+ * Do the tag-specific tests pass?
+
+== Phone Profile Tests ==
+
+ * Run tests indicator-datetime/unity8*
+
+== Desktop Profile Tests ==
+
+ * Run tests indicator-datetime/unity7*
+
+== Alarm Tests ==
+
+ * Hardware wakeups for new alarms:
+   1. Create and save an upcoming alarm in ubuntu-clock-app.
+   2. Unplug the phone from any USB connection and put it to sleep.
+   3. Confirm that the alarm sounds on time even if the phone is asleep.
+      (Note: if in doubt about sleep you can see in the syslog whether the
+      device actually suspended or whether the suspend was aborted)
+
+ * Hardware wakeups for edited alarms:
+   1. Edit an alarm that's already passed. (see previous test)
+   2. Unplug the phone from any USB connection and put it to sleep.
+   3. Confirm that the alarm sounds on time even if the phone is asleep.
+      (Note: if in doubt about sleep you can see in the syslog whether the
+      device actually suspended or whether the suspend was aborted.)
+
+