diff options
| author | Ted Gould <ted@gould.cx> | 2014-02-19 18:02:35 +0000 |
|---|---|---|
| committer | CI bot <ps-jenkins@lists.canonical.com> | 2014-02-19 18:02:35 +0000 |
| commit | bf7ca1ab140d9da7d9b9842971b1b7cee2c558ed (patch) | |
| tree | a1472ee84a9269eba5ae28db6804c03d6b5696a6 /MERGE-REVIEW | |
| parent | 359764b5ea8926ae372844155b1394ebe06e3174 (diff) | |
| parent | fe62f43c781c561b64ade3aa2173005e1c599b66 (diff) | |
| download | ayatana-indicator-datetime-bf7ca1ab140d9da7d9b9842971b1b7cee2c558ed.tar.gz ayatana-indicator-datetime-bf7ca1ab140d9da7d9b9842971b1b7cee2c558ed.tar.bz2 ayatana-indicator-datetime-bf7ca1ab140d9da7d9b9842971b1b7cee2c558ed.zip | |
Adding acceptance tests and merge review policies
Diffstat (limited to 'MERGE-REVIEW')
| -rw-r--r-- | MERGE-REVIEW | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/MERGE-REVIEW b/MERGE-REVIEW new file mode 100644 index 0000000..5e40f45 --- /dev/null +++ b/MERGE-REVIEW @@ -0,0 +1,19 @@ + +This documents the expections that the project has on what both submitters +and reviewers should ensure that they've done for a merge into the project. + +== Submitter Responsibilities == + + * Ensure the project compiles and the test suite executes without error + * Ensure that non-obvious code has comments explaining it + * If the change works on specific profiles, please include those in the merge description. + +== Reviewer Responsibilities == + + * Did the Jenkins build compile? Pass? Run unit tests successfully? + * Are there appropriate tests to cover any new functionality? + * If the description says this effects the phone profile: + * Run tests indicator-datetime/unity8* + * If the description says this effects the desktop profile: + * Run tests indicator-datetime/unity7* + |