aboutsummaryrefslogtreecommitdiff
path: root/tests
diff options
context:
space:
mode:
authorCharles Kerr <charles.kerr@canonical.com>2014-01-30 18:40:13 -0600
committerCharles Kerr <charles.kerr@canonical.com>2014-01-30 18:40:13 -0600
commit271b0fbf8b14a4f7a8f47de0e3a8751bd50676c3 (patch)
tree0d8f4a2a9e99f61c5d7946653e7dd9eb3aac66d0 /tests
parenta7a09a5ca5012fb1c48f259d2587542316e7349b (diff)
downloadayatana-indicator-datetime-271b0fbf8b14a4f7a8f47de0e3a8751bd50676c3.tar.gz
ayatana-indicator-datetime-271b0fbf8b14a4f7a8f47de0e3a8751bd50676c3.tar.bz2
ayatana-indicator-datetime-271b0fbf8b14a4f7a8f47de0e3a8751bd50676c3.zip
copyediting: remove dead '#if 0''ed code
Diffstat (limited to 'tests')
-rw-r--r--tests/test-settings.cpp6
-rw-r--r--tests/test-timezone-geoclue.cpp59
2 files changed, 5 insertions, 60 deletions
diff --git a/tests/test-settings.cpp b/tests/test-settings.cpp
index df01cd7..980e7fa 100644
--- a/tests/test-settings.cpp
+++ b/tests/test-settings.cpp
@@ -189,9 +189,3 @@ TEST_F(SettingsFixture, Locations)
g_strfreev(tmp);
EXPECT_EQ(bv, vtmp);
}
-
-#if 0
- core::Property<std::vector<std::string>> locations;
- core::Property<TimeFormatMode> time_format_mode;
-
-#endif
diff --git a/tests/test-timezone-geoclue.cpp b/tests/test-timezone-geoclue.cpp
index 4bf08a7..3cc1393 100644
--- a/tests/test-timezone-geoclue.cpp
+++ b/tests/test-timezone-geoclue.cpp
@@ -21,64 +21,17 @@
#include <datetime/timezone-geoclue.h>
-//#include <libdbustest/dbus-test.h>
-
using unity::indicator::datetime::GeoclueTimezone;
-/***
-****
-***/
-
-class TimezoneGeoclueFixture : public GeoclueFixture
-{
-};
-
-#if 0
-namespace
+// This test looks small because the interesting
+// work is all happening in GeoclueFixture...
+TEST_F(GeoclueFixture, ChangeDetected)
{
- struct EmitAddressChangedData
- {
- DbusTestDbusMock * mock = nullptr;
- DbusTestDbusMockObject * obj_client = nullptr;
- std::string timezone;
- EmitAddressChangedData(DbusTestDbusMock * mock_,
- DbusTestDbusMockObject * obj_client_,
- const std::string& timezone_): mock(mock_), obj_client(obj_client_), timezone(timezone_) {}
- };
-
- gboolean emit_address_changed_idle(gpointer gdata)
- {
- auto data = static_cast<EmitAddressChangedData*>(gdata);
-
- GError * error = nullptr;
- dbus_test_dbus_mock_object_emit_signal(data->mock, data->obj_client,
- "org.freedesktop.Geoclue.Address",
- "AddressChanged",
- G_VARIANT_TYPE("(ia{ss}(idd))"),
- g_variant_new_parsed("(1385238033, {'timezone': 'America/Chicago'}, (3, 0.0, 0.0))"),
- &error);
- if (error)
- {
- g_warning("%s: %s", G_STRFUNC, error->message);
- g_error_free(error);
- }
-
- delete data;
- return G_SOURCE_REMOVE;
- }
-}
-#endif
-
-TEST_F(TimezoneGeoclueFixture, ChangeDetected)
-{
-// const std::string timezone_1 = "America/Denver";
- const std::string timezone_2 = "America/Chicago";
-
GeoclueTimezone tz;
wait_msec(500); // wait for the bus to get set up
EXPECT_EQ(timezone_1, tz.timezone.get());
- // start listening for a timezone change, then change the timezone
+ // Start listening for a timezone change, then change the timezone.
bool changed = false;
auto connection = tz.timezone.changed().connect(
@@ -88,10 +41,8 @@ TEST_F(TimezoneGeoclueFixture, ChangeDetected)
g_main_loop_quit(loop);
});
+ const std::string timezone_2 = "America/Chicago";
setGeoclueTimezoneOnIdle(timezone_2);
- //g_timeout_add(50, emit_address_changed_idle, new EmitAddressChangedData(mock, obj_client, timezone_2.c_str()));
g_main_loop_run(loop);
EXPECT_EQ(timezone_2, tz.timezone.get());
}
-
-