add (failing) regression test for x-canonical-alarm components whose valarms have no triggers

4 files changed, 186 insertions, 0 deletions

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
index 1e22100..123aa9a 100644
--- a/tests/CMakeLists.txt
+++ b/tests/CMakeLists.txt
@@ -98,6 +98,7 @@ add_eds_ics_test_by_name(test-eds-ics-all-day-events)
 add_eds_ics_test_by_name(test-eds-ics-repeating-events)
 add_eds_ics_test_by_name(test-eds-ics-nonrepeating-events)
 add_eds_ics_test_by_name(test-eds-ics-repeating-valarms)
+add_eds_ics_test_by_name(test-eds-ics-missing-trigger)
 
 
 # disabling the timezone unit tests because they require
diff --git a/tests/print-to.h b/tests/print-to.h
index f4af2f7..357925f 100644
--- a/tests/print-to.h
+++ b/tests/print-to.h
@@ -47,6 +47,30 @@ PrintTo(const Alarm& alarm, std::ostream* os)
     *os << '}';
 }
 
+void
+PrintTo(const Appointment& appointment, std::ostream* os)
+{
+    *os << '{';
+
+    *os << "{uid:'" << appointment.uid << "'}"
+        << "{color:'" << appointment.color << "'}"
+        << "{summary:'" << appointment.summary << "'}"
+        << "{activation_url:'" << appointment.activation_url << "'}";
+
+    *os << "{begin:";
+    PrintTo(appointment.begin, os);
+    *os << '}';
+
+    *os << "{end:";
+    PrintTo(appointment.end, os);
+    *os << '}';
+
+    for(const auto& alarm : appointment.alarms)
+        PrintTo(alarm, os);
+
+    *os << '}';
+}
+
 } // namespace datetime
 } // namespace indicator
 } // namespace unity
diff --git a/tests/test-eds-ics-missing-trigger.cpp b/tests/test-eds-ics-missing-trigger.cpp
new file mode 100644
index 0000000..ba87011
--- /dev/null
+++ b/tests/test-eds-ics-missing-trigger.cpp
@@ -0,0 +1,116 @@
+/*
+ * Copyright 2015 Canonical Ltd.
+ *
+ * This program is free software: you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 3, as published
+ * by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful, but
+ * WITHOUT ANY WARRANTY; without even the implied warranties of
+ * MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+ * PURPOSE.  See the GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authors:
+ *   Charles Kerr <charles.kerr@canonical.com>
+ */
+
+#include <algorithm>
+
+#include <datetime/alarm-queue-simple.h>
+#include <datetime/clock-mock.h>
+#include <datetime/engine-eds.h>
+#include <datetime/planner-range.h>
+
+#include <gtest/gtest.h>
+
+#include "glib-fixture.h"
+#include "print-to.h"
+#include "timezone-mock.h"
+#include "wakeup-timer-mock.h"
+
+using namespace unity::indicator::datetime;
+using VAlarmFixture = GlibFixture;
+
+/***
+****
+***/
+
+TEST_F(VAlarmFixture, MissingTriggers)
+{
+    // start the EDS engine
+    auto engine = std::make_shared<EdsEngine>();
+
+    // we need a consistent timezone for the planner and our local DateTimes
+    constexpr char const * zone_str {"America/Chicago"};
+    auto tz = std::make_shared<MockTimezone>(zone_str);
+    auto gtz = g_time_zone_new(zone_str);
+
+    // make a planner that looks at the first half of 2015 in EDS
+    auto planner = std::make_shared<SimpleRangePlanner>(engine, tz);
+    const DateTime range_begin {gtz, 2015,1, 1, 0, 0, 0.0};
+    const DateTime range_end   {gtz, 2015,6,31,23,59,59.5};
+    planner->range().set(std::make_pair(range_begin, range_end));
+
+    // give EDS a moment to load
+    if (planner->appointments().get().empty()) {
+        g_message("waiting a moment for EDS to load...");
+        auto on_appointments_changed = [this](const std::vector<Appointment>& appointments){
+            g_message("ah, they loaded");
+            if (!appointments.empty())
+                g_main_loop_quit(loop);
+        };
+        core::ScopedConnection conn(planner->appointments().changed().connect(on_appointments_changed));
+        constexpr int max_wait_sec = 10;
+        wait_msec(max_wait_sec * G_TIME_SPAN_MILLISECOND);
+    }
+
+    // build expected: one-time alarm
+    std::vector<Appointment> expected;
+    Appointment a;
+    a.type = Appointment::UBUNTU_ALARM;
+    a.uid = "20150617T211838Z-6217-32011-2036-1@ubuntu-phablet";
+    a.color = "#becedd";
+    a.summary = "One Time Alarm";
+    a.begin = DateTime { gtz, 2015, 6, 18, 10, 0, 0};
+    a.end = a.begin;
+    a.alarms.resize(1);
+    a.alarms[0].audio_url = "file:///usr/share/sounds/ubuntu/ringtones/Suru arpeggio.ogg";
+    a.alarms[0].time = a.begin;
+    a.alarms[0].text = a.summary;
+    expected.push_back(a);
+
+    // build expected: recurring alarm
+    a.uid = "20150617T211913Z-6217-32011-2036-5@ubuntu-phablet";
+    a.summary = "Recurring Alarm";
+    a.alarms[0].text = a.summary;
+    std::array<DateTime,14> recurrences {
+        DateTime{ gtz, 2015, 6, 18, 10, 1, 0 },
+        DateTime{ gtz, 2015, 6, 19, 10, 1, 0 },
+        DateTime{ gtz, 2015, 6, 20, 10, 1, 0 },
+        DateTime{ gtz, 2015, 6, 21, 10, 1, 0 },
+        DateTime{ gtz, 2015, 6, 22, 10, 1, 0 },
+        DateTime{ gtz, 2015, 6, 23, 10, 1, 0 },
+        DateTime{ gtz, 2015, 6, 24, 10, 1, 0 },
+        DateTime{ gtz, 2015, 6, 25, 10, 1, 0 },
+        DateTime{ gtz, 2015, 6, 26, 10, 1, 0 },
+        DateTime{ gtz, 2015, 6, 27, 10, 1, 0 },
+        DateTime{ gtz, 2015, 6, 28, 10, 1, 0 },
+        DateTime{ gtz, 2015, 6, 29, 10, 1, 0 },
+        DateTime{ gtz, 2015, 6, 30, 10, 1, 0 },
+        DateTime{ gtz, 2015, 7,  1, 10, 1, 0 }
+    };
+    for (const auto& time : recurrences) {
+        a.begin = a.end = a.alarms[0].time = time;
+        expected.push_back(a);
+    }
+
+    // the planner should match what we've got in the calendar.ics file
+    const auto appts = planner->appointments().get();
+    EXPECT_EQ(expected, appts);
+
+    // cleanup
+    g_time_zone_unref(gtz);
+}
diff --git a/tests/test-eds-ics-missing-trigger.ics b/tests/test-eds-ics-missing-trigger.ics
new file mode 100644
index 0000000..048e7f2
--- /dev/null
+++ b/tests/test-eds-ics-missing-trigger.ics
@@ -0,0 +1,45 @@
+BEGIN:VCALENDAR

+CALSCALE:GREGORIAN

+PRODID:-//Ximian//NONSGML Evolution Calendar//EN

+VERSION:2.0

+X-EVOLUTION-DATA-REVISION:2015-06-17T21:19:13.980613Z(3)

+BEGIN:VTODO

+UID:20150617T211838Z-6217-32011-2036-1@ubuntu-phablet

+DTSTAMP:20150617T211838Z

+DTSTART:20150618T100000

+SUMMARY:One Time Alarm

+CATEGORIES:x-canonical-alarm

+CREATED:20150617T211838Z

+LAST-MODIFIED:20150617T211838Z

+BEGIN:VALARM

+X-EVOLUTION-ALARM-UID:20150617T211838Z-6217-32011-2036-2@ubuntu-phablet

+ACTION:AUDIO

+ATTACH:file:///usr/share/sounds/ubuntu/ringtones/Suru arpeggio.ogg

+END:VALARM

+BEGIN:VALARM

+X-EVOLUTION-ALARM-UID:20150617T211838Z-6217-32011-2036-3@ubuntu-phablet

+ACTION:DISPLAY

+DESCRIPTION:One Time Alarm

+END:VALARM

+END:VTODO

+BEGIN:VTODO

+UID:20150617T211913Z-6217-32011-2036-5@ubuntu-phablet

+DTSTAMP:20150617T211913Z

+DTSTART:20150618T100100

+RRULE:FREQ=DAILY

+SUMMARY:Recurring Alarm

+CATEGORIES:x-canonical-alarm

+CREATED:20150617T211913Z

+LAST-MODIFIED:20150617T211913Z

+BEGIN:VALARM

+X-EVOLUTION-ALARM-UID:20150617T211913Z-6217-32011-2036-6@ubuntu-phablet

+ACTION:AUDIO

+ATTACH:file:///usr/share/sounds/ubuntu/ringtones/Suru arpeggio.ogg

+END:VALARM

+BEGIN:VALARM

+X-EVOLUTION-ALARM-UID:20150617T211913Z-6217-32011-2036-7@ubuntu-phablet

+ACTION:DISPLAY

+DESCRIPTION:Recurring Alarm

+END:VALARM

+END:VTODO

+END:VCALENDAR