Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | copyediting: as per review, use name_of_thing() instead of ↵ | Charles Kerr | 2014-01-30 | 7 | -32/+32 |
| | | | | get_name_of_thing() or getNameOfThing() | ||||
* | following on the review comment covered in the last commit, use ↵ | Charles Kerr | 2014-01-30 | 6 | -23/+24 |
| | | | | shared_ptr<const X> instead of shared_ptr<X> where possible. | ||||
* | as per review, there were a few places that accidentally passed a ↵ | Charles Kerr | 2014-01-30 | 2 | -4/+4 |
| | | | | shared_ptr<X>& instead of a const shared_ptr<X>& | ||||
* | as per review, constify getters where possible. This isn't always possible ↵ | Charles Kerr | 2014-01-30 | 2 | -8/+3 |
| | | | | due to system APIs asking for non-const pointers. | ||||
* | as per review, make explicit the dependency injection that was implicit in ↵ | Charles Kerr | 2014-01-30 | 3 | -60/+18 |
| | | | | main() | ||||
* | as per review, don't inline unless there are performance issues | Charles Kerr | 2014-01-30 | 7 | -0/+99 |
| | |||||
* | as per review, don't inline getters | Charles Kerr | 2014-01-30 | 3 | -0/+47 |
| | |||||
* | fix 'clock app' menuitem on phone profile reported by seb128 and update the ↵ | Charles Kerr | 2014-01-30 | 1 | -4/+13 |
| | | | | corresponding unit tests | ||||
* | remove unused old file | Charles Kerr | 2014-01-29 | 1 | -2432/+0 |
| | |||||
* | sync with trunk | Charles Kerr | 2014-01-29 | 1 | -1/+18 |
|\ | |||||
| * | Set calendar to the current date when the menu is popped up | Lars Uebernickel | 2014-01-29 | 1 | -1/+18 |
| | | | | | | | | | | | | This makes use of the "submenu-action" attribute to get notified when the menu is popped up. | ||||
* | | fix disabled 'Add Event…' menuitem issue reported in testing by seb128; ↵ | Charles Kerr | 2014-01-29 | 1 | -1/+1 |
| | | | | | | | | add a test for this regression | ||||
* | | fix instant calendar toggle issue reported in testing by seb128; add a test ↵ | Charles Kerr | 2014-01-29 | 1 | -2/+5 |
| | | | | | | | | for this regression | ||||
* | | sync with lp:~larsu/indicator-datetime/reset-date and add corresponding unit ↵ | Charles Kerr | 2014-01-29 | 2 | -3/+19 |
| | | | | | | | | tests. | ||||
* | | fix g_date_time_format() leak found by valgrind testing | Charles Kerr | 2014-01-28 | 1 | -2/+6 |
| | | |||||
* | | fix GDateTime leak found by valgrind testing | Charles Kerr | 2014-01-28 | 1 | -3/+3 |
| | | |||||
* | | fix Task leak found by valgrind testing | Charles Kerr | 2014-01-28 | 1 | -0/+1 |
| | | |||||
* | | fix free-memory-read bug found by valgrind testing | Charles Kerr | 2014-01-28 | 1 | -2/+1 |
| | | |||||
* | | cleanup from previous commit: since Formatter code was migrated to utils.c ↵ | Charles Kerr | 2014-01-28 | 2 | -167/+6 |
| | | | | | | | | so that it could be used standalone by the panels, there's now code duplication between Utils and Formatter. Remove code duplication s.t. Formatter uses the Utils code as well. | ||||
* | | make utils.cpp's generate_full_format_string_at_time() a standalone function ↵ | Charles Kerr | 2014-01-28 | 3 | -155/+309 |
| | | | | | | | | so that the panels can use the utils functions without a libindicatordatetime dependency | ||||
* | | silence compiler warning | Charles Kerr | 2014-01-28 | 1 | -1/+1 |
| | | |||||
* | | merge lp:~robert-ancell/indicator-datetime/call-ucc into lp:indicator-datetime | Charles Kerr | 2014-01-27 | 2 | -4/+27 |
|\| | |||||
| * | Run the unity-control-center panel under Unity. Rename the unity panel to ↵ | Robert Ancell | 2014-01-22 | 1 | -2/+14 |
| | | | | | | | | just "datetime" | ||||
| * | fix minor naming error in the interim library that we link the unit tests ↵ | Charles Kerr | 2013-12-13 | 1 | -1/+1 |
| | | | | | | | | and final product service against | ||||
| * | move the phone & desktop common elements of header time format into a ↵ | Charles Kerr | 2013-12-13 | 1 | -17/+30 |
| | | | | | | | | private util, get_default_header_time_format(), and have the phone & desktop functions call it. | ||||
* | | remove code duplication between formatter.cpp and utils.cpp | Charles Kerr | 2014-01-27 | 2 | -12/+6 |
| | | |||||
* | | re-enable coverage-html reports | Charles Kerr | 2014-01-27 | 1 | -8/+1 |
| | | |||||
* | | sync the exported calendar state with the #State backend | Charles Kerr | 2014-01-25 | 3 | -8/+28 |
| | | |||||
* | | Alarms is going to need to know when the clock's minute changes. We already ↵ | Charles Kerr | 2014-01-22 | 4 | -147/+139 |
| | | | | | | | | have a timer for that in Formatter, so move it from there to Clock and add a corresponding public signal Clock.minuteChanged that both Formatter and Alarms can use. Sync unit tests. | ||||
* | | Remove the Timezones property from Clock; it's only needed by the subclass ↵ | Charles Kerr | 2014-01-22 | 2 | -5/+1 |
| | | | | | | | | LiveClock | ||||
* | | fix r325 regression found by test-menus | Charles Kerr | 2014-01-22 | 1 | -2/+2 |
| | | |||||
* | | remove the State.timezones property. Timezones is a helper class for ↵ | Charles Kerr | 2014-01-22 | 1 | -1/+0 |
| | | | | | | | | LiveClock and doesn't need to be public in State. | ||||
* | | follow-up to r326, if we can't get the alarm icon from click, use a sane ↵ | Charles Kerr | 2014-01-22 | 1 | -2/+9 |
| | | | | | | | | fallback icon | ||||
* | | copyediting: omit unnecessary #includes | Charles Kerr | 2014-01-22 | 1 | -4/+0 |
| | | |||||
* | | the clock icon should match the one used by the clock app, so use click to ↵ | Charles Kerr | 2014-01-22 | 2 | -9/+54 |
| | | | | | | | | ask the clock app which icon it's using | ||||
* | | plug in the greeter menus | Charles Kerr | 2014-01-22 | 3 | -4/+7 |
| | | |||||
* | | in PlannerEds, replace g_message() console messages with g_debug() | Charles Kerr | 2014-01-22 | 1 | -12/+11 |
| | | |||||
* | | in PlannerEds, wire in planner.thisMonth and planner.upcoming | Charles Kerr | 2014-01-22 | 1 | -0/+2 |
| | | |||||
* | | copyediting: rename Service as Exporter & tweak comments | Charles Kerr | 2014-01-22 | 3 | -14/+18 |
| | | |||||
* | | extract LiveState to its own State subclass to make main()'s flow easier to ↵ | Charles Kerr | 2014-01-22 | 2 | -34/+70 |
| | | | | | | | | follow | ||||
* | | move DateTime's impl from the header to a cc file | Charles Kerr | 2014-01-22 | 2 | -1/+160 |
| | | |||||
* | | add LiveActions implementation and unit tests | Charles Kerr | 2014-01-21 | 1 | -13/+140 |
| | | |||||
* | | get timezone, clock tests running again with Settings & State | Charles Kerr | 2014-01-16 | 2 | -10/+5 |
| | | |||||
* | | fix minor -Wpedantic warnings | Charles Kerr | 2014-01-16 | 1 | -3/+3 |
| | | |||||
* | | sync with new State class changes | Charles Kerr | 2014-01-16 | 1 | -8/+19 |
| | | |||||
* | | fix minor -Wshadow warnings | Charles Kerr | 2014-01-16 | 1 | -4/+4 |
| | | |||||
* | | update timezones-live to use Settings to tell when the user has ↵ | Charles Kerr | 2014-01-16 | 1 | -4/+8 |
| | | | | | | | | enabled/disabled GeoClue lookups | ||||
* | | in utils.c, make a version of get_timezone_name() that doesn't require a ↵ | Charles Kerr | 2014-01-16 | 1 | -36/+53 |
| | | | | | | | | GSettings argument. Update utils tests. | ||||
* | | Plug the Settings object into the State container s.t. menus and actions can ↵ | Charles Kerr | 2014-01-16 | 2 | -17/+7 |
| | | | | | | | | update themselves when the user's settings change. | ||||
* | | update SettingsLocations class to use the "Settings" class instead of using ↵ | Charles Kerr | 2014-01-16 | 1 | -32/+18 |
| | | | | | | | | GSettings directly. |