From 86333cb7f91ef594088ded32927454940745d96d Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Thu, 5 Sep 2013 13:24:28 -0500 Subject: in our private T_() function, avoid a couple of unnecessary strdup & frees --- src/utils.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/utils.c b/src/utils.c index b99de94..50d896d 100644 --- a/src/utils.c +++ b/src/utils.c @@ -134,9 +134,9 @@ T_(const char *msg) LC_MESSAGES directory, so we won't find any translation there. */ char *message_locale = g_strdup(setlocale(LC_MESSAGES, NULL)); - char *time_locale = g_strdup(setlocale(LC_TIME, NULL)); + const char *time_locale = setlocale (LC_TIME, NULL); char *language = g_strdup(g_getenv("LANGUAGE")); - char *rv; + const char *rv; if (language) g_unsetenv("LANGUAGE"); setlocale(LC_MESSAGES, time_locale); @@ -149,7 +149,6 @@ T_(const char *msg) if (language) g_setenv("LANGUAGE", language, TRUE); g_free(message_locale); - g_free(time_locale); g_free(language); return rv; } -- cgit v1.2.3 From 1272fff388d793a44dc166850e5f1005bb5741b0 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Thu, 5 Sep 2013 13:25:05 -0500 Subject: in service.c, use g_variant_new_take_string() instead of g_variant_new_string() where appropriate --- src/service.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) (limited to 'src') diff --git a/src/service.c b/src/service.c index c36e996..d7ae22f 100644 --- a/src/service.c +++ b/src/service.c @@ -499,12 +499,11 @@ create_desktop_header_state (IndicatorDatetimeService * self) g_variant_builder_init (&b, G_VARIANT_TYPE("a{sv}")); g_variant_builder_add (&b, "{sv}", "accessible-desc", g_variant_new_string (str)); - g_variant_builder_add (&b, "{sv}", "label", g_variant_new_string (str)); + g_variant_builder_add (&b, "{sv}", "label", g_variant_new_take_string (str)); g_variant_builder_add (&b, "{sv}", "visible", g_variant_new_boolean (visible)); /* cleanup */ g_date_time_unref (now); - g_free (str); g_free (fmt); return g_variant_builder_end (&b); } @@ -528,7 +527,6 @@ create_phone_header_state (IndicatorDatetimeService * self) now = indicator_datetime_service_get_localtime (self); fmt = get_terse_time_format_string (now); label = g_date_time_format (now, fmt); - g_variant_builder_add (&b, "{sv}", "label", g_variant_new_string (label)); /* icon */ if ((has_alarms = service_has_alarms (self))) @@ -545,14 +543,12 @@ create_phone_header_state (IndicatorDatetimeService * self) else a11y = g_strdup (label); g_variant_builder_add (&b, "{sv}", "accessible-desc", - g_variant_new_string (a11y)); + g_variant_new_take_string (a11y)); - /* visible */ g_variant_builder_add (&b, "{sv}", "visible", g_variant_new_boolean (TRUE)); + g_variant_builder_add (&b, "{sv}", "label", g_variant_new_take_string (label)); /* cleanup */ - g_free (a11y); - g_free (label); g_date_time_unref (now); return g_variant_builder_end (&b); } -- cgit v1.2.3 From 88275c3ae0a002a50a594fb0193805e51f80060d Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Sat, 7 Sep 2013 07:45:58 -0500 Subject: remove unnecessary strdup/free of the location menuitems' labels --- src/service.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src') diff --git a/src/service.c b/src/service.c index 2e7b30c..45d152c 100644 --- a/src/service.c +++ b/src/service.c @@ -1030,12 +1030,12 @@ create_locations_section (IndicatorDatetimeService * self) struct TimeLocation * loc = l->data; if (loc->visible) { - char * label; + const char * label; char * detailed_action; char * fmt; GMenuItem * menu_item; - label = g_strdup (loc->name); + label = loc->name; detailed_action = g_strdup_printf ("indicator.set-location::%s %s", loc->zone, loc->name); @@ -1053,7 +1053,6 @@ create_locations_section (IndicatorDatetimeService * self) g_object_unref (menu_item); g_free (fmt); g_free (detailed_action); - g_free (label); } } -- cgit v1.2.3 From f1152966057612e552fb44528bb523e20a61fcac Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Sat, 7 Sep 2013 07:46:17 -0500 Subject: remove unnecessary strdup/free of the location menuitems' labels --- src/service.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'src') diff --git a/src/service.c b/src/service.c index 45d152c..03a2bb4 100644 --- a/src/service.c +++ b/src/service.c @@ -648,10 +648,8 @@ add_localtime_menuitem (GMenu * menu, static void add_calendar_menuitem (GMenu * menu) { - char * label; GMenuItem * menu_item; - label = g_strdup ("[calendar]"); menu_item = g_menu_item_new ("[calendar]", NULL); g_menu_item_set_action_and_target_value (menu_item, "indicator.calendar", g_variant_new_int64(0)); g_menu_item_set_attribute (menu_item, "x-canonical-type", "s", "com.canonical.indicator.calendar"); @@ -659,7 +657,6 @@ add_calendar_menuitem (GMenu * menu) g_menu_append_item (menu, menu_item); g_object_unref (menu_item); - g_free (label); } static GMenuModel * -- cgit v1.2.3 From 05d0c98b1918fa97369e8b99f6848c19d7b97099 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Sat, 7 Sep 2013 09:29:56 -0500 Subject: in service.c's create_locations_section(), remove an unnecessary temporary --- src/service.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src') diff --git a/src/service.c b/src/service.c index 03a2bb4..5d90235 100644 --- a/src/service.c +++ b/src/service.c @@ -1027,18 +1027,16 @@ create_locations_section (IndicatorDatetimeService * self) struct TimeLocation * loc = l->data; if (loc->visible) { - const char * label; char * detailed_action; char * fmt; GMenuItem * menu_item; - label = loc->name; detailed_action = g_strdup_printf ("indicator.set-location::%s %s", loc->zone, loc->name); fmt = generate_full_format_string_at_time (now, loc->local_time); - menu_item = g_menu_item_new (label, detailed_action); + menu_item = g_menu_item_new (loc->name, detailed_action); g_menu_item_set_attribute (menu_item, "x-canonical-type", "s", "com.canonical.indicator.location"); g_menu_item_set_attribute (menu_item, "x-canonical-timezone", -- cgit v1.2.3