| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
| |
- Making the problematic parts "const" produce even more warnings, so I'm considering this a false positive and disabling it
|
|
|
|
| |
Mark unused adbd_server and usb_manager as such.
|
|
|
|
|
|
|
|
| |
- src/rotation-lock.cpp: Fix double declaration of create_desktop_menu
- tests/CMakeLists.txt: Add uninitDerivedMemberVar and unmatchedSuppression suppressions to cppcheck
- tests/unit/rotation-lock-test.cpp: Fix and expand test
fixes https://github.com/AyatanaIndicators/ayatana-indicator-display/issues/24
|
| |
|
|
|
|
| |
--suppress parameters.
|
|
|
|
| |
is used.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
explicitly declared constructor.
Resolves issues like these:
In file included from /rootdir/tests/unit/rotation-lock-test.cpp:20:
In file included from /rootdir/tests/utils/test-dbus-fixture.h:22:
In file included from /rootdir/tests/utils/glib-fixture.h:30:
In file included from /usr/src/googletest/googletest/include/gtest/gtest.h:62:
/usr/src/googletest/googletest/include/gtest/internal/gtest-internal.h:472:44: error: call to implicitly-deleted default constructor of 'RotationLockFixture_CheckIndicator_Test'
Test* CreateTest() override { return new TestClass; }
^
/rootdir/tests/unit/rotation-lock-test.cpp:46:1: note: in instantiation of member function 'testing::internal::TestFactoryImpl<RotationLockFixture_CheckIndicator_Test>::CreateTest' requested here
TEST_F(RotationLockFixture, CheckIndicator)
^
/usr/src/googletest/googletest/include/gtest/gtest.h:2381:3: note: expanded from macro 'TEST_F'
GTEST_TEST_(test_fixture, test_name, test_fixture, \
^
/usr/src/googletest/googletest/include/gtest/internal/gtest-internal.h:1565:15: note: expanded from macro 'GTEST_TEST_'
new ::testing::internal::TestFactoryImpl<GTEST_TEST_CLASS_NAME_( \
^
/rootdir/tests/unit/rotation-lock-test.cpp:46:1: note: explicitly defaulted function was implicitly deleted here
/usr/src/googletest/googletest/include/gtest/gtest.h:2381:3: note: expanded from macro 'TEST_F'
GTEST_TEST_(test_fixture, test_name, test_fixture, \
^
/usr/src/googletest/googletest/include/gtest/internal/gtest-internal.h:1544:5: note: expanded from macro 'GTEST_TEST_'
GTEST_TEST_CLASS_NAME_(test_suite_name, test_name)() = default; \
^
/usr/src/googletest/googletest/include/gtest/internal/gtest-internal.h:1533:3: note: expanded from macro 'GTEST_TEST_CLASS_NAME_'
test_suite_name##_##test_name##_Test
^
<scratch space>:198:1: note: expanded from here
RotationLockFixture_CheckIndicator_Test
^
/rootdir/tests/unit/rotation-lock-test.cpp:46:1: note: default constructor of 'RotationLockFixture_CheckIndicator_Test' is implicitly deleted because base class 'RotationLockFixture' has a deleted default constructor
/usr/src/googletest/googletest/include/gtest/gtest.h:2381:3: note: expanded from macro 'TEST_F'
GTEST_TEST_(test_fixture, test_name, test_fixture, \
^
/usr/src/googletest/googletest/include/gtest/internal/gtest-internal.h:1542:9: note: expanded from macro 'GTEST_TEST_'
: public parent_class { \
^
/rootdir/tests/unit/rotation-lock-test.cpp:24:28: note: default constructor of 'RotationLockFixture' is implicitly deleted because base class 'TestDBusFixture' has a deleted default constructor
class RotationLockFixture: public TestDBusFixture
^
/rootdir/tests/utils/test-dbus-fixture.h:32:5: note: explicitly defaulted function was implicitly deleted here
TestDBusFixture() =default;
^
/rootdir/tests/utils/test-dbus-fixture.h:69:36: note: default constructor of 'TestDBusFixture' is implicitly deleted because field 'service_dirs' of const-qualified type 'const std::vector<std::string>' (aka 'const vector<basic_string<char>>') would not be initialized
const std::vector<std::string> service_dirs;
^
2 warnings and 1 error generated.
|
|
|
|
| |
--suppress=unusedFunction. Be less strict and make the cppcheck pass.
|
| |
|
|
|
|
| |
(which is one of our unit tests).
|
| |
|
| |
|
| |
|
| |
|
|\ |
|
| |
| |
| |
| | |
each time there's a usb disconnect
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
creating the adb socket in AdbdServer's ctor instead of in its worker thread.
|
| |
| |
| |
| | |
from an 'is_active' bool to a three-value state of active, inactive, and unavailable
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
| |
| |
| | |
test
|
|/ |
|
| |
|
|
|
|
| |
prompts
|
| |
|
| |
|
|
|
|
| |
on subsequent requests
|
| |
|
|
|
|
| |
give the test file and line number
|
|
|
|
| |
the prompt.
|
|
|
|
| |
fixtures' helper/util code
|
| |
|
|
|
|
| |
in one place
|
| |
|
|
|
|
| |
async dbus handling interfering with fast setup/teardown of automated tests. Revert the last change and fix by setting up the dbus signal subscription immediately upon getting the dbus connection.
|
|
|
|
| |
notification user response, but the tests on the phone are sometimes too slow for that timeout
|
|
|
|
| |
for g++ 4.9x
|
| |
|
|
|
|
| |
environment variables.
|
| |
|