From f1dde7a9245a257eac50c902b2080dcd25ba22c5 Mon Sep 17 00:00:00 2001 From: Mike Gabriel Date: Sat, 4 May 2024 09:00:46 +0000 Subject: cppcheck: Fix missingOverride complaints. --- tests/utils/glib-fixture.h | 2 +- tests/utils/test-dbus-fixture.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'tests') diff --git a/tests/utils/glib-fixture.h b/tests/utils/glib-fixture.h index ccdeccd..b56654b 100644 --- a/tests/utils/glib-fixture.h +++ b/tests/utils/glib-fixture.h @@ -35,7 +35,7 @@ class GlibFixture : public ::testing::Test { public: - virtual ~GlibFixture() =default; + virtual ~GlibFixture() override =default; protected: diff --git a/tests/utils/test-dbus-fixture.h b/tests/utils/test-dbus-fixture.h index b01405a..e98a002 100644 --- a/tests/utils/test-dbus-fixture.h +++ b/tests/utils/test-dbus-fixture.h @@ -30,7 +30,7 @@ class TestDBusFixture: public GlibFixture public: explicit TestDBusFixture() {}; - virtual ~TestDBusFixture() =default; + virtual ~TestDBusFixture() override =default; explicit TestDBusFixture(const std::vector& service_dirs_in): service_dirs(service_dirs_in) {} -- cgit v1.2.3 From 8c4b2d9c01ae3d526bde00d5ca8925ced053f9fc Mon Sep 17 00:00:00 2001 From: Mike Gabriel Date: Sat, 4 May 2024 09:01:16 +0000 Subject: cppcheck: Suppress constParameterCallback. See https://sourceforge.net/p/cppcheck/discussion/general/thread/6046fc0f43/ --- tests/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests') diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt index 81e083c..531f58b 100644 --- a/tests/CMakeLists.txt +++ b/tests/CMakeLists.txt @@ -28,7 +28,7 @@ endif() add_compile_options(${CXX_WARNING_ARGS}) -add_test(cppcheck cppcheck --enable=all -USCHEMA_DIR --error-exitcode=2 --inline-suppr --library=qt -I${CMAKE_SOURCE_DIR} -i${CMAKE_SOURCE_DIR}/tests/utils/qmain.cpp -i${CMAKE_SOURCE_DIR}/tests/gmock ${CMAKE_SOURCE_DIR}/src ${CMAKE_SOURCE_DIR}/tests --suppress=missingIncludeSystem --suppress=uninitDerivedMemberVar --suppress=unmatchedSuppression --suppress=constParameter --suppress=unusedFunction --suppress=uselessOverride) +add_test(cppcheck cppcheck --enable=all -USCHEMA_DIR --error-exitcode=2 --inline-suppr --library=qt -I${CMAKE_SOURCE_DIR} -i${CMAKE_SOURCE_DIR}/tests/utils/qmain.cpp -i${CMAKE_SOURCE_DIR}/tests/gmock ${CMAKE_SOURCE_DIR}/src ${CMAKE_SOURCE_DIR}/tests --suppress=missingIncludeSystem --suppress=uninitDerivedMemberVar --suppress=unmatchedSuppression --suppress=constParameter --suppress=constParameterCallback --suppress=unusedFunction --suppress=uselessOverride) add_subdirectory (unit) -- cgit v1.2.3 From bfb74193db0e172bb1db5fc837a4b1ee4688259f Mon Sep 17 00:00:00 2001 From: Mike Gabriel Date: Sat, 4 May 2024 09:03:13 +0000 Subject: cppcheck: Run with --check-level=exhaustive. Resolves 1: /ayatana-indicator-display/src/service.cpp:0:0: information: Limiting analysis of branches. Use --check-level=exhaustive to analyze all branches. [normalCheckLevelMaxBranches] --- tests/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'tests') diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt index 531f58b..bdc074f 100644 --- a/tests/CMakeLists.txt +++ b/tests/CMakeLists.txt @@ -28,7 +28,7 @@ endif() add_compile_options(${CXX_WARNING_ARGS}) -add_test(cppcheck cppcheck --enable=all -USCHEMA_DIR --error-exitcode=2 --inline-suppr --library=qt -I${CMAKE_SOURCE_DIR} -i${CMAKE_SOURCE_DIR}/tests/utils/qmain.cpp -i${CMAKE_SOURCE_DIR}/tests/gmock ${CMAKE_SOURCE_DIR}/src ${CMAKE_SOURCE_DIR}/tests --suppress=missingIncludeSystem --suppress=uninitDerivedMemberVar --suppress=unmatchedSuppression --suppress=constParameter --suppress=constParameterCallback --suppress=unusedFunction --suppress=uselessOverride) +add_test(cppcheck cppcheck --enable=all -USCHEMA_DIR --check-level=exhaustive --error-exitcode=2 --inline-suppr --library=qt -I${CMAKE_SOURCE_DIR} -i${CMAKE_SOURCE_DIR}/tests/utils/qmain.cpp -i${CMAKE_SOURCE_DIR}/tests/gmock ${CMAKE_SOURCE_DIR}/src ${CMAKE_SOURCE_DIR}/tests --suppress=missingIncludeSystem --suppress=uninitDerivedMemberVar --suppress=unmatchedSuppression --suppress=constParameter --suppress=constParameterCallback --suppress=unusedFunction --suppress=uselessOverride) add_subdirectory (unit) -- cgit v1.2.3