From 800cc787d343e9a78b9e4f7b146fa5b3effd6dbf Mon Sep 17 00:00:00 2001
From: Mike Gabriel <mike.gabriel@das-netzwerkteam.de>
Date: Wed, 9 Jun 2021 12:11:47 +0200
Subject: tests/test-dbus-fixture.h: Turn TestDBusFixture::TestDBusFixture into
 an explicitly declared constructor.

 Resolves issues like these:

 In file included from /rootdir/tests/unit/rotation-lock-test.cpp:20:
 In file included from /rootdir/tests/utils/test-dbus-fixture.h:22:
 In file included from /rootdir/tests/utils/glib-fixture.h:30:
 In file included from /usr/src/googletest/googletest/include/gtest/gtest.h:62:
 /usr/src/googletest/googletest/include/gtest/internal/gtest-internal.h:472:44: error: call to implicitly-deleted default constructor of 'RotationLockFixture_CheckIndicator_Test'
   Test* CreateTest() override { return new TestClass; }
                                            ^
 /rootdir/tests/unit/rotation-lock-test.cpp:46:1: note: in instantiation of member function 'testing::internal::TestFactoryImpl<RotationLockFixture_CheckIndicator_Test>::CreateTest' requested here
 TEST_F(RotationLockFixture, CheckIndicator)
 ^
 /usr/src/googletest/googletest/include/gtest/gtest.h:2381:3: note: expanded from macro 'TEST_F'
   GTEST_TEST_(test_fixture, test_name, test_fixture, \
   ^
 /usr/src/googletest/googletest/include/gtest/internal/gtest-internal.h:1565:15: note: expanded from macro 'GTEST_TEST_'
           new ::testing::internal::TestFactoryImpl<GTEST_TEST_CLASS_NAME_(    \
               ^
 /rootdir/tests/unit/rotation-lock-test.cpp:46:1: note: explicitly defaulted function was implicitly deleted here
 /usr/src/googletest/googletest/include/gtest/gtest.h:2381:3: note: expanded from macro 'TEST_F'
   GTEST_TEST_(test_fixture, test_name, test_fixture, \
   ^
 /usr/src/googletest/googletest/include/gtest/internal/gtest-internal.h:1544:5: note: expanded from macro 'GTEST_TEST_'
     GTEST_TEST_CLASS_NAME_(test_suite_name, test_name)() = default;           \
     ^
 /usr/src/googletest/googletest/include/gtest/internal/gtest-internal.h:1533:3: note: expanded from macro 'GTEST_TEST_CLASS_NAME_'
   test_suite_name##_##test_name##_Test
  ^
 <scratch space>:198:1: note: expanded from here
 RotationLockFixture_CheckIndicator_Test
 ^
 /rootdir/tests/unit/rotation-lock-test.cpp:46:1: note: default constructor of 'RotationLockFixture_CheckIndicator_Test' is implicitly deleted because base class 'RotationLockFixture' has a deleted default constructor
 /usr/src/googletest/googletest/include/gtest/gtest.h:2381:3: note: expanded from macro 'TEST_F'
   GTEST_TEST_(test_fixture, test_name, test_fixture, \
   ^
 /usr/src/googletest/googletest/include/gtest/internal/gtest-internal.h:1542:9: note: expanded from macro 'GTEST_TEST_'
       : public parent_class {                                                 \
         ^
 /rootdir/tests/unit/rotation-lock-test.cpp:24:28: note: default constructor of 'RotationLockFixture' is implicitly deleted because base class 'TestDBusFixture' has a deleted default constructor
 class RotationLockFixture: public TestDBusFixture
                            ^
 /rootdir/tests/utils/test-dbus-fixture.h:32:5: note: explicitly defaulted function was implicitly deleted here
     TestDBusFixture() =default;
     ^
 /rootdir/tests/utils/test-dbus-fixture.h:69:36: note: default constructor of 'TestDBusFixture' is implicitly deleted because field 'service_dirs' of const-qualified type 'const std::vector<std::string>' (aka 'const vector<basic_string<char>>') would not be initialized
     const std::vector<std::string> service_dirs;
                                    ^
 2 warnings and 1 error generated.
---
 tests/utils/test-dbus-fixture.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'tests')

diff --git a/tests/utils/test-dbus-fixture.h b/tests/utils/test-dbus-fixture.h
index 3947e58..b01405a 100644
--- a/tests/utils/test-dbus-fixture.h
+++ b/tests/utils/test-dbus-fixture.h
@@ -29,7 +29,7 @@ class TestDBusFixture: public GlibFixture
 {
   public:
 
-    TestDBusFixture() =default;
+    explicit TestDBusFixture() {};
     virtual ~TestDBusFixture() =default;
 
     explicit TestDBusFixture(const std::vector<std::string>& service_dirs_in): service_dirs(service_dirs_in) {}
-- 
cgit v1.2.3