diff options
| author | Ted Gould <ted@gould.cx> | 2014-01-31 14:20:26 -0600 |
|---|---|---|
| committer | Ted Gould <ted@gould.cx> | 2014-01-31 14:20:26 -0600 |
| commit | 2d34dda2ec4266697e2b4920fcc4afd50fe4fcd0 (patch) | |
| tree | 87175a717beb1216be3f30b25b08fdf36b5f7ef0 /MERGE-REVIEW | |
| parent | 7d44ce45c37cbebf085623502bedad9656e5bb0e (diff) | |
| download | ayatana-indicator-keyboard-2d34dda2ec4266697e2b4920fcc4afd50fe4fcd0.tar.gz ayatana-indicator-keyboard-2d34dda2ec4266697e2b4920fcc4afd50fe4fcd0.tar.bz2 ayatana-indicator-keyboard-2d34dda2ec4266697e2b4920fcc4afd50fe4fcd0.zip | |
Adding merge review policy
Diffstat (limited to 'MERGE-REVIEW')
| -rw-r--r-- | MERGE-REVIEW | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/MERGE-REVIEW b/MERGE-REVIEW new file mode 100644 index 00000000..9f43fc0d --- /dev/null +++ b/MERGE-REVIEW @@ -0,0 +1,19 @@ + +This documents the expections that the project has on what both submitters +and reviewers should ensure that they've done for a merge into the project. + +== Submitter Responsibilities == + + * Ensure the project compiles and the test suite executes without error + * Ensure that non-obvious code has comments explaining it + * If the change works on specific profiles, please include those in the merge description. + +== Reviewer Responsibilities == + + * Did the Jenkins build compile? Pass? Run unit tests successfully? + * Are there appropriate tests to cover any new functionality? + * If the description says this effects the phone profile: + * Run tests indicator-keyboard/unity8* + * If the description says this effects the desktop profile: + * Run tests indicator-keyboard/unity7* + |