From 49783d7014a6f5342ec77f56e81aeab6954bc2ec Mon Sep 17 00:00:00 2001 From: William Hua Date: Wed, 7 Aug 2013 10:45:42 -0400 Subject: Resolve flaky test by forcing a delay. --- po/indicator-keyboard.pot | 8 ++++---- tests/main.vala | 10 ++-------- 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/po/indicator-keyboard.pot b/po/indicator-keyboard.pot index a96fdd39..4433c98f 100644 --- a/po/indicator-keyboard.pot +++ b/po/indicator-keyboard.pot @@ -8,7 +8,7 @@ msgid "" msgstr "" "Project-Id-Version: PACKAGE VERSION\n" "Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: 2013-07-18 18:00-0400\n" +"POT-Creation-Date: 2013-08-07 10:44-0400\n" "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n" "Last-Translator: FULL NAME \n" "Language-Team: LANGUAGE \n" @@ -17,14 +17,14 @@ msgstr "" "Content-Type: text/plain; charset=CHARSET\n" "Content-Transfer-Encoding: 8bit\n" -#: ../lib/main.c:2297 ../lib/main.vala:532 +#: ../lib/main.c:2314 ../lib/main.vala:550 msgid "Character Map" msgstr "" -#: ../lib/main.c:2299 ../lib/main.vala:533 +#: ../lib/main.c:2316 ../lib/main.vala:551 msgid "Keyboard Layout Chart" msgstr "" -#: ../lib/main.c:2301 ../lib/main.vala:534 +#: ../lib/main.c:2318 ../lib/main.vala:552 msgid "Text Entry Settings..." msgstr "" diff --git a/tests/main.vala b/tests/main.vala index a26eca55..09d612f1 100644 --- a/tests/main.vala +++ b/tests/main.vala @@ -150,18 +150,12 @@ static void test_activate_input_source (void *data) { var action_group = DBusActionGroup.get ((!) fixture.connection, "com.canonical.indicator.keyboard", "/com/canonical/indicator/keyboard"); - var loop = new MainLoop (null, false); - var signal_name = action_group.action_state_changed["current"].connect ((action, state) => { - loop.quit (); - }); - action_group.list_actions (); action_group.activate_action ("current", new Variant.uint32 (2)); - var source = Timeout.add_seconds (TIMEOUT_S, () => { loop.quit (); return false; }); + var loop = new MainLoop (null, false); + Timeout.add_seconds (TIMEOUT_S, () => { loop.quit (); return false; }); loop.run (); - Source.remove (source); - action_group.disconnect (signal_name); var state = action_group.get_action_state ("current"); var current = state.get_uint32 (); -- cgit v1.2.3 From 170596ad221d7ea1701d2a2215ff912bddbecdfa Mon Sep 17 00:00:00 2001 From: William Hua Date: Thu, 8 Aug 2013 14:23:13 -0400 Subject: Fix a couple more potential races. --- po/indicator-keyboard.pot | 2 +- tests/main.vala | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/po/indicator-keyboard.pot b/po/indicator-keyboard.pot index 4433c98f..88197c24 100644 --- a/po/indicator-keyboard.pot +++ b/po/indicator-keyboard.pot @@ -8,7 +8,7 @@ msgid "" msgstr "" "Project-Id-Version: PACKAGE VERSION\n" "Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: 2013-08-07 10:44-0400\n" +"POT-Creation-Date: 2013-08-08 14:22-0400\n" "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n" "Last-Translator: FULL NAME \n" "Language-Team: LANGUAGE \n" diff --git a/tests/main.vala b/tests/main.vala index 09d612f1..c3997520 100644 --- a/tests/main.vala +++ b/tests/main.vala @@ -319,6 +319,10 @@ static void test_migration (void *data) { return; } + var loop = new MainLoop (null, false); + Timeout.add_seconds (TIMEOUT_S, () => { loop.quit (); return false; }); + loop.run (); + try { string sources; Process.spawn_command_line_sync ("gsettings get org.gnome.desktop.input-sources sources", out sources); @@ -381,6 +385,10 @@ static void test_no_migration (void *data) { return; } + var loop = new MainLoop (null, false); + Timeout.add_seconds (TIMEOUT_S, () => { loop.quit (); return false; }); + loop.run (); + try { string sources; Process.spawn_command_line_sync ("gsettings get org.gnome.desktop.input-sources sources", out sources); -- cgit v1.2.3 From 4f411bb4a5a7350ba3142c885e52383914c24a7a Mon Sep 17 00:00:00 2001 From: William Hua Date: Thu, 8 Aug 2013 14:41:27 -0400 Subject: Switch to serial test harness. --- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 31640e6b..79c96c15 100644 --- a/configure.ac +++ b/configure.ac @@ -7,7 +7,7 @@ AC_CONFIG_SRCDIR([configure.ac]) AC_CONFIG_AUX_DIR([build-aux]) AC_CONFIG_MACRO_DIR([m4]) -AM_INIT_AUTOMAKE([1.11 foreign -Wall -Woverride -Wno-portability]) +AM_INIT_AUTOMAKE([1.11 foreign serial-tests -Wall -Woverride -Wno-portability]) AM_SILENT_RULES([yes]) LT_INIT -- cgit v1.2.3 From 5c12e10be77351e88b6c550894e4ca34c99aacf8 Mon Sep 17 00:00:00 2001 From: William Hua Date: Mon, 12 Aug 2013 09:33:27 +0800 Subject: Fix out-of-bounds error. --- lib/main.vala | 8 +++++++- po/indicator-keyboard.pot | 8 ++++---- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/lib/main.vala b/lib/main.vala index 91466f8c..d601f6f9 100644 --- a/lib/main.vala +++ b/lib/main.vala @@ -220,8 +220,14 @@ public class Indicator.Keyboard.Service : Object { private void update_indicator_action () { var visible = indicator_settings.get_boolean ("visible"); var current = source_settings.get_uint ("current"); - var icon = get_sources ()[current].icon; + var sources = get_sources (); + Variant state; + Icon? icon = null; + + if (current < sources.length) { + icon = sources[current].icon; + } if (icon != null) { state = new Variant.parsed ("{ 'visible' : <%b>, 'icon' : %v }", visible, ((!) icon).serialize ()); diff --git a/po/indicator-keyboard.pot b/po/indicator-keyboard.pot index db38e8ef..b5d5cfca 100644 --- a/po/indicator-keyboard.pot +++ b/po/indicator-keyboard.pot @@ -8,7 +8,7 @@ msgid "" msgstr "" "Project-Id-Version: PACKAGE VERSION\n" "Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: 2013-08-08 14:52-0400\n" +"POT-Creation-Date: 2013-08-12 09:33+0800\n" "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n" "Last-Translator: FULL NAME \n" "Language-Team: LANGUAGE \n" @@ -17,14 +17,14 @@ msgstr "" "Content-Type: text/plain; charset=CHARSET\n" "Content-Transfer-Encoding: 8bit\n" -#: ../lib/main.c:1405 ../lib/main.vala:322 +#: ../lib/main.c:1419 ../lib/main.vala:328 msgid "Character Map" msgstr "" -#: ../lib/main.c:1407 ../lib/main.vala:323 +#: ../lib/main.c:1421 ../lib/main.vala:329 msgid "Keyboard Layout Chart" msgstr "" -#: ../lib/main.c:1409 ../lib/main.vala:324 +#: ../lib/main.c:1423 ../lib/main.vala:330 msgid "Text Entry Settings..." msgstr "" -- cgit v1.2.3