aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* libmessaging-menu: don't crash when getting an invalid desktop idLars Uebernickel2012-10-011-3/+14
| | | | | | Instead, silently don't export menus and actions. The single warning about the desktop id being invalid should be enough.
* Merge lp:~larsu/indicator-messages/lp1055966Lars Uebernickel2012-09-261-3/+2
|\ | | | | | | | | Request GTK_ICON_SIZE_LARGE_TOOLBAR icons for the indicator.
| * Request LARGE_TOOLBAR icons for the panelLars Uebernickel2012-09-251-3/+2
|/ | | | | To make it consistent with the other indicators.
* 12.10.3Lars Uebernickel2012-09-192-1/+12
|
* Bump required gtk version to 3.5.18Lars Uebernickel2012-09-191-1/+1
|
* Merge lp:~larsu/indicator-messages/fix-set-statusLars Uebernickel2012-09-197-76/+278
|\
| * messages-service: define all global variables as staticLars Uebernickel2012-09-191-3/+3
| |
| * Use indicator-message icons with chat statusLars Uebernickel2012-09-182-30/+109
| | | | | | | | | | | | | | | | | | | | Changes the state of the "messages" action from a boolean (draws-attention) to a string (icon-name). This has the added benefit that more logic is moved from the plugin into the service. It also fixes an edge case: the messaging menu didn't have the blue icon after the service restarted (if anything was drawing attention).
| * Set the global chat status more intelligentlyLars Uebernickel2012-09-186-47/+168
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Up until now, the global chat status was set every time an application called _set_status. Thus, global status really meant "status of the app that last changed the status". Now, the service remembers the chat status for each application and sets the global status as a combination of all of application statuses. If applications have different statuses, the menu items are shown in an inconsistent state. This is implemented in IdoMenuItem by making it accept state as an array of strings in addition to a single string. It is drawn inconsistent if the state contains the menu item's target value in addition to other values. When the global status is changed through the messaging menu, the service doesn't update the action immediately anymore. Instead, it notifies all applications about the change via the "status-changed" signal. Applications must call _set_state to acknowledge that they have indeed changed their state. This is consistent with libmessaging-menu's documentation and design. Also, the SetStatus D-Bus call was missing a "desktop-id" parameter to tell the menu which application changed status. Changing this doesn't break existing apps, as the D-Bus interface is considered private to indicator-messages.
| * libmessaging-menu: don't set app->status when global status changesLars Uebernickel2012-09-181-2/+1
| | | | | | | | | | | | | | | | | | The application's status only changes when it calls _set_status, so it's wrong to set the internal status when the global status changes. This shouldn't be a problem in practice, as app->status is not accessible from the API.
| * libmessaging-menu: don't call SetStatus(OFFLINE) for all appsLars Uebernickel2012-09-181-2/+5
|/ | | | | | | | Only notify the service about status if the application has actually called messaging_menu_app_set_status. This saves a d-bus call per non-chat application and - more importantly - doesn't make the messaging menu go into "unknown status" mode when one application is reporting 'online' status.
* Merge lp:~larsu/indicator-messages/show-separatorsLars Uebernickel2012-09-183-20/+11
|\
| * messages-services: don't call g_object_unref with NULLLars Uebernickel2012-09-141-1/+2
| |
| * Show menu separators between sectionsLars Uebernickel2012-09-132-19/+9
|/ | | | | | | | | | | | | Previously, gtk didn't support changing the menu model on an already-created GtkMenu. Since IndicatorObject doesn't allow changing the GtkMenu it exports to the panel, IndicatorMessages created a menu with a single section, into which the menu from the service was inserted (and removed when the service died). This led to seperators not being shown, because separators are only shown between top-level sections. Gtk now has gtk_menu_shell_bind_model, which allows us to get rid of top-level wrapper section.
* messages-service: update chat section when an app is removedLars Uebernickel2012-09-061-3/+11
|
* messages-service: fix merge errorLars Uebernickel2012-09-061-7/+5
| | | | | | | Check whether no apps are left in remove_section instead of remove_application, so that it is also done when an AppSection emits "destroy". This is a result of improper merging of the watch-desktop-files and hide-indicator branches.
* Merge lp:~larsu/indicator-messages/watch-desktop-filesLars Uebernickel2012-09-063-48/+128
|\
| * messages-service.c: remove redundant g_hash_table_removeLars Uebernickel2012-09-051-1/+0
| |
| * app-section.c: remove unused function app_section_get_nameLars Uebernickel2012-09-052-12/+0
| |
| * app-section.c: make destroy_signal staticLars Uebernickel2012-09-051-1/+1
| |
| * app-section: remove unused private memberLars Uebernickel2012-09-052-11/+0
| |
| * Watch desktop files for changesLars Uebernickel2012-09-052-26/+129
| | | | | | | | | | | | | | | | This introduces a slightly clumsy "destroy" signal for AppSection to notify outsiders that the desktop file was deleted. This will do for now, but a larger refactoring which pulls all the desktop-file-reading code out of appsection is in order.
* | Hide the indicator when no application is configured to use it.. Fixes: ↵Lars Uebernickel2012-09-052-54/+71
|\ \ | |/ |/| | | https://bugs.launchpad.net/bugs/661059, https://bugs.launchpad.net/bugs/1045039. Approved by jenkins, Charles Kerr.
| * indicator-messages.c: don't call menu_items_changed directlyLars Uebernickel2012-09-051-31/+38
| |
| * Hide indicator when no applications are configured to use itLars Uebernickel2012-09-042-64/+74
| | | | | | | | | | | | This is done by removing the header item from the menu model in the service. On the panel side, call indicator_object_hide() if the recevied menu is empty.
* | Some minor enhancements to the in-source documentation.. Approved by ↵Lars Uebernickel2012-09-041-10/+15
|\ \ | | | | | | | | | jenkins, Charles Kerr.
| * | libmessaging-menu: fix shortcut action documentationLars Uebernickel2012-09-041-4/+5
| | |
| * | libmessaging-menu: add convenience docLars Uebernickel2012-09-021-3/+6
| | | | | | | | | | | | | | | | | | | | | The most common case when inserting a timed source is to insert a source with the current time. Emphasize this in the documentation by linking to the convenience methods from the _with_time variants.
| * | libmessaging-menu: document that @time is expressed in microsecondsLars Uebernickel2012-09-021-3/+3
| | |
| * | libmessaging-menu: add @include hint to documentationLars Uebernickel2012-09-021-0/+1
| | |
* | | Draw counts as lozenges again.Lars Uebernickel2012-09-044-59/+481
|\ \ \ | |_|/ |/| | | | | Introduces IdoDetailLabel, a GtkWidget that renders detail strings (e.g. as lozenges) on the right side of a menu item.. Approved by Charles Kerr.
| * | ido-detail-label: factor common code out of set_text and _countLars Uebernickel2012-09-041-25/+25
| | | | | | | | | | | | | | | | | | | | | | | | This was only half-heartedly done with the _clear function, which left a dangling pointer. Contributed by Charles Kerr. Thanks!
| * | ido-detail-label: chain up dispose and finalize callsLars Uebernickel2012-09-041-0/+4
| | |
| * | im-source-menu-item: ellipsize label when it's longer than 40 emLars Uebernickel2012-09-031-0/+3
| | | | | | | | | | | | | | | Also make sure that the label is left-aligned when ellipsized.
| * | im-source-menu-item: draw lozenges around countsLars Uebernickel2012-09-034-74/+458
| | | | | | | | | | | | | | | | | | A new widget class IdoDetailLabel is introduced, which can display either a string or a count. Counts are drawn as lozenges.
| * | im-source-menu-item: refactor setting detail stringLars Uebernickel2012-09-031-15/+46
| |/
* / Update bzrignoreLars Uebernickel2012-09-031-9/+24
|/
* libmessaging-menu: make generated .gir compatible with valaLars Uebernickel2012-09-011-0/+2
| | | | | | | | In particular, mamke sure the <c:namespace> and <package> tags are included in the .gir. Fixes launchpad bug #1044096, thanks Jim!
* 12.10.2Lars Uebernickel2012-08-312-3/+11
|
* libmessaging-menu: allow using multiple MessagingMenuAppsLars Uebernickel2012-08-311-48/+73
| | | | | | | The dbus path was set to /com/canonical/indicator/messages for all MessagingMenuApps that a process created. This patch adds the desktop id into the path.
* libmessaging-menu: allow changing label and icon of sourcesLars Uebernickel2012-08-312-0/+109
|
* libmessaging-menu: make real links out of urls in the documentationLars Uebernickel2012-08-291-7/+7
|
* Fix gtk-doc warningsLars Uebernickel2012-08-292-1/+6
|
* Add gtk-doc supportLars Uebernickel2012-08-297-5/+73
|
* libmessaging-menu: add documentationLars Uebernickel2012-08-292-12/+125
| | | | | | Adds an overview description of the messaging menu and documentation for enums, properties, and signals.
* 12.10.1Lars Uebernickel2012-08-272-1/+10
|
* Merge lp:~larsu/messaging-menu/fix-iconsLars Uebernickel2012-08-2719-21/+495
|\
| * ido_menu_item_set_menu_item: make sure g_free isn't called with dangling pointerLars Uebernickel2012-08-271-1/+1
| |
| * IdoMenuItem: clear target pointer in disposeLars Uebernickel2012-08-271-1/+4
| |
| * Increase spacing between icons and labelsLars Uebernickel2012-08-273-1/+3
| |