| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
| |
This is a temporary hack to work around a crash in QMenuModel.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes the case when app->proxy is still NULL but another application with
the same desktop file replaces it. This should never happen in practice, but
turned up while testing multiple processes which used the same desktop file.
Their proxy_create async functions raced each other because the first one's
wasn't properly cancelled.
Also fixes a small memory leak.
|
|
|
|
|
|
|
|
| |
Also, don't print a warning when the proy couldn't be created because the
operation was cancelled. This only happens when the service is shutting down
or when one application replaces another one with the same desktop file (in
which case we already warn with a more descriptive message).
|
| |
|
|
|
|
|
| |
Always use messageitem instead.
|
| |
|
|\
| |
| |
| | |
Approved by Renato Araujo Oliveira Filho.
|
| | |
|
| | |
|
|/ |
|
|
|
|
|
| |
They are not set in every code path but freed at the end of the function.
|
|
|
|
|
|
|
|
| |
This is implemented by appending '-symbolic' to the first icon name. The old
icon name is kept as a fallback in case there's no symbolic icon installed.
This doesn't work yet for applications that specify their icon as a filename.
|
|\
| |
| |
| |
| |
| |
| | |
Newest messages should show up on top. The menu is still sorted by the time
messages were added, not by the time property of MessagingMenuMessage.
Approved by Olivier Tilloy.
|
| |
| |
| |
| |
| |
| | |
Newest messages should show up on top. The menu is still sorted by the time
messages were added, not by the time property of MessagingMenuMessage.
|
|\ \
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This doesn't require every consumer ("panel") to know about
IndicatorServiceManager's protocol.
Also, it ensures that objects are exported before the name is acquired, getting
rid of a race condition (when a consumer tries to access objects in
NameAppeared before they're exported).
This patch also adds a --replace command line option -- replacing the
INDICATOR_SERVICE_REPLACE_MODE environment variable.
. Fixes: https://bugs.launchpad.net/bugs/1085206.
Approved by Renato Araujo Oliveira Filho, PS Jenkins bot.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This doesn't require every consumer ("panel") to know about
IndicatorServiceManager's protocol.
Also, it ensures that objects are exported before the name is acquired, getting
rid of a race condition (when a consumer tries to access objects in
NameAppeared before they're exported).
This patch also adds a --replace command line option -- replacing the
INDICATOR_SERVICE_REPLACE_MODE environment variable.
|
| | |
|
|\| |
|
| |
| |
| |
| |
| |
| | |
This fixes a crash on arm, because g_signal_emit was called with one argument
too many.
|
| | |
|
| |
| |
| |
| |
| |
| | |
It isn't used right now (the action group wasn't even exported on the bus) and
would need to be refactored anyway once chat status is added back in.
|
| |
| |
| |
| |
| |
| |
| | |
The action for that root item lives in ImApplicationList for now, because it
owns the action group (which should probably factored into its own class at
some point).
|
| | |
|
| |
| |
| |
| |
| |
| | |
And use com.canonical.indicator.messages.snapdecision as widget type if the
message has actions.
|
| | |
|
| | |
|
|/ |
|
|
|
|
|
|
| |
Right now, this is only used to clean up internal data structures in
libmessaging-menu. It's not exposed to the application itself.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
| |
The application will only be notified about the activation when this parameter
is true. False denotes a dismissed item.
|
| |
|
|
|
|
|
|
|
|
|
|
| |
Remove trailing '.desktop' and replace all dots by underscores to make
GActionMuxer work (which uses the dot as a separator).
In order to contain the canonicalization to ImApplicationList, its signals now
contain string parameters to id and icon name instead of GDesktopAppInfo
pointers.
|
| |
|
| |
|
|
|
|
|
| |
Thanks Olivier!
|
|
|
|
|
| |
This data can (and should) always be retrieved via actions.
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
Add ImApplicationList, a class that manages the list of applictions that are
currently registered with the messaging menu. It creates dbus proxies for
running applications and sends signals when the app adds messages or sources.
|
| |
|
| |
|
|
|
|
|
|
|
|
| |
This is a rough first draft: It only fetched the sources and messages from
applications once and doesn't listen for further changes.
This removes all code for the desktop menu for now.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Previously, the protocol was simply a menu model and an action group of the
currently active sources. The service inserted the menu as a section into the
indicator menu.
This doesn't work anymore, because applications can (soon) expose individual
messages, and the messaging menu doesn't always display all of those at once.
This patch introduces a more specific d-bus API.
That API is still considered private: applications have to use
libmessaging-menu.
|