From f541df4bd1d88602d10566af519c5aeceb3de0b7 Mon Sep 17 00:00:00 2001 From: Lars Uebernickel Date: Wed, 20 Nov 2013 17:04:35 +0100 Subject: g_action_muxer_insert: don't warn when passing a NULL action group This is legitimate use of the API. --- src/gactionmuxer.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gactionmuxer.c b/src/gactionmuxer.c index 0f3cda4..1aae9fb 100644 --- a/src/gactionmuxer.c +++ b/src/gactionmuxer.c @@ -429,10 +429,13 @@ g_action_muxer_insert (GActionMuxer *muxer, gchar **action; g_return_if_fail (G_IS_ACTION_MUXER (muxer)); - g_return_if_fail (G_IS_ACTION_GROUP (group)); + g_return_if_fail (group == NULL || G_IS_ACTION_GROUP (group)); g_action_muxer_remove (muxer, prefix); + if (group == NULL) + return; + if (prefix) { prefix_copy = g_strdup (prefix); -- cgit v1.2.3 From 0daa47af4401f10c58016437ab05d5cc57a2f50d Mon Sep 17 00:00:00 2001 From: Lars Uebernickel Date: Wed, 20 Nov 2013 17:05:22 +0100 Subject: test-gactionmuxer: don't spew warnings that are expected --- test/test-gactionmuxer.cpp | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/test/test-gactionmuxer.cpp b/test/test-gactionmuxer.cpp index 78e808f..5c98c90 100644 --- a/test/test-gactionmuxer.cpp +++ b/test/test-gactionmuxer.cpp @@ -46,17 +46,34 @@ TEST(GActionMuxerTest, Sanity) { g_type_init (); #endif + g_test_expect_message ("Indicator-Messages", G_LOG_LEVEL_CRITICAL, "*G_IS_ACTION_MUXER*"); g_action_muxer_insert (NULL, NULL, NULL); + g_test_assert_expected_messages (); + + g_test_expect_message ("Indicator-Messages", G_LOG_LEVEL_CRITICAL, "*G_IS_ACTION_MUXER*"); g_action_muxer_remove (NULL, NULL); + g_test_assert_expected_messages (); muxer = g_action_muxer_new (); g_action_muxer_insert (muxer, NULL, NULL); g_action_muxer_remove (muxer, NULL); + + g_test_expect_message ("Indicator-Messages", G_LOG_LEVEL_CRITICAL, "*NULL*"); EXPECT_FALSE (g_action_group_has_action (G_ACTION_GROUP (muxer), NULL)); + g_test_assert_expected_messages (); + + g_test_expect_message ("Indicator-Messages", G_LOG_LEVEL_CRITICAL, "*NULL*"); EXPECT_FALSE (g_action_group_get_action_enabled (G_ACTION_GROUP (muxer), NULL)); + g_test_assert_expected_messages (); + + g_test_expect_message ("Indicator-Messages", G_LOG_LEVEL_CRITICAL, "*NULL*"); EXPECT_FALSE (g_action_group_query_action (G_ACTION_GROUP (muxer), NULL, NULL, NULL, NULL, NULL, NULL)); + g_test_assert_expected_messages (); + + g_test_expect_message ("GLib-GIO", G_LOG_LEVEL_CRITICAL, "*NULL*"); g_action_group_activate_action (G_ACTION_GROUP (muxer), NULL, NULL); + g_test_assert_expected_messages (); g_object_unref (muxer); } -- cgit v1.2.3