From d79f11b267f7aebf3d306f7cf7a980a4070881a7 Mon Sep 17 00:00:00 2001 From: Lars Uebernickel Date: Sat, 25 Aug 2012 16:11:41 +0200 Subject: Fix a memory leak and potential crash: ref_sink the widget, not the GMenu --- src/indicator-messages.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/indicator-messages.c b/src/indicator-messages.c index b3166f5..f211ff8 100644 --- a/src/indicator-messages.c +++ b/src/indicator-messages.c @@ -118,8 +118,9 @@ indicator_messages_init (IndicatorMessages *self) g_signal_connect (self->service, "connection-change", G_CALLBACK (service_connection_changed), self); - self->menu_wrapper = g_object_ref_sink (g_menu_new ()); + self->menu_wrapper = g_menu_new (); self->gtkmenu = gtk_menu_new_from_model (G_MENU_MODEL (self->menu_wrapper)); + g_object_ref_sink (self->gtkmenu); self->image = g_object_ref_sink (gtk_image_new ()); -- cgit v1.2.3