From ec879e19cd2e24a521ce7fde416807e6da9a26bb Mon Sep 17 00:00:00 2001 From: Lars Uebernickel Date: Wed, 28 Aug 2013 12:42:08 +0200 Subject: Don't pass ids as detailed action names Detailed action names are of the form action::target or action(target), so they can't have colons or parens in them. This restriction does not apply to messaging menu ids. Fixes: https://bugs.launchpad.net/bugs/1180302. --- src/im-phone-menu.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src/im-phone-menu.c') diff --git a/src/im-phone-menu.c b/src/im-phone-menu.c index 0ea6f76..a9c5977 100644 --- a/src/im-phone-menu.c +++ b/src/im-phone-menu.c @@ -170,7 +170,8 @@ im_phone_menu_add_message (ImPhoneMenu *menu, action_name = g_strconcat (app_id, ".msg.", id, NULL); - item = g_menu_item_new (title, action_name); + item = g_menu_item_new (title, NULL); + g_menu_item_set_action_and_target_value (item, action_name, NULL); g_menu_item_set_attribute (item, "x-canonical-type", "s", "com.canonical.indicator.messages.messageitem"); g_menu_item_set_attribute (item, "x-canonical-message-id", "s", id); @@ -232,7 +233,8 @@ im_phone_menu_add_source (ImPhoneMenu *menu, action_name = g_strconcat (app_id, ".src.", id, NULL); - item = g_menu_item_new (label, action_name); + item = g_menu_item_new (label, NULL); + g_menu_item_set_action_and_target_value (item, action_name, NULL); g_menu_item_set_attribute (item, "x-canonical-type", "s", "com.canonical.indicator.messages.sourceitem"); if (iconstr) -- cgit v1.2.3