From 1f621cbbbfe9bc65f4fbce2ff2bb57ef8badad82 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Tue, 21 Aug 2012 00:52:58 -0500 Subject: in app-section.c's dispose(), clear the muxer object --- src/app-section.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src') diff --git a/src/app-section.c b/src/app-section.c index 1602ac6..4cccb6c 100644 --- a/src/app-section.c +++ b/src/app-section.c @@ -233,6 +233,8 @@ app_section_dispose (GObject *object) g_clear_object (&priv->source_actions); } + g_clear_object (&priv->muxer); + g_clear_object (&priv->source_menu); g_clear_object (&priv->ids); g_clear_object (&priv->appinfo); -- cgit v1.2.3 From 19f5fdbb523167af107267c2bb28a810b5a548a2 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Tue, 21 Aug 2012 00:54:03 -0500 Subject: in app-section's app_section_set_app_info(), don't leak the nicks' actions --- src/app-section.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src') diff --git a/src/app-section.c b/src/app-section.c index 4cccb6c..fcb75d9 100644 --- a/src/app-section.c +++ b/src/app-section.c @@ -352,6 +352,7 @@ app_section_set_app_info (AppSection *self, action = g_simple_action_new (nicks[i], NULL); g_signal_connect(action, "activate", G_CALLBACK (nick_activate_cb), self); g_simple_action_group_insert (priv->static_shortcuts, G_ACTION (action)); + g_object_unref (action); g_menu_append (priv->menu, name, nicks[i]); -- cgit v1.2.3 From 2f2630580f5e473f0748fcedd52164c350285a00 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Tue, 21 Aug 2012 00:55:26 -0500 Subject: in app-section.c's activate_cb(), don't leak the GError if we can't launch --- src/app-section.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/app-section.c b/src/app-section.c index fcb75d9..f922dca 100644 --- a/src/app-section.c +++ b/src/app-section.c @@ -387,8 +387,10 @@ activate_cb (GSimpleAction *action, GError *error = NULL; if (!g_app_info_launch (G_APP_INFO (priv->appinfo), NULL, NULL, &error)) { - g_warning("Unable to execute application for desktop file '%s'", - g_desktop_app_info_get_filename (priv->appinfo)); + g_warning("Unable to execute application for desktop file '%s': %s", + g_desktop_app_info_get_filename (priv->appinfo), + error->message); + g_error_free (error); } } -- cgit v1.2.3