From 5bc25125ca5581ce9910007af68ee1c53b995d81 Mon Sep 17 00:00:00 2001 From: Ted Gould Date: Thu, 1 Oct 2009 16:33:00 -0500 Subject: Stupid ordering, just asking for a memory leak. --- src/indicator-messages.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/indicator-messages.c b/src/indicator-messages.c index 0d0e294..e7d6207 100644 --- a/src/indicator-messages.c +++ b/src/indicator-messages.c @@ -202,12 +202,12 @@ indicator_prop_change_cb (DbusmenuMenuitem * mi, gchar * prop, gchar * value, in static gboolean new_indicator_item (DbusmenuMenuitem * newitem, DbusmenuMenuitem * parent, DbusmenuClient * client) { - indicator_item_t * mi_data = g_new0(indicator_item_t, 1); - g_return_val_if_fail(DBUSMENU_IS_MENUITEM(newitem), FALSE); g_return_val_if_fail(DBUSMENU_IS_GTKCLIENT(client), FALSE); /* Note: not checking parent, it's reasonable for it to be NULL */ + indicator_item_t * mi_data = g_new0(indicator_item_t, 1); + GtkMenuItem * gmi = GTK_MENU_ITEM(gtk_menu_item_new()); GtkWidget * hbox = gtk_hbox_new(FALSE, 4); -- cgit v1.2.3 From 735d17b40b609584d9a99c113c5848c0e5f759e4 Mon Sep 17 00:00:00 2001 From: Ted Gould Date: Sun, 4 Oct 2009 15:30:48 -0500 Subject: Resort the menu after the blacklist has been checked case we've black listed the last item in the menu. --- src/messages-service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/messages-service.c b/src/messages-service.c index 754d7ee..f5681b7 100644 --- a/src/messages-service.c +++ b/src/messages-service.c @@ -1147,7 +1147,6 @@ build_launcher (gpointer data) /* Add it to the menu */ dbusmenu_menuitem_child_append(root_menuitem, DBUSMENU_MENUITEM(ll->menuitem)); dbusmenu_menuitem_child_append(root_menuitem, DBUSMENU_MENUITEM(ll->separator)); - resort_menu(root_menuitem); /* If we're in the black list or we've gotten eclipsed by something else, hide the item and the separator. */ @@ -1157,6 +1156,7 @@ build_launcher (gpointer data) dbusmenu_menuitem_property_set(ll->separator, DBUSMENU_MENUITEM_PROP_VISIBLE, "false"); } + resort_menu(root_menuitem); check_hidden(); } else { /* If so add ourselves */ -- cgit v1.2.3