aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* reuse the same cancellable across multiple non-concurrent dbus callsCharles Kerr2012-05-261-18/+18
|
* avoid a cyclical refcount dependency between IndicatorPower and its DBusListenerCharles Kerr2012-05-261-3/+17
|
* extract-method to simplify testing the accessible textCharles Kerr2012-05-261-47/+45
|
* separate the dbus org.gnome.SettingsDaemon.Power logic into a separate classCharles Kerr2012-05-264-147/+366
|
* add coverage for various charging/discharging/charged statesCharles Kerr2012-05-261-3/+101
|
* first draft of adding tests for a discharging batteryCharles Kerr2012-05-261-0/+35
|
* make indicator_power_set_devices() safe for passing in the same devices more ↵Charles Kerr2012-05-251-12/+14
| | | | than once
* fix negated logic in menu_add_device() introduced in r160Charles Kerr2012-05-251-1/+1
|
* indicator_power_set_devices() should fail gracefully when no devices are ↵Charles Kerr2012-05-251-2/+5
| | | | available
* make Jenkins happyCharles Kerr2012-05-251-2/+2
|
* modify IndicatorPower to use IndicatorPowerDevices internallyCharles Kerr2012-05-253-188/+193
|
* put IndicatorPower's fields back inside a priv structCharles Kerr2012-05-252-74/+99
|
* ah, c++ is too smart for the last commit's implicit conversion.Charles Kerr2012-05-241-1/+1
|
* test passing bad non-NULL pointers to Device's accessorsCharles Kerr2012-05-241-6/+16
|
* add unit tests confirming that the device accessor functions won't crash ↵Charles Kerr2012-05-241-0/+14
| | | | when you pass NULL for the device
* remove the 'default' clause from get_property() and set_property().Charles Kerr2012-05-241-8/+0
| | | | | Coverage testing isn't reaching them... glib is weeding out these invalid property keys before the device.c functions are ever reached. Nevertheless, leaving out a 'default' clause in a switch statement feels very unnatural to me. *twitch* *twitch*
* remove some unnecessary type compatibilty tests... g_object_get_property() ↵Charles Kerr2012-05-241-6/+0
| | | | does these tests for us
* remove the tests that attempted to exercise the code removed in r151Charles Kerr2012-05-241-33/+2
|
* don't include the unit tests' code in coverage metricsCharles Kerr2012-05-241-3/+2
|
* remove some unnecessary type compatibilty tests... g_object_set_property() ↵Charles Kerr2012-05-241-6/+0
| | | | does these tests for us
* add unit tests for getting/setting device propertiesCharles Kerr2012-05-241-0/+90
|
* first draft of getting GSettings working in the unit tests before the schema ↵Charles Kerr2012-05-242-4/+33
| | | | is installed.
* remove the g_clear_pointer() calls s.t. things will build and run on ↵Charles Kerr2012-05-241-2/+6
| | | | alesage's Jenkins setup running Precise
* remove the g_clear_pointer() calls s.t. things will build and run on ↵Charles Kerr2012-05-242-5/+5
| | | | alesage's Jenkins setup running Precise
* add test-indicator.ccCharles Kerr2012-05-241-0/+52
|
* add a 'hello world' test for instantiating IndicatorPowerCharles Kerr2012-05-243-52/+94
|
* add private container struct IndicatorPowerDeviceCharles Kerr2012-05-249-3/+706
|
* replace 'Power Settings...' with 'Power Settings…'Charles Kerr2012-05-231-1/+1
|
* move libpower's automake rules into src/Charles Kerr2012-05-233-27/+30
|
* fix a handful of string and GVariant leaks in indicator-power.Charles Kerr2012-04-261-39/+35
|\
| * tweak: in put_primary_device(), peek at the variant's strings instead of ↵Charles Kerr2012-04-151-5/+3
| | | | | | | | dup'ing them
| * sync with lp:indicator-powerCharles Kerr2012-04-155-49/+76
| |\ | |/ |/|
* | 2.02.0Charles Kerr2012-04-111-1/+1
| |
* | merge lp:~allanlesage/indicator-power/TDD to improve our gcov fules in autotoolsCharles Kerr2012-04-104-45/+65
|\ \
| * | Pedantic name change for gcovr xml results.Allan LeSage2012-03-271-2/+2
| | |
| * | Added gcov coverage tooling.Allan LeSage2012-03-274-45/+65
| | |
* | | use atk_object_set_name(foo,bar)" instead of ↵Charles Kerr2012-04-091-1/+1
| | | | | | | | | | | | g_object_set(foo,"accessible-name",bar,NULL)"
* | | leak fix 3 of 3: don't leak the GIcons returned by get_device_icon()Charles Kerr2012-04-091-0/+2
| | |
* | | leak fix 2 of 3: fix leaky fallback GIcon in get_device_icon()Charles Kerr2012-04-091-3/+4
| | |
* | | leak fix 1 of 3: don't leak object_path and device_icon if kind == ↵Charles Kerr2012-04-091-6/+4
| | | | | | | | | | | | UP_DEVICE_KIND_LINE_POWER
* | | if possible, set the device menuitems' accessible names.Charles Kerr2012-04-091-0/+4
| | |
* | | 1.931.93Charles Kerr2012-03-211-1/+1
| | |
| | * fix leaked strings in menu_add_device when (kind == UP_DEVICE_KIND_LINE_POWER)Charles Kerr2012-04-151-6/+4
| | |
| | * Fix memory leaks in get_primary_device().Charles Kerr2012-03-171-32/+28
| | | | | | | | | | | | | | | | | | | | | 1. All the calls to g_variant_get_child_value() were leaked. Fixed by changing the use to g_variant_get_child() and keeping index values of the interesting children instead of pointers to them. 2. There were several paths where the local string "object_path" and "device_icon" were leaked. (For example, any non-battery entry given to us by upower). Fixed by making these const strings and peeking them from the variant with "&s" instead of "s".
| | * Fix variant leak in count_batteries() -- the returned value of ↵Charles Kerr2012-03-171-0/+2
| | | | | | | | | | | | g_variant_get_child_value() needs to be freed with g_variant_unref() when we're done with it.
| | * fix variant leaks in menu_add_devices()Charles Kerr2012-03-171-2/+2
| |/ |/|
* | merge lp:~kelemeng/indicator-power/bug957542 to fix extracting translatable ↵Charles Kerr2012-03-171-1/+1
|\ \ | | | | | | | | | strings from ipower (Bug #957542)
| * | Add g_dngettext to the list of known keywords. LP: #957542Gabor Kelemen2012-03-171-1/+1
|/ /
* / 1.911.92Charles Kerr2012-03-141-1/+1
|/
* 1.911.91Ted Gould2012-02-231-1/+1
|