aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* use C++-style comments in test-device.ccCharles Kerr2012-06-011-32/+32
|
* In indicator_power_device_get_time_details(), add a test for non-devices ↵Charles Kerr2012-06-012-1/+22
| | | | being passed in.
* Fix edge case in indicator_power_device_get_icon_names() that returned a bad ↵Charles Kerr2012-06-012-1/+4
| | | | value if the caller passed in a NULL pointer as a device. Added regression test.
* In indicator_power_device_get_time_details(), use g_strdup(foo) instead of ↵Charles Kerr2012-06-011-2/+2
| | | | g_strdup_printf("%s",foo)
* Add coverage test for AC Adapters in indicator_power_device_get_time_details()Charles Kerr2012-06-011-0/+8
|
* capitalize the second word in 'AC Adapter'Charles Kerr2012-06-011-1/+1
|
* in indicator_power_device_get_time_details(), don't list 'not present' for ↵Charles Kerr2012-06-011-1/+8
| | | | AC Adapters that have no % and no time estimate
* Add unit tests for indicator_power_device_get_time_details()Charles Kerr2012-06-011-2/+87
|
* In indicator_power_device_get_time_details(), remove an unlikely branch that ↵Charles Kerr2012-06-011-42/+30
| | | | could result in time/detail strings not being set.
* Add gcda/gcno to CLEANFILES s.t. 'make clean' will cover themCharles Kerr2012-06-011-0/+3
|
* in indicator_power_device_get_time_details(), limit the scope of variables ↵Charles Kerr2012-05-311-3/+3
| | | | short_timestring and detailed_timestring
* Move private indicator-power function build_device_time_details() to ↵Charles Kerr2012-05-314-198/+205
| | | | device.c to public function indicator_power_device_get_time_details() so that we can unit test the user-visible strings.
* remove IndicatorPowerDevice's now-unused device icon string.Charles Kerr2012-05-314-154/+10
|
* Add indicator_power_device_get_icon_names().Charles Kerr2012-05-314-114/+451
| | | | | | | The main goal of this change is to make it possible to test the device's icon. A secondary goal is to clarify in the code how indicator-power's icons differ from the ones recommended by GSD.
* remove some g_message() calls that shouldn't've been committed.Charles Kerr2012-05-311-5/+0
|
* add a test to make sure that the listener responds to a PropertiesChanged signalCharles Kerr2012-05-292-0/+67
|
* t^Cak to indicator_set_power_differences()Charles Kerr2012-05-291-3/+2
|
* use g_clear_pointer() where usefulCharles Kerr2012-05-291-6/+2
|
* add tests for gsd GetDevices returning (a) no devices and (b) an errorCharles Kerr2012-05-291-130/+196
|
* exclude G_DEFINE_TYPE from coverage testing in dbus-listener.cCharles Kerr2012-05-291-0/+2
|
* add more tests to improve coverage: different device types, no primary deviceCharles Kerr2012-05-282-0/+62
|
* add a mock GSD.Power to handle the GetPower requestsCharles Kerr2012-05-283-9/+177
|
* use signals to decouple i-power and dbus-listenerCharles Kerr2012-05-275-134/+66
|
* Add skeleton test for IndicatorPowerDbusListenerCharles Kerr2012-05-272-0/+79
|
* add coverage for charging with >1 minute but <1 hour leftCharles Kerr2012-05-261-0/+9
|
* add coverage for DBusListener get_property()Charles Kerr2012-05-261-0/+17
|
* try adding LCOV_EXCL_{START,STOP} for unreachable conditions (glib looking ↵Charles Kerr2012-05-262-3/+23
| | | | for subclasses of IndicatorPowerDevice; unreachables in G_DEFINE_TYPE)
* call g_object_run_dispose() in a standalone test to get coverage on the NULL ↵Charles Kerr2012-05-262-0/+2
| | | | / non-NULL branches of dispose()'s g_clear_pointer() calls
* nope, LCOV_EXCL_LINE doesn't work on macrosCharles Kerr2012-05-261-7/+7
|
* try adding LCOV_EXCL_LINE for unreachable conditions (glib looking for ↵Charles Kerr2012-05-261-7/+7
| | | | subclasses of IndicatorPowerDevice; unreachables in G_DEFINE_TYPE)
* reuse the same cancellable across multiple non-concurrent dbus callsCharles Kerr2012-05-261-18/+18
|
* avoid a cyclical refcount dependency between IndicatorPower and its DBusListenerCharles Kerr2012-05-261-3/+17
|
* extract-method to simplify testing the accessible textCharles Kerr2012-05-261-47/+45
|
* separate the dbus org.gnome.SettingsDaemon.Power logic into a separate classCharles Kerr2012-05-264-147/+366
|
* add coverage for various charging/discharging/charged statesCharles Kerr2012-05-261-3/+101
|
* first draft of adding tests for a discharging batteryCharles Kerr2012-05-261-0/+35
|
* make indicator_power_set_devices() safe for passing in the same devices more ↵Charles Kerr2012-05-251-12/+14
| | | | than once
* fix negated logic in menu_add_device() introduced in r160Charles Kerr2012-05-251-1/+1
|
* indicator_power_set_devices() should fail gracefully when no devices are ↵Charles Kerr2012-05-251-2/+5
| | | | available
* make Jenkins happyCharles Kerr2012-05-251-2/+2
|
* modify IndicatorPower to use IndicatorPowerDevices internallyCharles Kerr2012-05-253-188/+193
|
* put IndicatorPower's fields back inside a priv structCharles Kerr2012-05-252-74/+99
|
* ah, c++ is too smart for the last commit's implicit conversion.Charles Kerr2012-05-241-1/+1
|
* test passing bad non-NULL pointers to Device's accessorsCharles Kerr2012-05-241-6/+16
|
* add unit tests confirming that the device accessor functions won't crash ↵Charles Kerr2012-05-241-0/+14
| | | | when you pass NULL for the device
* remove the 'default' clause from get_property() and set_property().Charles Kerr2012-05-241-8/+0
| | | | | Coverage testing isn't reaching them... glib is weeding out these invalid property keys before the device.c functions are ever reached. Nevertheless, leaving out a 'default' clause in a switch statement feels very unnatural to me. *twitch* *twitch*
* remove some unnecessary type compatibilty tests... g_object_get_property() ↵Charles Kerr2012-05-241-6/+0
| | | | does these tests for us
* remove the tests that attempted to exercise the code removed in r151Charles Kerr2012-05-241-33/+2
|
* don't include the unit tests' code in coverage metricsCharles Kerr2012-05-241-3/+2
|
* remove some unnecessary type compatibilty tests... g_object_set_property() ↵Charles Kerr2012-05-241-6/+0
| | | | does these tests for us
generated by cgit v1.2.3 (git 2.25.1) at 2024-11-04 19:40:40 +0000