aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* reimplement indicator_power_device_get_icon_names() since our CA is ↵Charles Kerr2012-06-062-93/+94
| | | | incompatible with reusing code from GSD.
* remove superfluous #includeCharles Kerr2012-06-061-2/+0
|
* simplify the Device properties' name stringsCharles Kerr2012-06-061-5/+5
|
* For GTK-Doc, reference functions with function_name() instead of #function_nameCharles Kerr2012-06-061-1/+1
|
* In indicator_power_device_new_from_variant(), check whether the input ↵Charles Kerr2012-06-061-0/+4
| | | | variant has the correct type before using it.
* add G_OBJECT_WARN_INVALID_PROPERTY_ID for the 'default' switch case in ↵Charles Kerr2012-06-061-0/+8
| | | | Device's get/set property methods
* IndicatorObjectDevice's finalize() function needs to chain up to the parent ↵Charles Kerr2012-06-061-0/+2
| | | | class.
* in IndicatorPowerDevice's class init function, use ↵Charles Kerr2012-06-061-26/+39
| | | | g_object_class_install_properties() instead of installing each property separately.
* remove prototype for indicator_power_dbus_listener_new() since it's not ↵Charles Kerr2012-06-061-3/+0
| | | | needed/used
* simplify the devices-enumerated signal's nameCharles Kerr2012-06-062-2/+2
|
* if self->cancellable is non-NULL in dispose(), pass it to ↵Charles Kerr2012-06-061-1/+6
| | | | g_cancellable_cancel() before clearing the listener's reference
* remove trailing whitespaceCharles Kerr2012-06-061-1/+1
|
* add g_bus_unwatch_name() to watcher's dispose() methodCharles Kerr2012-06-061-0/+6
|
* add a GTK-Doc signal comment block for indictor-power-dbus-listener's ↵Charles Kerr2012-06-061-2/+9
| | | | enumerated signal
* move the header files from noinst_HEADERS to libpower_la_SOURCESCharles Kerr2012-06-061-5/+3
|
* In indicator-power.c's put_primary_device(), remove dead code.Charles Kerr2012-06-011-15/+7
|
* copyediting: fix tab damage in dbus-listener.[ch]Charles Kerr2012-06-012-116/+114
|
* copyediting: fix tab damage in device.[ch]Charles Kerr2012-06-012-177/+179
|
* use C++-style comments in test-device.ccCharles Kerr2012-06-011-32/+32
|
* In indicator_power_device_get_time_details(), add a test for non-devices ↵Charles Kerr2012-06-012-1/+22
| | | | being passed in.
* Fix edge case in indicator_power_device_get_icon_names() that returned a bad ↵Charles Kerr2012-06-012-1/+4
| | | | value if the caller passed in a NULL pointer as a device. Added regression test.
* In indicator_power_device_get_time_details(), use g_strdup(foo) instead of ↵Charles Kerr2012-06-011-2/+2
| | | | g_strdup_printf("%s",foo)
* Add coverage test for AC Adapters in indicator_power_device_get_time_details()Charles Kerr2012-06-011-0/+8
|
* capitalize the second word in 'AC Adapter'Charles Kerr2012-06-011-1/+1
|
* in indicator_power_device_get_time_details(), don't list 'not present' for ↵Charles Kerr2012-06-011-1/+8
| | | | AC Adapters that have no % and no time estimate
* Add unit tests for indicator_power_device_get_time_details()Charles Kerr2012-06-011-2/+87
|
* In indicator_power_device_get_time_details(), remove an unlikely branch that ↵Charles Kerr2012-06-011-42/+30
| | | | could result in time/detail strings not being set.
* Add gcda/gcno to CLEANFILES s.t. 'make clean' will cover themCharles Kerr2012-06-011-0/+3
|
* in indicator_power_device_get_time_details(), limit the scope of variables ↵Charles Kerr2012-05-311-3/+3
| | | | short_timestring and detailed_timestring
* Move private indicator-power function build_device_time_details() to ↵Charles Kerr2012-05-314-198/+205
| | | | device.c to public function indicator_power_device_get_time_details() so that we can unit test the user-visible strings.
* remove IndicatorPowerDevice's now-unused device icon string.Charles Kerr2012-05-314-154/+10
|
* Add indicator_power_device_get_icon_names().Charles Kerr2012-05-314-114/+451
| | | | | | | The main goal of this change is to make it possible to test the device's icon. A secondary goal is to clarify in the code how indicator-power's icons differ from the ones recommended by GSD.
* remove some g_message() calls that shouldn't've been committed.Charles Kerr2012-05-311-5/+0
|
* add a test to make sure that the listener responds to a PropertiesChanged signalCharles Kerr2012-05-292-0/+67
|
* t^Cak to indicator_set_power_differences()Charles Kerr2012-05-291-3/+2
|
* use g_clear_pointer() where usefulCharles Kerr2012-05-291-6/+2
|
* add tests for gsd GetDevices returning (a) no devices and (b) an errorCharles Kerr2012-05-291-130/+196
|
* exclude G_DEFINE_TYPE from coverage testing in dbus-listener.cCharles Kerr2012-05-291-0/+2
|
* add more tests to improve coverage: different device types, no primary deviceCharles Kerr2012-05-282-0/+62
|
* add a mock GSD.Power to handle the GetPower requestsCharles Kerr2012-05-283-9/+177
|
* use signals to decouple i-power and dbus-listenerCharles Kerr2012-05-275-134/+66
|
* Add skeleton test for IndicatorPowerDbusListenerCharles Kerr2012-05-272-0/+79
|
* add coverage for charging with >1 minute but <1 hour leftCharles Kerr2012-05-261-0/+9
|
* add coverage for DBusListener get_property()Charles Kerr2012-05-261-0/+17
|
* try adding LCOV_EXCL_{START,STOP} for unreachable conditions (glib looking ↵Charles Kerr2012-05-262-3/+23
| | | | for subclasses of IndicatorPowerDevice; unreachables in G_DEFINE_TYPE)
* call g_object_run_dispose() in a standalone test to get coverage on the NULL ↵Charles Kerr2012-05-262-0/+2
| | | | / non-NULL branches of dispose()'s g_clear_pointer() calls
* nope, LCOV_EXCL_LINE doesn't work on macrosCharles Kerr2012-05-261-7/+7
|
* try adding LCOV_EXCL_LINE for unreachable conditions (glib looking for ↵Charles Kerr2012-05-261-7/+7
| | | | subclasses of IndicatorPowerDevice; unreachables in G_DEFINE_TYPE)
* reuse the same cancellable across multiple non-concurrent dbus callsCharles Kerr2012-05-261-18/+18
|
* avoid a cyclical refcount dependency between IndicatorPower and its DBusListenerCharles Kerr2012-05-261-3/+17
|