Commit message (Collapse) | Author | Age | Files | Lines | ||
---|---|---|---|---|---|---|
... | ||||||
* | In indicator_power_device_get_time_details(), remove an unlikely branch that ↵ | Charles Kerr | 2012-06-01 | 1 | -42/+30 | |
| | | | | could result in time/detail strings not being set. | |||||
* | in indicator_power_device_get_time_details(), limit the scope of variables ↵ | Charles Kerr | 2012-05-31 | 1 | -3/+3 | |
| | | | | short_timestring and detailed_timestring | |||||
* | Move private indicator-power function build_device_time_details() to ↵ | Charles Kerr | 2012-05-31 | 1 | -0/+195 | |
| | | | | device.c to public function indicator_power_device_get_time_details() so that we can unit test the user-visible strings. | |||||
* | remove IndicatorPowerDevice's now-unused device icon string. | Charles Kerr | 2012-05-31 | 1 | -126/+0 | |
| | ||||||
* | Add indicator_power_device_get_icon_names(). | Charles Kerr | 2012-05-31 | 1 | -1/+242 | |
| | | | | | | | The main goal of this change is to make it possible to test the device's icon. A secondary goal is to clarify in the code how indicator-power's icons differ from the ones recommended by GSD. | |||||
* | use g_clear_pointer() where useful | Charles Kerr | 2012-05-29 | 1 | -6/+2 | |
| | ||||||
* | try adding LCOV_EXCL_{START,STOP} for unreachable conditions (glib looking ↵ | Charles Kerr | 2012-05-26 | 1 | -3/+17 | |
| | | | | for subclasses of IndicatorPowerDevice; unreachables in G_DEFINE_TYPE) | |||||
* | nope, LCOV_EXCL_LINE doesn't work on macros | Charles Kerr | 2012-05-26 | 1 | -7/+7 | |
| | ||||||
* | try adding LCOV_EXCL_LINE for unreachable conditions (glib looking for ↵ | Charles Kerr | 2012-05-26 | 1 | -7/+7 | |
| | | | | subclasses of IndicatorPowerDevice; unreachables in G_DEFINE_TYPE) | |||||
* | remove the 'default' clause from get_property() and set_property(). | Charles Kerr | 2012-05-24 | 1 | -8/+0 | |
| | | | | | Coverage testing isn't reaching them... glib is weeding out these invalid property keys before the device.c functions are ever reached. Nevertheless, leaving out a 'default' clause in a switch statement feels very unnatural to me. *twitch* *twitch* | |||||
* | remove some unnecessary type compatibilty tests... g_object_get_property() ↵ | Charles Kerr | 2012-05-24 | 1 | -6/+0 | |
| | | | | does these tests for us | |||||
* | remove some unnecessary type compatibilty tests... g_object_set_property() ↵ | Charles Kerr | 2012-05-24 | 1 | -6/+0 | |
| | | | | does these tests for us | |||||
* | remove the g_clear_pointer() calls s.t. things will build and run on ↵ | Charles Kerr | 2012-05-24 | 1 | -2/+6 | |
| | | | | alesage's Jenkins setup running Precise | |||||
* | add private container struct IndicatorPowerDevice | Charles Kerr | 2012-05-24 | 1 | -0/+330 | |