aboutsummaryrefslogtreecommitdiff
path: root/src/device.c
Commit message (Collapse)AuthorAgeFilesLines
* prefer the 'battery-020-charging' icon to the 'battery-low-charging' one ↵Charles Kerr2014-05-051-1/+2
| | | | because the former is more precise so its icon is more likely to be close to the actual actual battery level.
* sync to lp:indicator-powerCharles Kerr2014-03-251-101/+68
|\
| * in the new indicator_power_device_get_*() functions, use ↵Charles Kerr2014-03-131-3/+5
| | | | | | | | g_return_val_if_fail(foo, NULL) rather than g_return_if_fail(foo)
| * copyediting: add const, fix misaligned whitespaceCharles Kerr2014-03-131-2/+2
| |
| * remove INDICATOR_IS_POWER_DEVICE(device) tests from private functionsCharles Kerr2014-03-131-10/+2
| |
| * in the new indicator_power_device_get_*() functions, use heap-allocated ↵Charles Kerr2014-03-131-87/+60
| | | | | | | | strings rather than relying on g_snprintf().
* | add translator comments to the new translatable strings.Charles Kerr2014-03-251-13/+40
|/
* slightly better commentsCharles Kerr2014-03-041-13/+12
|
* update the header / menuitem text / accessible text to reflect the changes ↵Charles Kerr2014-03-041-162/+312
| | | | in https://wiki.ubuntu.com/Power?action=diff&rev2=44&rev1=43#Title
* device.c: pending_charge means not chargingRicardo Salveti de Araujo2014-01-241-1/+1
|
* use the correct battery icon when charging/dischargingCharles Kerr2013-10-011-8/+1
|
* as per the changes in ↵Charles Kerr2013-08-231-2/+2
| | | | https://wiki.ubuntu.com/Power?action=diff&rev2=39&rev1=38, hide the discharge time remaining if it's > 24 hours
* copyediting: more descriptive comments when building label/header/a11y textCharles Kerr2013-08-231-11/+16
|
* copyediting: remove trailing spaces in source codeCharles Kerr2013-08-221-1/+1
|
* add show-percentage feature, basing off Haw Loeung's patch.Charles Kerr2013-08-221-57/+116
|
* explicitly use gio; remove unused glib-upower.h callsCharles Kerr2013-06-161-2/+23
|
* change indicator_power_device_get_time_details() s.t. the 'short details' ↵Charles Kerr2012-11-071-1/+1
| | | | for an AC Adapter is an empty string.
* fix copy-paste comment errorCharles Kerr2012-10-261-1/+1
|
* Fix unhandled enum 'unknown device' that was smoked out by the unit tests.Charles Kerr2012-10-261-0/+4
|
* the device kind string wasn't being used in some icon names.Charles Kerr2012-10-251-14/+14
|
* when discharging the battery, prefer the percent-charged icons over the ↵Charles Kerr2012-10-031-1/+2
| | | | full,good,low icons because the former show a more accurate view of the charge.
* device.c: include gi18n-lib.h instead of gi18n.hLars Uebernickel2012-09-201-1/+1
| | | | | | The former calls the 'd' variants of the gettext functions and passes the libraries domain in each call.
* improve the variant sanity tests in indicator_power_device_new_from_variant()Charles Kerr2012-06-071-3/+1
|
* reimplement indicator_power_device_get_icon_names() since our CA is ↵Charles Kerr2012-06-061-76/+77
| | | | incompatible with reusing code from GSD.
* For GTK-Doc, reference functions with function_name() instead of #function_nameCharles Kerr2012-06-061-1/+1
|
* In indicator_power_device_new_from_variant(), check whether the input ↵Charles Kerr2012-06-061-0/+4
| | | | variant has the correct type before using it.
* add G_OBJECT_WARN_INVALID_PROPERTY_ID for the 'default' switch case in ↵Charles Kerr2012-06-061-0/+8
| | | | Device's get/set property methods
* IndicatorObjectDevice's finalize() function needs to chain up to the parent ↵Charles Kerr2012-06-061-0/+2
| | | | class.
* in IndicatorPowerDevice's class init function, use ↵Charles Kerr2012-06-061-26/+39
| | | | g_object_class_install_properties() instead of installing each property separately.
* copyediting: fix tab damage in device.[ch]Charles Kerr2012-06-011-174/+176
|
* In indicator_power_device_get_time_details(), add a test for non-devices ↵Charles Kerr2012-06-011-0/+9
| | | | being passed in.
* Fix edge case in indicator_power_device_get_icon_names() that returned a bad ↵Charles Kerr2012-06-011-1/+1
| | | | value if the caller passed in a NULL pointer as a device. Added regression test.
* In indicator_power_device_get_time_details(), use g_strdup(foo) instead of ↵Charles Kerr2012-06-011-2/+2
| | | | g_strdup_printf("%s",foo)
* capitalize the second word in 'AC Adapter'Charles Kerr2012-06-011-1/+1
|
* in indicator_power_device_get_time_details(), don't list 'not present' for ↵Charles Kerr2012-06-011-1/+8
| | | | AC Adapters that have no % and no time estimate
* In indicator_power_device_get_time_details(), remove an unlikely branch that ↵Charles Kerr2012-06-011-42/+30
| | | | could result in time/detail strings not being set.
* in indicator_power_device_get_time_details(), limit the scope of variables ↵Charles Kerr2012-05-311-3/+3
| | | | short_timestring and detailed_timestring
* Move private indicator-power function build_device_time_details() to ↵Charles Kerr2012-05-311-0/+195
| | | | device.c to public function indicator_power_device_get_time_details() so that we can unit test the user-visible strings.
* remove IndicatorPowerDevice's now-unused device icon string.Charles Kerr2012-05-311-126/+0
|
* Add indicator_power_device_get_icon_names().Charles Kerr2012-05-311-1/+242
| | | | | | | The main goal of this change is to make it possible to test the device's icon. A secondary goal is to clarify in the code how indicator-power's icons differ from the ones recommended by GSD.
* use g_clear_pointer() where usefulCharles Kerr2012-05-291-6/+2
|
* try adding LCOV_EXCL_{START,STOP} for unreachable conditions (glib looking ↵Charles Kerr2012-05-261-3/+17
| | | | for subclasses of IndicatorPowerDevice; unreachables in G_DEFINE_TYPE)
* nope, LCOV_EXCL_LINE doesn't work on macrosCharles Kerr2012-05-261-7/+7
|
* try adding LCOV_EXCL_LINE for unreachable conditions (glib looking for ↵Charles Kerr2012-05-261-7/+7
| | | | subclasses of IndicatorPowerDevice; unreachables in G_DEFINE_TYPE)
* remove the 'default' clause from get_property() and set_property().Charles Kerr2012-05-241-8/+0
| | | | | Coverage testing isn't reaching them... glib is weeding out these invalid property keys before the device.c functions are ever reached. Nevertheless, leaving out a 'default' clause in a switch statement feels very unnatural to me. *twitch* *twitch*
* remove some unnecessary type compatibilty tests... g_object_get_property() ↵Charles Kerr2012-05-241-6/+0
| | | | does these tests for us
* remove some unnecessary type compatibilty tests... g_object_set_property() ↵Charles Kerr2012-05-241-6/+0
| | | | does these tests for us
* remove the g_clear_pointer() calls s.t. things will build and run on ↵Charles Kerr2012-05-241-2/+6
| | | | alesage's Jenkins setup running Precise
* add private container struct IndicatorPowerDeviceCharles Kerr2012-05-241-0/+330
generated by cgit v1.2.3 (git 2.25.1) at 2024-12-02 15:58:17 +0000