aboutsummaryrefslogtreecommitdiff
path: root/src/indicator-power.c
Commit message (Collapse)AuthorAgeFilesLines
* remove the old IndicatorObject codeCharles Kerr2013-06-161-663/+0
|
* merge lp:~psusi/ubuntu/raring/indicator-power/show-upsPhillip Susi2013-01-141-1/+2
|
* when choosing a primary device from devices that are neither charging nor ↵Charles Kerr2012-11-061-14/+36
| | | | discharging, prefer batteries, then everything except line-power, then line power
* when choosing between two devices, always pick the one that's not a ↵Charles Kerr2012-11-061-1/+20
| | | | UP_DEVICE_KIND_LINE_POWER
* copyediting: fix comment textCharles Kerr2012-10-291-1/+1
|
* fix logic error when deciding which primary device to select.Charles Kerr2012-10-261-2/+2
|
* Select the primary device based on the spec's criteria. Add tests to confirm.Charles Kerr2012-10-261-56/+75
|
* fix leaked icon and label; found by running valgrind on tests/test-indicatorCharles Kerr2012-10-261-0/+4
|
* get_icon: Plug memory leakLars Uebernickel2012-09-251-0/+1
|
* remove some dead code.Charles Kerr2012-06-071-19/+4
|
* In indicator-power.c's put_primary_device(), remove dead code.Charles Kerr2012-06-011-15/+7
|
* Move private indicator-power function build_device_time_details() to ↵Charles Kerr2012-05-311-198/+3
| | | | device.c to public function indicator_power_device_get_time_details() so that we can unit test the user-visible strings.
* Add indicator_power_device_get_icon_names().Charles Kerr2012-05-311-108/+8
| | | | | | | The main goal of this change is to make it possible to test the device's icon. A secondary goal is to clarify in the code how indicator-power's icons differ from the ones recommended by GSD.
* t^Cak to indicator_set_power_differences()Charles Kerr2012-05-291-3/+2
|
* use signals to decouple i-power and dbus-listenerCharles Kerr2012-05-271-21/+11
|
* try adding LCOV_EXCL_{START,STOP} for unreachable conditions (glib looking ↵Charles Kerr2012-05-261-0/+6
| | | | for subclasses of IndicatorPowerDevice; unreachables in G_DEFINE_TYPE)
* separate the dbus org.gnome.SettingsDaemon.Power logic into a separate classCharles Kerr2012-05-261-146/+9
|
* make indicator_power_set_devices() safe for passing in the same devices more ↵Charles Kerr2012-05-251-12/+14
| | | | than once
* fix negated logic in menu_add_device() introduced in r160Charles Kerr2012-05-251-1/+1
|
* indicator_power_set_devices() should fail gracefully when no devices are ↵Charles Kerr2012-05-251-2/+5
| | | | available
* modify IndicatorPower to use IndicatorPowerDevices internallyCharles Kerr2012-05-251-185/+159
|
* put IndicatorPower's fields back inside a priv structCharles Kerr2012-05-251-58/+96
|
* add a 'hello world' test for instantiating IndicatorPowerCharles Kerr2012-05-241-40/+1
|
* replace 'Power Settings...' with 'Power Settings…'Charles Kerr2012-05-231-1/+1
|
* tweak: in put_primary_device(), peek at the variant's strings instead of ↵Charles Kerr2012-04-151-5/+3
| | | | dup'ing them
* sync with lp:indicator-powerCharles Kerr2012-04-151-3/+10
|\
| * use atk_object_set_name(foo,bar)" instead of ↵Charles Kerr2012-04-091-1/+1
| | | | | | | | g_object_set(foo,"accessible-name",bar,NULL)"
| * leak fix 3 of 3: don't leak the GIcons returned by get_device_icon()Charles Kerr2012-04-091-0/+2
| |
| * leak fix 2 of 3: fix leaky fallback GIcon in get_device_icon()Charles Kerr2012-04-091-3/+4
| |
| * leak fix 1 of 3: don't leak object_path and device_icon if kind == ↵Charles Kerr2012-04-091-6/+4
| | | | | | | | UP_DEVICE_KIND_LINE_POWER
| * if possible, set the device menuitems' accessible names.Charles Kerr2012-04-091-0/+4
| |
* | fix leaked strings in menu_add_device when (kind == UP_DEVICE_KIND_LINE_POWER)Charles Kerr2012-04-151-6/+4
| |
* | Fix memory leaks in get_primary_device().Charles Kerr2012-03-171-32/+28
| | | | | | | | | | | | | | 1. All the calls to g_variant_get_child_value() were leaked. Fixed by changing the use to g_variant_get_child() and keeping index values of the interesting children instead of pointers to them. 2. There were several paths where the local string "object_path" and "device_icon" were leaked. (For example, any non-battery entry given to us by upower). Fixed by making these const strings and peeking them from the variant with "&s" instead of "s".
* | Fix variant leak in count_batteries() -- the returned value of ↵Charles Kerr2012-03-171-0/+2
| | | | | | | | g_variant_get_child_value() needs to be freed with g_variant_unref() when we're done with it.
* | fix variant leaks in menu_add_devices()Charles Kerr2012-03-171-2/+2
|/
* when a new entry is added, ensure that its accessible_string is properly setCharles Kerr2012-02-221-10/+37
|
* fix trivial indentation errorCharles Kerr2012-02-221-1/+1
|
* fix trivial misspellingCharles Kerr2012-02-221-16/+16
|
* fix set_accessible_desc() to update the entries' accessible_desc fields and ↵Charles Kerr2012-02-221-6/+17
| | | | emit the accessible-desc-changed signal
* register for g-properties-changed rather than g-signalCharles Kerr2012-02-161-19/+15
|
* Use G_GNUC_CONST for indicator_power_get_type() to improve performanceJavier Jardón2012-02-141-1/+1
|
* Code style fixesJavier Jardón2012-02-141-16/+19
|
* ensure that we don't have a reference to the proxy or proxy_cancel fields in ↵Charles Kerr2012-02-131-0/+3
| | | | indicator_power_dispose().
* move POWER_INDICATOR_ICON_POLICY_* enum to the top of the fileCharles Kerr2012-02-131-6/+6
|
* remove unncessary private field 'visible'Charles Kerr2012-02-131-12/+3
|
* consistent use of ICON_POLICY_KEYCharles Kerr2012-02-131-1/+1
|
* remove unnecessary G_OBJECT() castCharles Kerr2012-02-131-1/+1
|
* make prototypes for update_visibility() and should_be_visible() align with ↵Charles Kerr2012-02-131-2/+2
| | | | the neighboring forward declarations
* add support for icon-policy settingCharles Kerr2012-02-011-13/+116
|
* create the menu at init time s.t. we don't have to keep checking to see if ↵Charles Kerr2012-02-011-4/+3
| | | | it exists