Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | fix logic error when deciding which primary device to select. | Charles Kerr | 2012-10-26 | 1 | -2/+2 |
| | |||||
* | Select the primary device based on the spec's criteria. Add tests to confirm. | Charles Kerr | 2012-10-26 | 1 | -56/+75 |
| | |||||
* | fix leaked icon and label; found by running valgrind on tests/test-indicator | Charles Kerr | 2012-10-26 | 1 | -0/+4 |
| | |||||
* | get_icon: Plug memory leak | Lars Uebernickel | 2012-09-25 | 1 | -0/+1 |
| | |||||
* | remove some dead code. | Charles Kerr | 2012-06-07 | 1 | -19/+4 |
| | |||||
* | In indicator-power.c's put_primary_device(), remove dead code. | Charles Kerr | 2012-06-01 | 1 | -15/+7 |
| | |||||
* | Move private indicator-power function build_device_time_details() to ↵ | Charles Kerr | 2012-05-31 | 1 | -198/+3 |
| | | | | device.c to public function indicator_power_device_get_time_details() so that we can unit test the user-visible strings. | ||||
* | Add indicator_power_device_get_icon_names(). | Charles Kerr | 2012-05-31 | 1 | -108/+8 |
| | | | | | | | The main goal of this change is to make it possible to test the device's icon. A secondary goal is to clarify in the code how indicator-power's icons differ from the ones recommended by GSD. | ||||
* | t^Cak to indicator_set_power_differences() | Charles Kerr | 2012-05-29 | 1 | -3/+2 |
| | |||||
* | use signals to decouple i-power and dbus-listener | Charles Kerr | 2012-05-27 | 1 | -21/+11 |
| | |||||
* | try adding LCOV_EXCL_{START,STOP} for unreachable conditions (glib looking ↵ | Charles Kerr | 2012-05-26 | 1 | -0/+6 |
| | | | | for subclasses of IndicatorPowerDevice; unreachables in G_DEFINE_TYPE) | ||||
* | separate the dbus org.gnome.SettingsDaemon.Power logic into a separate class | Charles Kerr | 2012-05-26 | 1 | -146/+9 |
| | |||||
* | make indicator_power_set_devices() safe for passing in the same devices more ↵ | Charles Kerr | 2012-05-25 | 1 | -12/+14 |
| | | | | than once | ||||
* | fix negated logic in menu_add_device() introduced in r160 | Charles Kerr | 2012-05-25 | 1 | -1/+1 |
| | |||||
* | indicator_power_set_devices() should fail gracefully when no devices are ↵ | Charles Kerr | 2012-05-25 | 1 | -2/+5 |
| | | | | available | ||||
* | modify IndicatorPower to use IndicatorPowerDevices internally | Charles Kerr | 2012-05-25 | 1 | -185/+159 |
| | |||||
* | put IndicatorPower's fields back inside a priv struct | Charles Kerr | 2012-05-25 | 1 | -58/+96 |
| | |||||
* | add a 'hello world' test for instantiating IndicatorPower | Charles Kerr | 2012-05-24 | 1 | -40/+1 |
| | |||||
* | replace 'Power Settings...' with 'Power Settings…' | Charles Kerr | 2012-05-23 | 1 | -1/+1 |
| | |||||
* | tweak: in put_primary_device(), peek at the variant's strings instead of ↵ | Charles Kerr | 2012-04-15 | 1 | -5/+3 |
| | | | | dup'ing them | ||||
* | sync with lp:indicator-power | Charles Kerr | 2012-04-15 | 1 | -3/+10 |
|\ | |||||
| * | use atk_object_set_name(foo,bar)" instead of ↵ | Charles Kerr | 2012-04-09 | 1 | -1/+1 |
| | | | | | | | | g_object_set(foo,"accessible-name",bar,NULL)" | ||||
| * | leak fix 3 of 3: don't leak the GIcons returned by get_device_icon() | Charles Kerr | 2012-04-09 | 1 | -0/+2 |
| | | |||||
| * | leak fix 2 of 3: fix leaky fallback GIcon in get_device_icon() | Charles Kerr | 2012-04-09 | 1 | -3/+4 |
| | | |||||
| * | leak fix 1 of 3: don't leak object_path and device_icon if kind == ↵ | Charles Kerr | 2012-04-09 | 1 | -6/+4 |
| | | | | | | | | UP_DEVICE_KIND_LINE_POWER | ||||
| * | if possible, set the device menuitems' accessible names. | Charles Kerr | 2012-04-09 | 1 | -0/+4 |
| | | |||||
* | | fix leaked strings in menu_add_device when (kind == UP_DEVICE_KIND_LINE_POWER) | Charles Kerr | 2012-04-15 | 1 | -6/+4 |
| | | |||||
* | | Fix memory leaks in get_primary_device(). | Charles Kerr | 2012-03-17 | 1 | -32/+28 |
| | | | | | | | | | | | | | | 1. All the calls to g_variant_get_child_value() were leaked. Fixed by changing the use to g_variant_get_child() and keeping index values of the interesting children instead of pointers to them. 2. There were several paths where the local string "object_path" and "device_icon" were leaked. (For example, any non-battery entry given to us by upower). Fixed by making these const strings and peeking them from the variant with "&s" instead of "s". | ||||
* | | Fix variant leak in count_batteries() -- the returned value of ↵ | Charles Kerr | 2012-03-17 | 1 | -0/+2 |
| | | | | | | | | g_variant_get_child_value() needs to be freed with g_variant_unref() when we're done with it. | ||||
* | | fix variant leaks in menu_add_devices() | Charles Kerr | 2012-03-17 | 1 | -2/+2 |
|/ | |||||
* | when a new entry is added, ensure that its accessible_string is properly set | Charles Kerr | 2012-02-22 | 1 | -10/+37 |
| | |||||
* | fix trivial indentation error | Charles Kerr | 2012-02-22 | 1 | -1/+1 |
| | |||||
* | fix trivial misspelling | Charles Kerr | 2012-02-22 | 1 | -16/+16 |
| | |||||
* | fix set_accessible_desc() to update the entries' accessible_desc fields and ↵ | Charles Kerr | 2012-02-22 | 1 | -6/+17 |
| | | | | emit the accessible-desc-changed signal | ||||
* | register for g-properties-changed rather than g-signal | Charles Kerr | 2012-02-16 | 1 | -19/+15 |
| | |||||
* | Use G_GNUC_CONST for indicator_power_get_type() to improve performance | Javier Jardón | 2012-02-14 | 1 | -1/+1 |
| | |||||
* | Code style fixes | Javier Jardón | 2012-02-14 | 1 | -16/+19 |
| | |||||
* | ensure that we don't have a reference to the proxy or proxy_cancel fields in ↵ | Charles Kerr | 2012-02-13 | 1 | -0/+3 |
| | | | | indicator_power_dispose(). | ||||
* | move POWER_INDICATOR_ICON_POLICY_* enum to the top of the file | Charles Kerr | 2012-02-13 | 1 | -6/+6 |
| | |||||
* | remove unncessary private field 'visible' | Charles Kerr | 2012-02-13 | 1 | -12/+3 |
| | |||||
* | consistent use of ICON_POLICY_KEY | Charles Kerr | 2012-02-13 | 1 | -1/+1 |
| | |||||
* | remove unnecessary G_OBJECT() cast | Charles Kerr | 2012-02-13 | 1 | -1/+1 |
| | |||||
* | make prototypes for update_visibility() and should_be_visible() align with ↵ | Charles Kerr | 2012-02-13 | 1 | -2/+2 |
| | | | | the neighboring forward declarations | ||||
* | add support for icon-policy setting | Charles Kerr | 2012-02-01 | 1 | -13/+116 |
| | |||||
* | create the menu at init time s.t. we don't have to keep checking to see if ↵ | Charles Kerr | 2012-02-01 | 1 | -4/+3 |
| | | | | it exists | ||||
* | use g_settings_bind() for the show-time checkbox | Charles Kerr | 2012-02-01 | 1 | -16/+4 |
| | |||||
* | better error reporting if g_spawn_command_line_async() fails | Charles Kerr | 2012-02-01 | 1 | -8/+11 |
| | |||||
* | remove redundant #include of glib.h | Charles Kerr | 2012-02-01 | 1 | -1/+0 |
| | |||||
* | use g_clear_object() on the proxy_cancel field | Charles Kerr | 2012-02-01 | 1 | -5/+1 |
| | |||||
* | remove unnecessary Priv struct -- the =entire class= is private | Charles Kerr | 2012-02-01 | 1 | -84/+56 |
| |