Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | remove IndicatorPowerDevice's now-unused device icon string. | Charles Kerr | 2012-05-31 | 2 | -129/+0 |
| | |||||
* | Add indicator_power_device_get_icon_names(). | Charles Kerr | 2012-05-31 | 3 | -109/+255 |
| | | | | | | | The main goal of this change is to make it possible to test the device's icon. A secondary goal is to clarify in the code how indicator-power's icons differ from the ones recommended by GSD. | ||||
* | remove some g_message() calls that shouldn't've been committed. | Charles Kerr | 2012-05-31 | 1 | -5/+0 |
| | |||||
* | add a test to make sure that the listener responds to a PropertiesChanged signal | Charles Kerr | 2012-05-29 | 1 | -0/+5 |
| | |||||
* | t^Cak to indicator_set_power_differences() | Charles Kerr | 2012-05-29 | 1 | -3/+2 |
| | |||||
* | use g_clear_pointer() where useful | Charles Kerr | 2012-05-29 | 1 | -6/+2 |
| | |||||
* | exclude G_DEFINE_TYPE from coverage testing in dbus-listener.c | Charles Kerr | 2012-05-29 | 1 | -0/+2 |
| | |||||
* | add a mock GSD.Power to handle the GetPower requests | Charles Kerr | 2012-05-28 | 2 | -8/+8 |
| | |||||
* | use signals to decouple i-power and dbus-listener | Charles Kerr | 2012-05-27 | 4 | -102/+38 |
| | |||||
* | try adding LCOV_EXCL_{START,STOP} for unreachable conditions (glib looking ↵ | Charles Kerr | 2012-05-26 | 2 | -3/+23 |
| | | | | for subclasses of IndicatorPowerDevice; unreachables in G_DEFINE_TYPE) | ||||
* | nope, LCOV_EXCL_LINE doesn't work on macros | Charles Kerr | 2012-05-26 | 1 | -7/+7 |
| | |||||
* | try adding LCOV_EXCL_LINE for unreachable conditions (glib looking for ↵ | Charles Kerr | 2012-05-26 | 1 | -7/+7 |
| | | | | subclasses of IndicatorPowerDevice; unreachables in G_DEFINE_TYPE) | ||||
* | reuse the same cancellable across multiple non-concurrent dbus calls | Charles Kerr | 2012-05-26 | 1 | -18/+18 |
| | |||||
* | avoid a cyclical refcount dependency between IndicatorPower and its DBusListener | Charles Kerr | 2012-05-26 | 1 | -3/+17 |
| | |||||
* | separate the dbus org.gnome.SettingsDaemon.Power logic into a separate class | Charles Kerr | 2012-05-26 | 4 | -147/+366 |
| | |||||
* | make indicator_power_set_devices() safe for passing in the same devices more ↵ | Charles Kerr | 2012-05-25 | 1 | -12/+14 |
| | | | | than once | ||||
* | fix negated logic in menu_add_device() introduced in r160 | Charles Kerr | 2012-05-25 | 1 | -1/+1 |
| | |||||
* | indicator_power_set_devices() should fail gracefully when no devices are ↵ | Charles Kerr | 2012-05-25 | 1 | -2/+5 |
| | | | | available | ||||
* | modify IndicatorPower to use IndicatorPowerDevices internally | Charles Kerr | 2012-05-25 | 2 | -185/+165 |
| | |||||
* | put IndicatorPower's fields back inside a priv struct | Charles Kerr | 2012-05-25 | 2 | -74/+99 |
| | |||||
* | remove the 'default' clause from get_property() and set_property(). | Charles Kerr | 2012-05-24 | 1 | -8/+0 |
| | | | | | Coverage testing isn't reaching them... glib is weeding out these invalid property keys before the device.c functions are ever reached. Nevertheless, leaving out a 'default' clause in a switch statement feels very unnatural to me. *twitch* *twitch* | ||||
* | remove some unnecessary type compatibilty tests... g_object_get_property() ↵ | Charles Kerr | 2012-05-24 | 1 | -6/+0 |
| | | | | does these tests for us | ||||
* | remove some unnecessary type compatibilty tests... g_object_set_property() ↵ | Charles Kerr | 2012-05-24 | 1 | -6/+0 |
| | | | | does these tests for us | ||||
* | remove the g_clear_pointer() calls s.t. things will build and run on ↵ | Charles Kerr | 2012-05-24 | 1 | -2/+6 |
| | | | | alesage's Jenkins setup running Precise | ||||
* | add a 'hello world' test for instantiating IndicatorPower | Charles Kerr | 2012-05-24 | 2 | -40/+69 |
| | |||||
* | add private container struct IndicatorPowerDevice | Charles Kerr | 2012-05-24 | 3 | -2/+436 |
| | |||||
* | replace 'Power Settings...' with 'Power Settings…' | Charles Kerr | 2012-05-23 | 1 | -1/+1 |
| | |||||
* | move libpower's automake rules into src/ | Charles Kerr | 2012-05-23 | 1 | -0/+28 |
| | |||||
* | tweak: in put_primary_device(), peek at the variant's strings instead of ↵ | Charles Kerr | 2012-04-15 | 1 | -5/+3 |
| | | | | dup'ing them | ||||
* | sync with lp:indicator-power | Charles Kerr | 2012-04-15 | 1 | -3/+10 |
|\ | |||||
| * | use atk_object_set_name(foo,bar)" instead of ↵ | Charles Kerr | 2012-04-09 | 1 | -1/+1 |
| | | | | | | | | g_object_set(foo,"accessible-name",bar,NULL)" | ||||
| * | leak fix 3 of 3: don't leak the GIcons returned by get_device_icon() | Charles Kerr | 2012-04-09 | 1 | -0/+2 |
| | | |||||
| * | leak fix 2 of 3: fix leaky fallback GIcon in get_device_icon() | Charles Kerr | 2012-04-09 | 1 | -3/+4 |
| | | |||||
| * | leak fix 1 of 3: don't leak object_path and device_icon if kind == ↵ | Charles Kerr | 2012-04-09 | 1 | -6/+4 |
| | | | | | | | | UP_DEVICE_KIND_LINE_POWER | ||||
| * | if possible, set the device menuitems' accessible names. | Charles Kerr | 2012-04-09 | 1 | -0/+4 |
| | | |||||
* | | fix leaked strings in menu_add_device when (kind == UP_DEVICE_KIND_LINE_POWER) | Charles Kerr | 2012-04-15 | 1 | -6/+4 |
| | | |||||
* | | Fix memory leaks in get_primary_device(). | Charles Kerr | 2012-03-17 | 1 | -32/+28 |
| | | | | | | | | | | | | | | 1. All the calls to g_variant_get_child_value() were leaked. Fixed by changing the use to g_variant_get_child() and keeping index values of the interesting children instead of pointers to them. 2. There were several paths where the local string "object_path" and "device_icon" were leaked. (For example, any non-battery entry given to us by upower). Fixed by making these const strings and peeking them from the variant with "&s" instead of "s". | ||||
* | | Fix variant leak in count_batteries() -- the returned value of ↵ | Charles Kerr | 2012-03-17 | 1 | -0/+2 |
| | | | | | | | | g_variant_get_child_value() needs to be freed with g_variant_unref() when we're done with it. | ||||
* | | fix variant leaks in menu_add_devices() | Charles Kerr | 2012-03-17 | 1 | -2/+2 |
|/ | |||||
* | when a new entry is added, ensure that its accessible_string is properly set | Charles Kerr | 2012-02-22 | 1 | -10/+37 |
| | |||||
* | fix trivial indentation error | Charles Kerr | 2012-02-22 | 1 | -1/+1 |
| | |||||
* | fix trivial misspelling | Charles Kerr | 2012-02-22 | 1 | -16/+16 |
| | |||||
* | fix set_accessible_desc() to update the entries' accessible_desc fields and ↵ | Charles Kerr | 2012-02-22 | 1 | -6/+17 |
| | | | | emit the accessible-desc-changed signal | ||||
* | register for g-properties-changed rather than g-signal | Charles Kerr | 2012-02-16 | 1 | -19/+15 |
| | |||||
* | Use G_GNUC_CONST for indicator_power_get_type() to improve performance | Javier Jardón | 2012-02-14 | 1 | -1/+1 |
| | |||||
* | Code style fixes | Javier Jardón | 2012-02-14 | 1 | -16/+19 |
| | |||||
* | ensure that we don't have a reference to the proxy or proxy_cancel fields in ↵ | Charles Kerr | 2012-02-13 | 1 | -0/+3 |
| | | | | indicator_power_dispose(). | ||||
* | move POWER_INDICATOR_ICON_POLICY_* enum to the top of the file | Charles Kerr | 2012-02-13 | 1 | -6/+6 |
| | |||||
* | remove unncessary private field 'visible' | Charles Kerr | 2012-02-13 | 1 | -12/+3 |
| | |||||
* | consistent use of ICON_POLICY_KEY | Charles Kerr | 2012-02-13 | 1 | -1/+1 |
| |