Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | remove prototype for indicator_power_dbus_listener_new() since it's not ↵ | Charles Kerr | 2012-06-06 | 1 | -3/+0 |
| | | | | needed/used | ||||
* | simplify the devices-enumerated signal's name | Charles Kerr | 2012-06-06 | 2 | -2/+2 |
| | |||||
* | if self->cancellable is non-NULL in dispose(), pass it to ↵ | Charles Kerr | 2012-06-06 | 1 | -1/+6 |
| | | | | g_cancellable_cancel() before clearing the listener's reference | ||||
* | remove trailing whitespace | Charles Kerr | 2012-06-06 | 1 | -1/+1 |
| | |||||
* | add g_bus_unwatch_name() to watcher's dispose() method | Charles Kerr | 2012-06-06 | 1 | -0/+6 |
| | |||||
* | add a GTK-Doc signal comment block for indictor-power-dbus-listener's ↵ | Charles Kerr | 2012-06-06 | 1 | -2/+9 |
| | | | | enumerated signal | ||||
* | move the header files from noinst_HEADERS to libpower_la_SOURCES | Charles Kerr | 2012-06-06 | 1 | -5/+3 |
| | |||||
* | In indicator-power.c's put_primary_device(), remove dead code. | Charles Kerr | 2012-06-01 | 1 | -15/+7 |
| | |||||
* | copyediting: fix tab damage in dbus-listener.[ch] | Charles Kerr | 2012-06-01 | 2 | -116/+114 |
| | |||||
* | copyediting: fix tab damage in device.[ch] | Charles Kerr | 2012-06-01 | 2 | -177/+179 |
| | |||||
* | In indicator_power_device_get_time_details(), add a test for non-devices ↵ | Charles Kerr | 2012-06-01 | 1 | -0/+9 |
| | | | | being passed in. | ||||
* | Fix edge case in indicator_power_device_get_icon_names() that returned a bad ↵ | Charles Kerr | 2012-06-01 | 1 | -1/+1 |
| | | | | value if the caller passed in a NULL pointer as a device. Added regression test. | ||||
* | In indicator_power_device_get_time_details(), use g_strdup(foo) instead of ↵ | Charles Kerr | 2012-06-01 | 1 | -2/+2 |
| | | | | g_strdup_printf("%s",foo) | ||||
* | capitalize the second word in 'AC Adapter' | Charles Kerr | 2012-06-01 | 1 | -1/+1 |
| | |||||
* | in indicator_power_device_get_time_details(), don't list 'not present' for ↵ | Charles Kerr | 2012-06-01 | 1 | -1/+8 |
| | | | | AC Adapters that have no % and no time estimate | ||||
* | In indicator_power_device_get_time_details(), remove an unlikely branch that ↵ | Charles Kerr | 2012-06-01 | 1 | -42/+30 |
| | | | | could result in time/detail strings not being set. | ||||
* | Add gcda/gcno to CLEANFILES s.t. 'make clean' will cover them | Charles Kerr | 2012-06-01 | 1 | -0/+3 |
| | |||||
* | in indicator_power_device_get_time_details(), limit the scope of variables ↵ | Charles Kerr | 2012-05-31 | 1 | -3/+3 |
| | | | | short_timestring and detailed_timestring | ||||
* | Move private indicator-power function build_device_time_details() to ↵ | Charles Kerr | 2012-05-31 | 3 | -198/+203 |
| | | | | device.c to public function indicator_power_device_get_time_details() so that we can unit test the user-visible strings. | ||||
* | remove IndicatorPowerDevice's now-unused device icon string. | Charles Kerr | 2012-05-31 | 2 | -129/+0 |
| | |||||
* | Add indicator_power_device_get_icon_names(). | Charles Kerr | 2012-05-31 | 3 | -109/+255 |
| | | | | | | | The main goal of this change is to make it possible to test the device's icon. A secondary goal is to clarify in the code how indicator-power's icons differ from the ones recommended by GSD. | ||||
* | remove some g_message() calls that shouldn't've been committed. | Charles Kerr | 2012-05-31 | 1 | -5/+0 |
| | |||||
* | add a test to make sure that the listener responds to a PropertiesChanged signal | Charles Kerr | 2012-05-29 | 1 | -0/+5 |
| | |||||
* | t^Cak to indicator_set_power_differences() | Charles Kerr | 2012-05-29 | 1 | -3/+2 |
| | |||||
* | use g_clear_pointer() where useful | Charles Kerr | 2012-05-29 | 1 | -6/+2 |
| | |||||
* | exclude G_DEFINE_TYPE from coverage testing in dbus-listener.c | Charles Kerr | 2012-05-29 | 1 | -0/+2 |
| | |||||
* | add a mock GSD.Power to handle the GetPower requests | Charles Kerr | 2012-05-28 | 2 | -8/+8 |
| | |||||
* | use signals to decouple i-power and dbus-listener | Charles Kerr | 2012-05-27 | 4 | -102/+38 |
| | |||||
* | try adding LCOV_EXCL_{START,STOP} for unreachable conditions (glib looking ↵ | Charles Kerr | 2012-05-26 | 2 | -3/+23 |
| | | | | for subclasses of IndicatorPowerDevice; unreachables in G_DEFINE_TYPE) | ||||
* | nope, LCOV_EXCL_LINE doesn't work on macros | Charles Kerr | 2012-05-26 | 1 | -7/+7 |
| | |||||
* | try adding LCOV_EXCL_LINE for unreachable conditions (glib looking for ↵ | Charles Kerr | 2012-05-26 | 1 | -7/+7 |
| | | | | subclasses of IndicatorPowerDevice; unreachables in G_DEFINE_TYPE) | ||||
* | reuse the same cancellable across multiple non-concurrent dbus calls | Charles Kerr | 2012-05-26 | 1 | -18/+18 |
| | |||||
* | avoid a cyclical refcount dependency between IndicatorPower and its DBusListener | Charles Kerr | 2012-05-26 | 1 | -3/+17 |
| | |||||
* | separate the dbus org.gnome.SettingsDaemon.Power logic into a separate class | Charles Kerr | 2012-05-26 | 4 | -147/+366 |
| | |||||
* | make indicator_power_set_devices() safe for passing in the same devices more ↵ | Charles Kerr | 2012-05-25 | 1 | -12/+14 |
| | | | | than once | ||||
* | fix negated logic in menu_add_device() introduced in r160 | Charles Kerr | 2012-05-25 | 1 | -1/+1 |
| | |||||
* | indicator_power_set_devices() should fail gracefully when no devices are ↵ | Charles Kerr | 2012-05-25 | 1 | -2/+5 |
| | | | | available | ||||
* | modify IndicatorPower to use IndicatorPowerDevices internally | Charles Kerr | 2012-05-25 | 2 | -185/+165 |
| | |||||
* | put IndicatorPower's fields back inside a priv struct | Charles Kerr | 2012-05-25 | 2 | -74/+99 |
| | |||||
* | remove the 'default' clause from get_property() and set_property(). | Charles Kerr | 2012-05-24 | 1 | -8/+0 |
| | | | | | Coverage testing isn't reaching them... glib is weeding out these invalid property keys before the device.c functions are ever reached. Nevertheless, leaving out a 'default' clause in a switch statement feels very unnatural to me. *twitch* *twitch* | ||||
* | remove some unnecessary type compatibilty tests... g_object_get_property() ↵ | Charles Kerr | 2012-05-24 | 1 | -6/+0 |
| | | | | does these tests for us | ||||
* | remove some unnecessary type compatibilty tests... g_object_set_property() ↵ | Charles Kerr | 2012-05-24 | 1 | -6/+0 |
| | | | | does these tests for us | ||||
* | remove the g_clear_pointer() calls s.t. things will build and run on ↵ | Charles Kerr | 2012-05-24 | 1 | -2/+6 |
| | | | | alesage's Jenkins setup running Precise | ||||
* | add a 'hello world' test for instantiating IndicatorPower | Charles Kerr | 2012-05-24 | 2 | -40/+69 |
| | |||||
* | add private container struct IndicatorPowerDevice | Charles Kerr | 2012-05-24 | 3 | -2/+436 |
| | |||||
* | replace 'Power Settings...' with 'Power Settings…' | Charles Kerr | 2012-05-23 | 1 | -1/+1 |
| | |||||
* | move libpower's automake rules into src/ | Charles Kerr | 2012-05-23 | 1 | -0/+28 |
| | |||||
* | tweak: in put_primary_device(), peek at the variant's strings instead of ↵ | Charles Kerr | 2012-04-15 | 1 | -5/+3 |
| | | | | dup'ing them | ||||
* | sync with lp:indicator-power | Charles Kerr | 2012-04-15 | 1 | -3/+10 |
|\ | |||||
| * | use atk_object_set_name(foo,bar)" instead of ↵ | Charles Kerr | 2012-04-09 | 1 | -1/+1 |
| | | | | | | | | g_object_set(foo,"accessible-name",bar,NULL)" |