Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | copyediting: fix comment text | Charles Kerr | 2012-10-29 | 1 | -1/+1 |
| | |||||
* | fix logic error when deciding which primary device to select. | Charles Kerr | 2012-10-26 | 1 | -2/+2 |
| | |||||
* | fix copy-paste comment error | Charles Kerr | 2012-10-26 | 1 | -1/+1 |
| | |||||
* | Select the primary device based on the spec's criteria. Add tests to confirm. | Charles Kerr | 2012-10-26 | 2 | -56/+77 |
| | |||||
* | fix leaked icon and label; found by running valgrind on tests/test-indicator | Charles Kerr | 2012-10-26 | 1 | -0/+4 |
| | |||||
* | Fix unhandled enum 'unknown device' that was smoked out by the unit tests. | Charles Kerr | 2012-10-26 | 1 | -0/+4 |
| | |||||
* | the device kind string wasn't being used in some icon names. | Charles Kerr | 2012-10-25 | 1 | -14/+14 |
| | |||||
* | when discharging the battery, prefer the percent-charged icons over the ↵ | Charles Kerr | 2012-10-03 | 1 | -1/+2 |
| | | | | full,good,low icons because the former show a more accurate view of the charge. | ||||
* | get_icon: Plug memory leak | Lars Uebernickel | 2012-09-25 | 1 | -0/+1 |
| | |||||
* | device.c: include gi18n-lib.h instead of gi18n.h | Lars Uebernickel | 2012-09-20 | 1 | -1/+1 |
| | | | | | | The former calls the 'd' variants of the gettext functions and passes the libraries domain in each call. | ||||
* | remove some dead code. | Charles Kerr | 2012-06-07 | 1 | -19/+4 |
| | |||||
* | improve the variant sanity tests in indicator_power_device_new_from_variant() | Charles Kerr | 2012-06-07 | 1 | -3/+1 |
| | |||||
* | reimplement indicator_power_device_get_icon_names() since our CA is ↵ | Charles Kerr | 2012-06-06 | 1 | -76/+77 |
| | | | | incompatible with reusing code from GSD. | ||||
* | remove superfluous #include | Charles Kerr | 2012-06-06 | 1 | -2/+0 |
| | |||||
* | simplify the Device properties' name strings | Charles Kerr | 2012-06-06 | 1 | -5/+5 |
| | |||||
* | For GTK-Doc, reference functions with function_name() instead of #function_name | Charles Kerr | 2012-06-06 | 1 | -1/+1 |
| | |||||
* | In indicator_power_device_new_from_variant(), check whether the input ↵ | Charles Kerr | 2012-06-06 | 1 | -0/+4 |
| | | | | variant has the correct type before using it. | ||||
* | add G_OBJECT_WARN_INVALID_PROPERTY_ID for the 'default' switch case in ↵ | Charles Kerr | 2012-06-06 | 1 | -0/+8 |
| | | | | Device's get/set property methods | ||||
* | IndicatorObjectDevice's finalize() function needs to chain up to the parent ↵ | Charles Kerr | 2012-06-06 | 1 | -0/+2 |
| | | | | class. | ||||
* | in IndicatorPowerDevice's class init function, use ↵ | Charles Kerr | 2012-06-06 | 1 | -26/+39 |
| | | | | g_object_class_install_properties() instead of installing each property separately. | ||||
* | remove prototype for indicator_power_dbus_listener_new() since it's not ↵ | Charles Kerr | 2012-06-06 | 1 | -3/+0 |
| | | | | needed/used | ||||
* | simplify the devices-enumerated signal's name | Charles Kerr | 2012-06-06 | 2 | -2/+2 |
| | |||||
* | if self->cancellable is non-NULL in dispose(), pass it to ↵ | Charles Kerr | 2012-06-06 | 1 | -1/+6 |
| | | | | g_cancellable_cancel() before clearing the listener's reference | ||||
* | remove trailing whitespace | Charles Kerr | 2012-06-06 | 1 | -1/+1 |
| | |||||
* | add g_bus_unwatch_name() to watcher's dispose() method | Charles Kerr | 2012-06-06 | 1 | -0/+6 |
| | |||||
* | add a GTK-Doc signal comment block for indictor-power-dbus-listener's ↵ | Charles Kerr | 2012-06-06 | 1 | -2/+9 |
| | | | | enumerated signal | ||||
* | move the header files from noinst_HEADERS to libpower_la_SOURCES | Charles Kerr | 2012-06-06 | 1 | -5/+3 |
| | |||||
* | In indicator-power.c's put_primary_device(), remove dead code. | Charles Kerr | 2012-06-01 | 1 | -15/+7 |
| | |||||
* | copyediting: fix tab damage in dbus-listener.[ch] | Charles Kerr | 2012-06-01 | 2 | -116/+114 |
| | |||||
* | copyediting: fix tab damage in device.[ch] | Charles Kerr | 2012-06-01 | 2 | -177/+179 |
| | |||||
* | In indicator_power_device_get_time_details(), add a test for non-devices ↵ | Charles Kerr | 2012-06-01 | 1 | -0/+9 |
| | | | | being passed in. | ||||
* | Fix edge case in indicator_power_device_get_icon_names() that returned a bad ↵ | Charles Kerr | 2012-06-01 | 1 | -1/+1 |
| | | | | value if the caller passed in a NULL pointer as a device. Added regression test. | ||||
* | In indicator_power_device_get_time_details(), use g_strdup(foo) instead of ↵ | Charles Kerr | 2012-06-01 | 1 | -2/+2 |
| | | | | g_strdup_printf("%s",foo) | ||||
* | capitalize the second word in 'AC Adapter' | Charles Kerr | 2012-06-01 | 1 | -1/+1 |
| | |||||
* | in indicator_power_device_get_time_details(), don't list 'not present' for ↵ | Charles Kerr | 2012-06-01 | 1 | -1/+8 |
| | | | | AC Adapters that have no % and no time estimate | ||||
* | In indicator_power_device_get_time_details(), remove an unlikely branch that ↵ | Charles Kerr | 2012-06-01 | 1 | -42/+30 |
| | | | | could result in time/detail strings not being set. | ||||
* | Add gcda/gcno to CLEANFILES s.t. 'make clean' will cover them | Charles Kerr | 2012-06-01 | 1 | -0/+3 |
| | |||||
* | in indicator_power_device_get_time_details(), limit the scope of variables ↵ | Charles Kerr | 2012-05-31 | 1 | -3/+3 |
| | | | | short_timestring and detailed_timestring | ||||
* | Move private indicator-power function build_device_time_details() to ↵ | Charles Kerr | 2012-05-31 | 3 | -198/+203 |
| | | | | device.c to public function indicator_power_device_get_time_details() so that we can unit test the user-visible strings. | ||||
* | remove IndicatorPowerDevice's now-unused device icon string. | Charles Kerr | 2012-05-31 | 2 | -129/+0 |
| | |||||
* | Add indicator_power_device_get_icon_names(). | Charles Kerr | 2012-05-31 | 3 | -109/+255 |
| | | | | | | | The main goal of this change is to make it possible to test the device's icon. A secondary goal is to clarify in the code how indicator-power's icons differ from the ones recommended by GSD. | ||||
* | remove some g_message() calls that shouldn't've been committed. | Charles Kerr | 2012-05-31 | 1 | -5/+0 |
| | |||||
* | add a test to make sure that the listener responds to a PropertiesChanged signal | Charles Kerr | 2012-05-29 | 1 | -0/+5 |
| | |||||
* | t^Cak to indicator_set_power_differences() | Charles Kerr | 2012-05-29 | 1 | -3/+2 |
| | |||||
* | use g_clear_pointer() where useful | Charles Kerr | 2012-05-29 | 1 | -6/+2 |
| | |||||
* | exclude G_DEFINE_TYPE from coverage testing in dbus-listener.c | Charles Kerr | 2012-05-29 | 1 | -0/+2 |
| | |||||
* | add a mock GSD.Power to handle the GetPower requests | Charles Kerr | 2012-05-28 | 2 | -8/+8 |
| | |||||
* | use signals to decouple i-power and dbus-listener | Charles Kerr | 2012-05-27 | 4 | -102/+38 |
| | |||||
* | try adding LCOV_EXCL_{START,STOP} for unreachable conditions (glib looking ↵ | Charles Kerr | 2012-05-26 | 2 | -3/+23 |
| | | | | for subclasses of IndicatorPowerDevice; unreachables in G_DEFINE_TYPE) | ||||
* | nope, LCOV_EXCL_LINE doesn't work on macros | Charles Kerr | 2012-05-26 | 1 | -7/+7 |
| |