1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
|
# Generated by Makefile. Do not edit.
2012-11-04 Charles Kerr <charles.kerr@canonical.com>
12.10.4
2012-11-04 Charles Kerr <charles.kerr@canonical.com>
fix logic error in primary device selection; add unit tests to confirm the fix. (lp:~charlesk/indicator-power/lp-1071757)
2012-10-29 Charles Kerr <charles.kerr@canonical.com>
copyediting: fix comment text
2012-10-28 Charles Kerr <charles.kerr@canonical.com>
in TestDevice, make the log variable names a little more consistent
2012-10-28 Charles Kerr <charles.kerr@canonical.com>
set DeviceTest's gwarning/gcritical log func to one that prints no messages but accumulates the log count. This way we can both (a) silence in-console warnings that look like bugs in the test but are actually desirable warnings generated by fuzz testing, and (b) assert that we get exactly as many warnings/criticals as we expect to get.
2012-10-28 Charles Kerr <charles.kerr@canonical.com>
expand DeviceTest.ChoosePrimary to test choosing from a wider variety of device states.
2012-10-26 Charles Kerr <charles.kerr@canonical.com>
fix logic error when deciding which primary device to select.
2012-10-26 Charles Kerr <charles.kerr@canonical.com>
add test (currently failing) to detect the logic error reported in bug #1071757
2012-10-26 Charles Kerr <charles.kerr@canonical.com>
choose the correct primary device, and choose the correct icon for it.
2012-10-26 Charles Kerr <charles.kerr@canonical.com>
12.10.3
2012-10-26 Charles Kerr <charles.kerr@canonical.com>
choose the correct primary device, and choose the correct icon for it.
2012-10-26 Charles Kerr <charles.kerr@canonical.com>
fix copy-paste comment error
2012-10-26 Charles Kerr <charles.kerr@canonical.com>
fix comment typo
2012-10-26 Charles Kerr <charles.kerr@canonical.com>
Select the primary device based on the spec's criteria. Add tests to confirm.
2012-10-26 Charles Kerr <charles.kerr@canonical.com>
silence the known/nonbug gtk and glib warnings
2012-10-26 Charles Kerr <charles.kerr@canonical.com>
add unit tests to confirm the device refcounts are correct s.t. IndicatorPower isn't leaking devices
2012-10-26 Charles Kerr <charles.kerr@canonical.com>
fix leaked icon and label; found by running valgrind on tests/test-indicator
2012-10-26 Charles Kerr <charles.kerr@canonical.com>
Fix unhandled enum 'unknown device' that was smoked out by the unit tests.
2012-10-25 Charles Kerr <charles.kerr@canonical.com>
the device kind string wasn't being used in some icon names.
2012-10-03 Charles Kerr <charles.kerr@canonical.com>
12.10.2
2012-10-03 Charles Kerr <charles.kerr@canonical.com>
merge lp:~charlesk/indicator-power/lp-1054146 to give a more accurate view of discharging batteries
2012-10-03 Charles Kerr <charles.kerr@canonical.com>
when discharging the battery, prefer the percent-charged icons over the full,good,low icons because the former show a more accurate view of the charge.
2012-09-26 Lars Uebernickel <lars.uebernickel@canonical.com>
Merge lp:~/larsu/indicator-power/plug-get-icon-memory-leak
Plugs a small memory leak in indicator-power.c
2012-09-25 Lars Uebernickel <lars.uebernickel@canonical.com>
get_icon: Plug memory leak
2012-09-20 Lars Uebernickel <lars.uebernickel@canonical.com>
device.c: include gi18n-lib.h instead of gi18n.h
The former calls the 'd' variants of the gettext functions and passes the
libraries domain in each call.
2012-09-05 Charles Kerr <charles.kerr@canonical.com>
copyediting: text formatting to make the icon list more readable
2012-08-21 Charles Kerr <charles.kerr@canonical.com>
12.10.1
2012-08-21 Charles Kerr <charles.kerr@canonical.com>
merge lp:~charlesk/indicator-power/lp-1023533 to bump the glib prerequisite
2012-07-13 Charles Kerr <charles.kerr@canonical.com>
raise glib minimum to 2.33
2012-07-11 Charles Kerr <charles.kerr@canonical.com>
bump version to 12.10.0
2012-07-11 Charles Kerr <charles.kerr@canonical.com>
merge lp:~charlesk/indicator-power/coverage
2012-07-03 Charles Kerr <charles.kerr@canonical.com>
disable test-dbus-listener for now
2012-06-07 Charles Kerr <charles.kerr@canonical.com>
remove some dead code.
2012-06-07 Charles Kerr <charles.kerr@canonical.com>
improve the variant sanity tests in indicator_power_device_new_from_variant()
2012-06-06 Charles Kerr <charles.kerr@canonical.com>
reimplement indicator_power_device_get_icon_names() since our CA is incompatible with reusing code from GSD.
2012-06-06 Charles Kerr <charles.kerr@canonical.com>
remove superfluous #include
2012-06-06 Charles Kerr <charles.kerr@canonical.com>
simplify the Device properties' name strings
2012-06-06 Charles Kerr <charles.kerr@canonical.com>
For GTK-Doc, reference functions with function_name() instead of #function_name
2012-06-06 Charles Kerr <charles.kerr@canonical.com>
In indicator_power_device_new_from_variant(), check whether the input variant has the correct type before using it.
2012-06-06 Charles Kerr <charles.kerr@canonical.com>
add G_OBJECT_WARN_INVALID_PROPERTY_ID for the 'default' switch case in Device's get/set property methods
2012-06-06 Charles Kerr <charles.kerr@canonical.com>
IndicatorObjectDevice's finalize() function needs to chain up to the parent class.
2012-06-06 Charles Kerr <charles.kerr@canonical.com>
in IndicatorPowerDevice's class init function, use g_object_class_install_properties() instead of installing each property separately.
2012-06-06 Charles Kerr <charles.kerr@canonical.com>
remove prototype for indicator_power_dbus_listener_new() since it's not needed/used
2012-06-06 Charles Kerr <charles.kerr@canonical.com>
simplify the devices-enumerated signal's name
2012-06-06 Charles Kerr <charles.kerr@canonical.com>
if self->cancellable is non-NULL in dispose(), pass it to g_cancellable_cancel() before clearing the listener's reference
2012-06-06 Charles Kerr <charles.kerr@canonical.com>
remove trailing whitespace
2012-06-06 Charles Kerr <charles.kerr@canonical.com>
add g_bus_unwatch_name() to watcher's dispose() method
2012-06-06 Charles Kerr <charles.kerr@canonical.com>
add a GTK-Doc signal comment block for indictor-power-dbus-listener's enumerated signal
2012-06-06 Charles Kerr <charles.kerr@canonical.com>
move the header files from noinst_HEADERS to libpower_la_SOURCES
2012-06-01 Charles Kerr <charles.kerr@canonical.com>
In indicator-power.c's put_primary_device(), remove dead code.
2012-06-01 Charles Kerr <charles.kerr@canonical.com>
copyediting: fix tab damage in dbus-listener.[ch]
2012-06-01 Charles Kerr <charles.kerr@canonical.com>
copyediting: fix tab damage in device.[ch]
2012-06-01 Charles Kerr <charles.kerr@canonical.com>
use C++-style comments in test-device.cc
2012-06-01 Charles Kerr <charles.kerr@canonical.com>
In indicator_power_device_get_time_details(), add a test for non-devices being passed in.
2012-06-01 Charles Kerr <charles.kerr@canonical.com>
Fix edge case in indicator_power_device_get_icon_names() that returned a bad value if the caller passed in a NULL pointer as a device. Added regression test.
2012-06-01 Charles Kerr <charles.kerr@canonical.com>
In indicator_power_device_get_time_details(), use g_strdup(foo) instead of g_strdup_printf("%s",foo)
2012-06-01 Charles Kerr <charles.kerr@canonical.com>
Add coverage test for AC Adapters in indicator_power_device_get_time_details()
2012-06-01 Charles Kerr <charles.kerr@canonical.com>
capitalize the second word in 'AC Adapter'
2012-06-01 Charles Kerr <charles.kerr@canonical.com>
in indicator_power_device_get_time_details(), don't list 'not present' for AC Adapters that have no % and no time estimate
2012-06-01 Charles Kerr <charles.kerr@canonical.com>
Add unit tests for indicator_power_device_get_time_details()
2012-06-01 Charles Kerr <charles.kerr@canonical.com>
In indicator_power_device_get_time_details(), remove an unlikely branch that could result in time/detail strings not being set.
2012-06-01 Charles Kerr <charles.kerr@canonical.com>
Add gcda/gcno to CLEANFILES s.t. 'make clean' will cover them
2012-05-31 Charles Kerr <charles.kerr@canonical.com>
in indicator_power_device_get_time_details(), limit the scope of variables short_timestring and detailed_timestring
2012-05-31 Charles Kerr <charles.kerr@canonical.com>
Move private indicator-power function build_device_time_details() to device.c to public function indicator_power_device_get_time_details() so that we can unit test the user-visible strings.
2012-05-31 Charles Kerr <charles.kerr@canonical.com>
remove IndicatorPowerDevice's now-unused device icon string.
2012-05-31 Charles Kerr <charles.kerr@canonical.com>
Add indicator_power_device_get_icon_names().
The main goal of this change is to make it possible to test the
device's icon. A secondary goal is to clarify in the code how
indicator-power's icons differ from the ones recommended by GSD.
2012-05-31 Charles Kerr <charles.kerr@canonical.com>
remove some g_message() calls that shouldn't've been committed.
2012-05-29 Charles Kerr <charles.kerr@canonical.com>
add a test to make sure that the listener responds to a PropertiesChanged signal
2012-05-29 Charles Kerr <charles.kerr@canonical.com>
t^Cak to indicator_set_power_differences()
2012-05-29 Charles Kerr <charles.kerr@canonical.com>
use g_clear_pointer() where useful
2012-05-29 Charles Kerr <charles.kerr@canonical.com>
add tests for gsd GetDevices returning (a) no devices and (b) an error
2012-05-29 Charles Kerr <charles.kerr@canonical.com>
exclude G_DEFINE_TYPE from coverage testing in dbus-listener.c
2012-05-28 Charles Kerr <charles.kerr@canonical.com>
add more tests to improve coverage: different device types, no primary device
2012-05-28 Charles Kerr <charles.kerr@canonical.com>
add a mock GSD.Power to handle the GetPower requests
2012-05-27 Charles Kerr <charles.kerr@canonical.com>
use signals to decouple i-power and dbus-listener
2012-05-27 Charles Kerr <charles.kerr@canonical.com>
Add skeleton test for IndicatorPowerDbusListener
2012-05-26 Charles Kerr <charles.kerr@canonical.com>
add coverage for charging with >1 minute but <1 hour left
2012-05-26 Charles Kerr <charles.kerr@canonical.com>
add coverage for DBusListener get_property()
2012-05-26 Charles Kerr <charles.kerr@canonical.com>
try adding LCOV_EXCL_{START,STOP} for unreachable conditions (glib looking for subclasses of IndicatorPowerDevice; unreachables in G_DEFINE_TYPE)
2012-05-26 Charles Kerr <charles.kerr@canonical.com>
call g_object_run_dispose() in a standalone test to get coverage on the NULL / non-NULL branches of dispose()'s g_clear_pointer() calls
2012-05-26 Charles Kerr <charles.kerr@canonical.com>
nope, LCOV_EXCL_LINE doesn't work on macros
2012-05-26 Charles Kerr <charles.kerr@canonical.com>
try adding LCOV_EXCL_LINE for unreachable conditions (glib looking for subclasses of IndicatorPowerDevice; unreachables in G_DEFINE_TYPE)
2012-05-26 Charles Kerr <charles.kerr@canonical.com>
reuse the same cancellable across multiple non-concurrent dbus calls
2012-05-26 Charles Kerr <charles.kerr@canonical.com>
avoid a cyclical refcount dependency between IndicatorPower and its DBusListener
2012-05-26 Charles Kerr <charles.kerr@canonical.com>
extract-method to simplify testing the accessible text
2012-05-26 Charles Kerr <charles.kerr@canonical.com>
separate the dbus org.gnome.SettingsDaemon.Power logic into a separate class
2012-05-26 Charles Kerr <charles.kerr@canonical.com>
add coverage for various charging/discharging/charged states
2012-05-26 Charles Kerr <charles.kerr@canonical.com>
first draft of adding tests for a discharging battery
2012-05-25 Charles Kerr <charles.kerr@canonical.com>
make indicator_power_set_devices() safe for passing in the same devices more than once
2012-05-25 Charles Kerr <charles.kerr@canonical.com>
fix negated logic in menu_add_device() introduced in r160
2012-05-25 Charles Kerr <charles.kerr@canonical.com>
indicator_power_set_devices() should fail gracefully when no devices are available
2012-05-25 Charles Kerr <charles.kerr@canonical.com>
make Jenkins happy
2012-05-25 Charles Kerr <charles.kerr@canonical.com>
modify IndicatorPower to use IndicatorPowerDevices internally
2012-05-25 Charles Kerr <charles.kerr@canonical.com>
put IndicatorPower's fields back inside a priv struct
2012-05-24 Charles Kerr <charles.kerr@canonical.com>
ah, c++ is too smart for the last commit's implicit conversion.
2012-05-24 Charles Kerr <charles.kerr@canonical.com>
test passing bad non-NULL pointers to Device's accessors
2012-05-24 Charles Kerr <charles.kerr@canonical.com>
add unit tests confirming that the device accessor functions won't crash when you pass NULL for the device
2012-05-24 Charles Kerr <charles.kerr@canonical.com>
remove the 'default' clause from get_property() and set_property().
Coverage testing isn't reaching them... glib is weeding out these invalid property keys before the device.c functions are ever reached. Nevertheless, leaving out a 'default' clause in a switch statement feels very unnatural to me. *twitch* *twitch*
2012-05-24 Charles Kerr <charles.kerr@canonical.com>
remove some unnecessary type compatibilty tests... g_object_get_property() does these tests for us
2012-05-24 Charles Kerr <charles.kerr@canonical.com>
remove the tests that attempted to exercise the code removed in r151
2012-05-24 Charles Kerr <charles.kerr@canonical.com>
don't include the unit tests' code in coverage metrics
2012-05-24 Charles Kerr <charles.kerr@canonical.com>
remove some unnecessary type compatibilty tests... g_object_set_property() does these tests for us
2012-05-24 Charles Kerr <charles.kerr@canonical.com>
add unit tests for getting/setting device properties
2012-05-24 Charles Kerr <charles.kerr@canonical.com>
first draft of getting GSettings working in the unit tests before the schema is installed.
2012-05-24 Charles Kerr <charles.kerr@canonical.com>
remove the g_clear_pointer() calls s.t. things will build and run on alesage's Jenkins setup running Precise
2012-05-24 Charles Kerr <charles.kerr@canonical.com>
remove the g_clear_pointer() calls s.t. things will build and run on alesage's Jenkins setup running Precise
2012-05-24 Charles Kerr <charles.kerr@canonical.com>
add test-indicator.cc
2012-05-24 Charles Kerr <charles.kerr@canonical.com>
add a 'hello world' test for instantiating IndicatorPower
2012-05-24 Charles Kerr <charles.kerr@canonical.com>
add private container struct IndicatorPowerDevice
2012-05-23 Charles Kerr <charles.kerr@canonical.com>
replace 'Power Settings...' with 'Power Settings…'
2012-05-23 Charles Kerr <charles.kerr@canonical.com>
move libpower's automake rules into src/
2012-04-26 Charles Kerr <charles.kerr@canonical.com>
fix a handful of string and GVariant leaks in indicator-power.
2012-04-15 Charles Kerr <charles.kerr@canonical.com>
tweak: in put_primary_device(), peek at the variant's strings instead of dup'ing them
2012-04-15 Charles Kerr <charles.kerr@canonical.com>
sync with lp:indicator-power
2012-04-15 Charles Kerr <charles.kerr@canonical.com>
fix leaked strings in menu_add_device when (kind == UP_DEVICE_KIND_LINE_POWER)
2012-03-17 Charles Kerr <charles.kerr@canonical.com>
Fix memory leaks in get_primary_device().
1. All the calls to g_variant_get_child_value() were leaked. Fixed by changing the use to g_variant_get_child() and keeping index values of the interesting children instead of pointers to them.
2. There were several paths where the local string "object_path" and "device_icon" were leaked. (For example, any non-battery entry given to us by upower). Fixed by making these const strings and peeking them from the variant with "&s" instead of "s".
2012-03-17 Charles Kerr <charles.kerr@canonical.com>
Fix variant leak in count_batteries() -- the returned value of g_variant_get_child_value() needs to be freed with g_variant_unref() when we're done with it.
2012-03-17 Charles Kerr <charles.kerr@canonical.com>
fix variant leaks in menu_add_devices()
2012-04-11 Charles Kerr <charles.kerr@canonical.com>
2.0
2012-04-10 Charles Kerr <charles.kerr@canonical.com>
merge lp:~allanlesage/indicator-power/TDD to improve our gcov fules in autotools
2012-03-27 Allan LeSage <allanlesage@gmail.com>
Pedantic name change for gcovr xml results.
2012-03-27 Allan LeSage <allanlesage@gmail.com>
Added gcov coverage tooling.
2012-04-09 Charles Kerr <charles.kerr@canonical.com>
use atk_object_set_name(foo,bar)" instead of g_object_set(foo,"accessible-name",bar,NULL)"
2012-04-09 Charles Kerr <charles.kerr@canonical.com>
leak fix 3 of 3: don't leak the GIcons returned by get_device_icon()
2012-04-09 Charles Kerr <charles.kerr@canonical.com>
leak fix 2 of 3: fix leaky fallback GIcon in get_device_icon()
2012-04-09 Charles Kerr <charles.kerr@canonical.com>
leak fix 1 of 3: don't leak object_path and device_icon if kind == UP_DEVICE_KIND_LINE_POWER
2012-04-09 Charles Kerr <charles.kerr@canonical.com>
if possible, set the device menuitems' accessible names.
2012-03-21 Charles Kerr <charles.kerr@canonical.com>
1.93
2012-03-17 Charles Kerr <charles.kerr@canonical.com>
merge lp:~kelemeng/indicator-power/bug957542 to fix extracting translatable strings from ipower (Bug #957542)
2012-03-17 Gabor Kelemen <kelemeng@ubuntu.com>
Add g_dngettext to the list of known keywords. LP: #957542
2012-03-14 Charles Kerr <charles.kerr@canonical.com>
1.91
2012-02-23 Ted Gould <ted@gould.cx>
1.91
2012-02-22 Ted Gould <ted@gould.cx>
Fix accessible descriptions
2012-02-22 Charles Kerr <charles.kerr@canonical.com>
when a new entry is added, ensure that its accessible_string is properly set
2012-02-22 Charles Kerr <charles.kerr@canonical.com>
fix trivial indentation error
2012-02-22 Charles Kerr <charles.kerr@canonical.com>
fix trivial misspelling
2012-02-22 Charles Kerr <charles.kerr@canonical.com>
fix set_accessible_desc() to update the entries' accessible_desc fields and emit the accessible-desc-changed signal
2012-02-17 Charles Kerr <charles.kerr@canonical.com>
Listen for the "g-properties-changed" signal instead of the "g-signal" signal from its GDBusProxy to fix bug #933466.
2012-02-16 Charles Kerr <charles.kerr@canonical.com>
register for g-properties-changed rather than g-signal
2012-02-14 Ted Gould <ted@gould.cx>
1.90
2012-02-14 Ted Gould <ted@gould.cx>
Fixing distcheck
2012-02-14 Ted Gould <ted@gould.cx>
Make data have it's own makefile so the GSettings rules work properly on distcheck
2012-02-14 Ted Gould <ted@gould.cx>
Style and performance fixes
2012-02-14 Javier Jardón <javier.jardon@codethink.co.uk>
Use G_GNUC_CONST for indicator_power_get_type() to improve performance
2012-02-14 Javier Jardón <javier.jardon@codethink.co.uk>
Code style fixes
2012-02-13 Charles Kerr <charles.kerr@canonical.com>
add icon-policy from branch lp:~charlesk/indicator-power/icon-policy
2012-02-13 Charles Kerr <charles.kerr@canonical.com>
ensure that we don't have a reference to the proxy or proxy_cancel fields in indicator_power_dispose().
2012-02-13 Charles Kerr <charles.kerr@canonical.com>
move POWER_INDICATOR_ICON_POLICY_* enum to the top of the file
2012-02-13 Charles Kerr <charles.kerr@canonical.com>
remove unncessary private field 'visible'
2012-02-13 Charles Kerr <charles.kerr@canonical.com>
consistent use of ICON_POLICY_KEY
2012-02-13 Charles Kerr <charles.kerr@canonical.com>
remove unnecessary G_OBJECT() cast
2012-02-13 Charles Kerr <charles.kerr@canonical.com>
make prototypes for update_visibility() and should_be_visible() align with the neighboring forward declarations
2012-02-01 Charles Kerr <charles.kerr@canonical.com>
add support for icon-policy setting
2012-02-01 Charles Kerr <charles.kerr@canonical.com>
create the menu at init time s.t. we don't have to keep checking to see if it exists
2012-02-01 Charles Kerr <charles.kerr@canonical.com>
use g_settings_bind() for the show-time checkbox
2012-02-01 Charles Kerr <charles.kerr@canonical.com>
better error reporting if g_spawn_command_line_async() fails
2012-02-01 Charles Kerr <charles.kerr@canonical.com>
remove redundant #include of glib.h
2012-02-01 Charles Kerr <charles.kerr@canonical.com>
use g_clear_object() on the proxy_cancel field
2012-02-01 Charles Kerr <charles.kerr@canonical.com>
remove unnecessary Priv struct -- the =entire class= is private
2012-02-01 Charles Kerr <charles.kerr@canonical.com>
remove unused struct names
2012-02-01 Charles Kerr <charles.kerr@canonical.com>
group the indicator_power lifecycle funcs together
2012-02-01 Charles Kerr <charles.kerr@canonical.com>
unref+clear Priv's variant fields in _dispose()
2012-02-01 Charles Kerr <charles.kerr@canonical.com>
don't leak priv->settings
2012-02-01 Charles Kerr <charles.kerr@canonical.com>
don't leak priv->accessible_desc
2012-02-01 Charles Kerr <charles.kerr@canonical.com>
remove redundant prototypes
2012-02-10 Ted Gould <ted@gould.cx>
Support building coverage targets
2011-12-06 Allan LeSage <allanlesage@gmail.com>
Added coverage reporting via gcov config and targets.
2011-11-30 Marco Trevisan (Treviño) <mail@3v1n0.net>
Add name-hint.
Using the defined PACKAGE_NAME value.
2011-11-08 Marco Trevisan (Treviño) <mail@3v1n0.net>
Add name-hint.
Using the defined PACKAGE_NAME value.
2011-10-13 Javier Jardón <javier.jardon@codethink.co.uk>
0.10
2011-10-13 Javier Jardón <javier.jardon@codethink.co.uk>
Do not hardcode icon percentage when discharging
2011-10-13 Javier Jardón <javier.jardon@codethink.co.uk>
Add support for old name icons
2011-10-13 Javier Jardón <javier.jardon@codethink.co.uk>
Fix icon creation for UP_DEVICE_STATE_CHARGING state
2011-10-04 Javier Jardón <javier.jardon@codethink.co.uk>
Only show a red icon when we have less than 30 minutes of battery remainig
Fixes https://bugs.launchpad.net/indicator-power/+bug/743823
2011-10-03 Javier Jardón <javier.jardon@codethink.co.uk>
Use battery-with-a-plug when the batttery is fully charged but still on AC
Fixes https://bugs.launchpad.net/indicator-power/+bug/865342
2011-10-03 Javier Jardón <javier.jardon@codethink.co.uk>
Show non present batteries in the menu
2011-10-02 Javier Jardón <javier.jardon@codethink.co.uk>
Add a workaround to fix the case when we get a empty bay as a real battery
2011-09-23 Ken VanDine <ken.vandine@canonical.com>
Fix POTFILES.in to reflect new gsettings schema filename
2011-09-23 Ken VanDine <ken.vandine@canonical.com>
fixed filename for gsettings schema
2011-09-23 Javier Jardón <javier.jardon@codethink.co.uk>
0.9
2011-09-21 Javier Jardón <javier.jardon@codethink.co.uk>
Do not activate g-s-d, but just watch dbus for g-s-d to appear
Fixes https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/854717
2011-09-14 Javier Jardón <javier.jardon@codethink.co.uk>
Do not show (charged) in menu title when fully charged
Fixes https://bugs.launchpad.net/ubuntu/+source/indicator-power/+bug/850011
2011-09-12 Javier Jardón <javier.jardon@codethink.co.uk>
0.8
2011-09-12 Javier Jardón <javier.jardon@codethink.co.uk>
Fix a gap in the indicators region when the power indicator is not show
This fixes https://bugs.launchpad.net/indicator-power/+bug/842188
2011-09-12 Javier Jardón <javier.jardon@codethink.co.uk>
Use the same icon for all charge levels if we are in the charging status
From the designers (see bug comments):
"I think the shading inside the battery when charging is obscuring the
lightning bolt, and also giving the icon a visual style that is obviously
different from the text and discourages "reading" it together with the text.
So, I suggest leaving the brackets in place, but removing the shading from
the icon.
Fixes https://bugs.launchpad.net/indicator-power/+bug/824629
2011-09-11 Gabor Kelemen <kelemeng@gnome.hu>
Use correct dgettext and g_dngettext calls. LP: #846895
2011-09-11 Gabor Kelemen <kelemeng@gnome.hu>
Use correct dgettext and g_dngettext calls. LP: #846895
2011-09-08 Javier Jardón <javier.jardon@codethink.co.uk>
Handle the case with broken batteries
The remining time is not reported with is more than 100h. This generally
means that our battery is broken (never reach a fully charged status)
2011-09-07 Javier Jardón <javier.jardon@codethink.co.uk>
indicator-power.c: Add padding between the icon and the text in the menu items
2011-08-25 Javier Jardón <javier.jardon@codethink.co.uk>
Use consistent location for gsettings schema
Use the same location as indicator-datetime
2011-08-24 Javier Jardón <javier.jardon@codethink.co.uk>
Fix a memory leak
Fixes https://bugs.launchpad.net/ubuntu/+source/indicator-power/+bug/779185
2011-08-23 Javier Jardón <javier.jardon@codethink.co.uk>
Makefile.am: fix typo to include .gschema.xml.in to the dist
2011-08-23 Javier Jardón <javier.jardon@codethink.co.uk>
Fix typo in the gsettings schema: show_time -> show-time
2011-08-23 Javier Jardón <javier.jardon@codethink.co.uk>
Release 0.7
2011-08-23 Javier Jardón <javier.jardon@codethink.co.uk>
Makefile.am: some autotools fixes
2011-08-22 Javier Jardón <javier.jardon@codethink.co.uk>
Add gsettings schema to the translatable files
2011-08-22 Javier Jardón <javier.jardon@codethink.co.uk>
Fix typo in the gsettings schema: show_time -> show-time
2011-08-22 Javier Jardón <javier.jardon@codethink.co.uk>
Use gsettings to store the status of "Show time in Menu Bar" option
Fixes https://bugs.launchpad.net/indicator-power/+bug/829853
2011-08-22 Javier Jardón <javier.jardon@codethink.co.uk>
Follow standard alignment of icons in menus
Fixes https://bugs.launchpad.net/ubuntu/+source/indicator-power/+bug/829697
2011-08-22 Javier Jardón <javier.jardon@codethink.co.uk>
Do not use a space before an ellipsis at the end of a string.
2011-08-12 Javier Jardón <javier.jardon@codethink.co.uk>
Do not show the default icon by default
Show the icon can cause problems in machines with no power
devices as the icon will not be updated
2011-08-12 Javier Jardón <javier.jardon@codethink.co.uk>
Free memory in the correct place
2011-08-12 Javier Jardón <javier.jardon@codethink.co.uk>
Release 0.6
2011-08-12 Javier Jardón <javier.jardon@codethink.co.uk>
Show time left to use without brackets, time left to charge with brackets.
Fixes bug http://bugs.launchpad.net/indicator-power/+bug/824629
2011-08-11 Javier Jardón <javier.jardon@codethink.co.uk>
Fix some memory leaks
2011-08-11 Michael Terry <michael.terry@canonical.com>
Don't show settings links when used in a greeter
2011-08-03 Michael Terry <michael.terry@canonical.com>
don't show settings links when used in a greeter
2011-08-11 Javier Jardón <javier.jardon@codethink.co.uk>
Use a string when the energy source is not present
Use "not present" instead "0%"
2011-08-11 Javier Jardón <javier.jardon@codethink.co.uk>
Only batteries can be primary devices
So only batteries status icons are allowed in the menu title
2011-08-11 Javier Jardón <javier.jardon@codethink.co.uk>
Fix some memory leaks
2011-08-03 Javier Jardón <javier.jardon@codethink.co.uk>
Release 0.5
2011-08-03 Javier Jardón <javier.jardon@codethink.co.uk>
Do not support the gnome-power-manager dbus interface anymore
The interface was removed upstream and moved to gnome-settings-daemon
2011-08-03 Ken VanDine <ken.vandine@canonical.com>
Fixed typos on checking for GSD and set the HAVE_GSD defines at build time
2011-07-28 Ken VanDine <ken.vandine@canonical.com>
fixed a syntax error on checking for GSD and set the HAVE_GSD defines at build time
2011-08-03 Javier Jardón <javier.jardon@codethink.co.uk>
configure.ac: Set GETTEXT_PACKAGE correctly to generate the expect template
2011-08-01 Ken VanDine <ken.vandine@canonical.com>
Set GETTEXT_PACKAGE to generate the expect template
2011-07-18 Javier Jardón <javier.jardon@codethink.co.uk>
Do not draw a separator between the configuration options in the menu
2011-07-18 Javier Jardón <javier.jardon@codethink.co.uk>
Use the new D-Bus interface if gnome-settings-daemon is new enough
Prepare the indicator-power about the changes upstream, where the code from
gnome-power-manager is being moved to gnome-settings-daemon
2011-07-15 Javier Jardón <javier.jardon@codethink.co.uk>
Always select a device, doesnt matter Its charging/discharging or not
Fixes https://bugs.launchpad.net/ubuntu/+source/indicator-power/+bug/810872
2011-07-15 Javier Jardón <javier.jardon@codethink.co.uk>
Makefile.am: Pass upower _FLAGS and _LIBS
2011-07-14 Javier Jardón <javier.jardon@codethink.co.uk>
Do not show the device name in the menu title
2011-07-14 Javier Jardón <javier.jardon@codethink.co.uk>
Release 0.3
2011-07-14 Javier Jardón <javier.jardon@codethink.co.uk>
Show "X (charged)" if it is fully charged and not discharging
2011-07-14 Javier Jardón <javier.jardon@codethink.co.uk>
Only show the remaining time if it is discharging with less than 12 hours left
2011-07-14 Javier Jardón <javier.jardon@codethink.co.uk>
Refine the text of the items in the menu to follow the specification
- "X (H:MM to charge)" if it is charging, with the accessible name
"X: MM minutes to charge" or "X: H hours MM minutes to charge"
- "X (H:MM left)" if it is discharging with less than 12 hours left,x
with the accessible name "X: MM minutes left" or "X: H hours MM minutes left".
2011-07-14 Michael Terry <michael.terry@canonical.com>
Draw option checkbox as check, not radio
2011-07-13 Michael Terry <michael.terry@canonical.com>
draw option checkbox as check, not radio
2011-07-14 Javier Jardón <javier.jardon@codethink.co.uk>
Show the apropiate icon depending of the status of the devices
Follow https://wiki.ubuntu.com/BatteryStatusMenu :
- If anything is discharging, the menu title should represent the thing
that is estimated to lose power first.
- If no devices are discharging, the menu title should represent the device
that is estimated to take longest to charge.
2011-07-13 Javier Jardón <javier.jardon@codethink.co.uk>
Create new function to store the logic to put the primary device
2011-07-08 Javier Jardón <javier.jardon@codethink.co.uk>
configure.ac: Add support for the new indicator3-0.4
2011-07-08 Javier Jardón <javier.jardon@codethink.co.uk>
configure.ac: Remove dbus service stuff
We do not need it anymore
2011-07-07 ken.vandine@canonical.com
Packaging fixes
- Include creating .tar.gz dists as well, we still use these for packaging
- Added COPYING file
- Removed cruft, we don't include a service
2011-07-07 Ken VanDine <ken.vandine@canonical.com>
include creating .tar.gz dists as well, we still use these for packaging
2011-07-07 Ken VanDine <ken.vandine@canonical.com>
Added COPYING file
2011-07-07 Ken VanDine <ken.vandine@canonical.com>
Removed cruft, we don't include a service
2011-07-07 Javier Jardón <javier.jardon@codethink.co.uk>
Do not use indicator_image_helper()
In GTK3 it can support fallbacks in GtkImage
2011-07-07 Javier Jardón <javier.jardon@codethink.co.uk>
Add support for multiple devices in the menu
2011-07-07 Javier Jardón <javier.jardon@codethink.co.uk>
configure.ac: We only support GTK+3
2011-07-07 Javier Jardón <javier.jardon@codethink.co.uk>
Get all the available devices instead the primary one
Get all the devices with the "GetDevices" dbus call.
Do not use "GetPrimaryDevice" as this is really a private api for the
communication between gpm and gnome-shell
Also, we avoid a bug in the "GetPrimaryDevice" interface about no power device
is detected when AC power is connected to the laptop.
2011-07-06 Javier Jardon <javier.jardon@codethink.co.uk>
Use the 'missing' icon instead the 'empty' icon by default
2011-07-06 Ted Gould <ted@gould.cx>
Little things to make distcheck pass.
2011-07-05 Ted Gould <ted@gould.cx>
Getting missing out of build-aux
2011-07-05 Ted Gould <ted@gould.cx>
Dropping missing because it's missing
2011-07-05 Ted Gould <ted@gould.cx>
Putting in Dummy files for the build scripts
2011-07-05 Ted Gould <ted@gould.cx>
Fixing a cut-and-paste error on POTFILES.in
2011-07-05 Javier Jardon <javier.jardon@codethink.co.uk>
Always show 2 digits for the minutes
2011-07-05 Javier Jardon <javier.jardon@codethink.co.uk>
Fix typo
2011-07-05 Javier Jardon <javier.jardon@codethink.co.uk>
Use a bigger icon for the menu items
2011-07-05 Javier Jardon <javier.jardon@codethink.co.uk>
Use the correct string for the menu item icon
2011-07-05 Javier Jardon <javier.jardon@codethink.co.uk>
Do not create a new GtkMenu instance with every change
But remove the children and rebuild the menu again so Its up-to-date
2011-07-05 Javier Jardon <javier.jardon@codethink.co.uk>
Do not use the notify:visible signal to update the menu
2011-07-05 Javier Jardon <javier.jardon@codethink.co.uk>
Add po/Makevars file
2011-07-05 Javier Jardon <javier.jardon@codethink.co.uk>
Add translatable files to POTFILES.in
2011-07-05 Javier Jardón <javier.jardon@codethink.co.uk>
Remove debug output
2011-07-05 Javier Jardón <javier.jardon@codethink.co.uk>
Store the current device in the private structure
2011-07-05 Javier Jardón <javier.jardon@codethink.co.uk>
notify signal
2011-07-04 Javier Jardón <javier.jardon@codethink.co.uk>
Add real info in the menu item
2011-07-04 Javier Jardón <javier.jardon@codethink.co.uk>
Rebuild menu when there is a change in the DBUS interface
2011-07-04 Javier Jardón <javier.jardon@codethink.co.uk>
Move callbacks to the beginning of the file
2011-07-04 Javier Jardón <javier.jardon@codethink.co.uk>
Construct the time details in a separate function
2011-07-04 Javier Jardón <javier.jardon@codethink.co.uk>
Build menu dynamically
2011-07-01 Javier Jardón <javier.jardon@codethink.co.uk>
Bump version to 0.1
2011-07-01 Javier Jardón <javier.jardon@codethink.co.uk>
configure.ac: advertise if this is a local build
2011-07-01 Javier Jardón <javier.jardon@codethink.co.uk>
configure.ac: Remove the GTK+2 support
We have GTK+3 in oneiric and we use the gnome-power-manager 3 dbus
interface anyway
2011-07-01 Javier Jardón <javier.jardon@codethink.co.uk>
configure.ac: Remove not used ido dependency
2011-07-01 Javier Jardón <javier.jardon@codethink.co.uk>
Add some more kind of devices
Bump upower required version to 0.9.5 because this
2011-07-01 Javier Jardón <javier.jardon@codethink.co.uk>
Do not show the device name in the menu title
2011-07-01 Javier Jardón <javier.jardon@codethink.co.uk>
Activate the use of icons in the menu
2011-07-01 Javier Jardón <javier.jardon@codethink.co.uk>
Use "Battery" instead "Laptop Battery"
2011-07-01 Javier Jardón <javier.jardon@codethink.co.uk>
Return the correct accessible description
2011-07-01 Javier Jardón <javier.jardon@codethink.co.uk>
Use the short time string in the label
2011-07-01 Javier Jardón <javier.jardon@codethink.co.uk>
Get also a short time string
So we have:
1:45 for the label
1 hour 45 minutes for the detailed description
2011-07-01 Javier Jardón <javier.jardon@codethink.co.uk>
Add device name to the label
2011-06-30 Javier Jardón <javier.jardon@codethink.co.uk>
Show the real information about the remaining charge time
2011-06-30 Javier Jardón <javier.jardon@codethink.co.uk>
Show the remaining time in the status icon depending of the check menu item status
2011-06-30 Javier Jardón <javier.jardon@codethink.co.uk>
Remove "Icon Only" option
We always show a icon by default
2011-06-30 Javier Jardón <javier.jardon@codethink.co.uk>
gnome-power-preferences has been moved to gnome-control-center
So call 'gnome-control-center power' instead
2011-06-30 Javier Jardón <javier.jardon@codethink.co.uk>
Specify what icon we want to show
Seems that indicator_image_helper_update() is not smarter enough
to handle the string retrieved from the g-p-m interface
2011-06-30 Javier Jardón <javier.jardon@codethink.co.uk>
Update the icon, not create a new one
2011-06-30 Javier Jardón <javier.jardon@codethink.co.uk>
Fix default icon
2011-06-30 Javier Jardón <javier.jardon@codethink.co.uk>
Use device_icon name consistently
2011-06-30 Javier Jardón <javier.jardon@codethink.co.uk>
Change the status icon when the charge changes
2011-06-29 Javier Jardón <javier.jardon@codethink.co.uk>
Make the check menu items look like a radio menu item.
2011-06-29 Javier Jardón <javier.jardon@codethink.co.uk>
Add options to the indicator menu
As discussed:
- Icon only
- Time remaining
2011-06-29 Javier Jardón <javier.jardon@codethink.co.uk>
Show the power statistics when click on the device menu item
2011-06-29 Javier Jardón <javier.jardon@codethink.co.uk>
Populate menu: Add preferences menu item
2011-06-28 Javier Jardón <javier.jardon@codethink.co.uk>
Fix typo
2011-06-28 Javier Jardón <javier.jardon@codethink.co.uk>
Process the data received from the gnome-power-manager service
2011-06-28 Javier Jardón <javier.jardon@codethink.co.uk>
indicator-power: connect to the gnome-power-manager service directly
2011-06-28 Javier Jardón <javier.jardon@codethink.co.uk>
Remove dbus interface in the client side
We are not going to use a power service
2011-06-28 Javier Jardón <javier.jardon@codethink.co.uk>
Remove libido dependency
We do not need this for now
2011-06-28 Javier Jardón <javier.jardon@codethink.co.uk>
Remove power service for now
We are going to use gnome-settings-daemon directly
2011-06-28 Javier Jardón <javier.jardon@codethink.co.uk>
indicator-power: Create the proxy for the service
2011-06-27 Javier Jardón <javier.jardon@codethink.co.uk>
configure.ac: Remove vala dependency
2011-06-27 Javier Jardón <javier.jardon@codethink.co.uk>
Change copyright to Canonical Ltd
2011-06-27 Javier Jardón <javier.jardon@codethink.co.uk>
Implement power dbus service interface
2011-06-27 Javier Jardón <javier.jardon@codethink.co.uk>
power-service: Add more items to the menu
2011-06-27 Javier Jardón <javier.jardon@codethink.co.uk>
power-service: No need for a global variable
2011-06-27 Javier Jardón <javier.jardon@codethink.co.uk>
Fix some typos
2011-06-27 Javier Jardón <javier.jardon@codethink.co.uk>
power-service: Add an item to the menu
2011-06-27 Javier Jardón <javier.jardon@codethink.co.uk>
Implement skeleton of power-service
2011-06-27 Javier Jardón <javier.jardon@codethink.co.uk>
Implement skeleton of indicator-power
2011-06-24 Javier Jardón <javier.jardon@codethink.co.uk>
Some build fixes
2011-06-24 Javier Jardón <javier.jardon@codethink.co.uk>
Initial commit
|