diff options
| author | Ted Gould <ted@gould.cx> | 2014-01-31 21:07:54 +0000 |
|---|---|---|
| committer | Tarmac <Unknown> | 2014-01-31 21:07:54 +0000 |
| commit | 8aaf9698048b5682e0117ca9c3769255a4a54bec (patch) | |
| tree | 79a9052693437d4362cca2b25cbc348035502891 /MERGE-REVIEW | |
| parent | cde2a24df9a618a9efc73cc1cf9d9696ab03002d (diff) | |
| parent | d6d828a97bb3e32883d3f86fc8e1cee9c90dabd1 (diff) | |
| download | ayatana-indicator-session-8aaf9698048b5682e0117ca9c3769255a4a54bec.tar.gz ayatana-indicator-session-8aaf9698048b5682e0117ca9c3769255a4a54bec.tar.bz2 ayatana-indicator-session-8aaf9698048b5682e0117ca9c3769255a4a54bec.zip | |
Adding acceptance tests and merge review policies.
Approved by PS Jenkins bot, Charles Kerr.
Diffstat (limited to 'MERGE-REVIEW')
| -rw-r--r-- | MERGE-REVIEW | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/MERGE-REVIEW b/MERGE-REVIEW new file mode 100644 index 0000000..7a7f11a --- /dev/null +++ b/MERGE-REVIEW @@ -0,0 +1,19 @@ + +This documents the expections that the project has on what both submitters +and reviewers should ensure that they've done for a merge into the project. + +== Submitter Responsibilities == + + * Ensure the project compiles and the test suite executes without error + * Ensure that non-obvious code has comments explaining it + * If the change works on specific profiles, please include those in the merge description. + +== Reviewer Responsibilities == + + * Did the Jenkins build compile? Pass? Run unit tests successfully? + * Are there appropriate tests to cover any new functionality? + * If the description says this effects the phone profile: + * Run tests indicator-session/unity8* + * If the description says this effects the desktop profile: + * Run tests indicator-session/unity7* + |