ayatana-indicator-sound/src/volume-warning.vala, branch 24.5.1 Ayatana Indicator Sound Applet https://cgit.arctica-project.org/ayatana-indicator-sound/atom?h=24.5.1 2023-11-28T18:42:23+00:00 src, tests: fix -Wint-to-pointer-cast and a chance of test crash 2023-11-28T18:42:23+00:00 Ratchanan Srirattanamet ratchanan@ubports.com 2023-11-28T17:42:50+00:00 urn:sha1:41c2b5c21de5a3774f0bbb54de3999eaccc7de70 Turns the constructor of `VolumeControl` and `VolumeWarning` from `internal` to `protected`. This makes Vala emits C declaration of constructors, which is required by the test's mocks extending these classes, in the external header. Without them, the mocks' C code would then consider them "implicitly declared", and will assume they return `int` instead of a pointer. If the returned address happened to be higher than `INT_MAX`, the code will consider the returned address negative and sign-extend it when casting to a pointer, corrupting it. As for "unprivating" these constructors, this is an internal static library anyway. No libraries or headers are installed from this package. This change is invisible from outside. Add us to the copyright header 2021-08-04T21:35:57+00:00 Robert Tari robert@tari.in 2021-03-10T00:03:00+00:00 urn:sha1:0552bb39d336d4e3b194a328300db6c0528e4201 Add us to the copyright header 2021-08-04T20:12:44+00:00 Robert Tari robert@tari.in 2021-03-10T00:03:00+00:00 urn:sha1:7013122c3d259e86ad5e31510290e01041794ec3 src/volume-warning.vala: Fix static member access 2021-08-04T19:57:11+00:00 Robert Tari robert@tari.in 2021-03-09T13:04:54+00:00 urn:sha1:1fbee35f494f6b0582c90357315e44492a2467ed src/volume-warning.vala: Remove the static modifier from constants 2021-08-04T19:57:11+00:00 Robert Tari robert@tari.in 2021-03-08T22:55:13+00:00 urn:sha1:41a2d5888d4d7a0c5a3bcb42577700c878bcb4da Whitespace fix 2021-08-04T19:42:10+00:00 Robert Tari robert@tari.in 2021-03-08T21:37:23+00:00 urn:sha1:89f303d468543d61b9a9404115b20fd9b0fbb0df Fix several 'Creation method of abstract class cannot be public.' Vala issues. 2019-12-02T18:47:11+00:00 Mike Gabriel mike.gabriel@das-netzwerkteam.de 2019-11-21T10:05:12+00:00 urn:sha1:7ceaa0539bd3ed9e541bea5369abfa7f6bc636f7 Fork from Ubuntu's indicator-sound. 2017-10-22T23:07:30+00:00 Mike Gabriel mike.gabriel@das-netzwerkteam.de 2017-10-22T23:07:30+00:00 urn:sha1:13525d7b0451f0a9ca7b73e83e2f374fbfb7c1bc Added a new signal in volumeWarning to notify when the user has pressed cancel. We use that to set the volume after pressing cancel, as sometimes setting the accounts service volume steps over the warning level 2016-04-15T09:55:49+00:00 Xavi Garcia Mena xavi.garcia.mena@canonical.com 2016-04-15T09:55:49+00:00 urn:sha1:cae62db5c6ad966fbc68f892c9723b010bcd774a Set warning volume to the maximum allowed when the user presses cancel 2016-03-01T09:41:41+00:00 Xavi Garcia Mena xavi.garcia.mena@canonical.com 2016-03-01T09:41:41+00:00 urn:sha1:f23ef0a3d5d2195d3174643bbd9df0bbe3b59ad2