Grabbing greeter branch as it has some AS stuff we want

8 files changed, 105 insertions, 42 deletions

diff --git a/data/com.canonical.indicator.sound.gschema.xml b/data/com.canonical.indicator.sound.gschema.xml
index c34dfd6..102a1db 100644
--- a/data/com.canonical.indicator.sound.gschema.xml
+++ b/data/com.canonical.indicator.sound.gschema.xml
@@ -48,14 +48,5 @@
         Whether or not to show the sound indicator in the menu bar.
       </description>
     </key>
-    <key name="greeter-export" type="b">
-      <default>true</default>
-      <summary>Whether or not to export the currently playing song to the greeter.</summary>
-      <description>
-        If enabled the sound indicator will export the current player and
-        song to the greeter so that it can be shown if the user is selected
-        and the sound menu is shown.
-      </description>
-    </key>
   </schema>
 </schemalist>
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 98bc7c4..00d53ae 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -103,12 +103,16 @@ vala_add(indicator-sound-service
     media-player
     mpris2-interfaces
     accounts-service-sound-settings
+    accounts-service-privacy-settings
     greeter-broadcast
 )
 vala_add(indicator-sound-service
   accounts-service-sound-settings.vala
 )
 vala_add(indicator-sound-service
+  accounts-service-privacy-settings.vala
+)
+vala_add(indicator-sound-service
   greeter-broadcast.vala
 )
 
diff --git a/src/accounts-service-privacy-settings.vala b/src/accounts-service-privacy-settings.vala
new file mode 100644
index 0000000..ef5c309
--- /dev/null
+++ b/src/accounts-service-privacy-settings.vala
@@ -0,0 +1,26 @@
+/*
+ * Copyright 2014 © Canonical Ltd.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 3.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ *
+ * Authors:
+ *      Ted Gould <ted@canonical.com>
+ */
+
+[DBus (name = "com.ubuntu.touch.AccountsService.SecurityPrivacy")]
+public interface AccountsServicePrivacySettings : Object {
+	// properties 
+	public abstract bool stats_welcome_screen {owned get; set;}
+	public abstract bool messages_welcome_screen {owned get; set;}
+}
+
diff --git a/src/accounts-service-user.vala b/src/accounts-service-user.vala
index 04c38cc..2e59db3 100644
--- a/src/accounts-service-user.vala
+++ b/src/accounts-service-user.vala
@@ -21,10 +21,13 @@ public class AccountsServiceUser : Object {
 	Act.UserManager accounts_manager = Act.UserManager.get_default();
 	Act.User? user = null;
 	AccountsServiceSoundSettings? proxy = null;
+	AccountsServicePrivacySettings? privacyproxy = null;
 	uint timer = 0;
 	MediaPlayer? _player = null;
 	GreeterBroadcast? greeter = null;
 
+	public bool showDataOnGreeter { get; set; }
+
 	public MediaPlayer? player {
 		set {
 			this._player = value;
@@ -124,7 +127,15 @@ public class AccountsServiceUser : Object {
 				user.get_object_path(),
 				DBusProxyFlags.GET_INVALIDATED_PROPERTIES,
 				null,
-				new_proxy);
+				new_sound_proxy);
+
+			Bus.get_proxy.begin<AccountsServicePrivacySettings> (
+				BusType.SYSTEM,
+				"org.freedesktop.Accounts",
+				user.get_object_path(),
+				DBusProxyFlags.GET_INVALIDATED_PROPERTIES,
+				null,
+				new_privacy_proxy);
 		}
 	}
 
@@ -138,7 +149,7 @@ public class AccountsServiceUser : Object {
 		}
 	}
 
-	void new_proxy (GLib.Object? obj, AsyncResult res) {
+	void new_sound_proxy (GLib.Object? obj, AsyncResult res) {
 		try {
 			this.proxy = Bus.get_proxy.end (res);
 			this.player = _player;
@@ -148,6 +159,25 @@ public class AccountsServiceUser : Object {
 		}
 	}
 
+	void new_privacy_proxy (GLib.Object? obj, AsyncResult res) {
+		try {
+			this.privacyproxy = Bus.get_proxy.end (res);
+
+			(this.privacyproxy as DBusProxy).g_properties_changed.connect((proxy, changed, invalid) => {
+				var welcomeval = changed.lookup_value("MessagesWelcomeScreen", new VariantType("b"));
+				if (welcomeval != null) {
+					debug("Messages on welcome screen changed");
+					this.showDataOnGreeter = welcomeval.get_boolean();
+				}
+			});
+
+			this.showDataOnGreeter = this.privacyproxy.messages_welcome_screen;
+		} catch (Error e) {
+			this.privacyproxy = null;
+			warning("Unable to get proxy to user privacy settings: %s", e.message);
+		}
+	}
+
 	void greeter_proxy_new (GLib.Object? obj, AsyncResult res) {
 		try {
 			this.greeter = Bus.get_proxy.end (res);
diff --git a/src/media-player-mpris.vala b/src/media-player-mpris.vala
index 25ddac4..bf25e21 100644
--- a/src/media-player-mpris.vala
+++ b/src/media-player-mpris.vala
@@ -283,7 +283,7 @@ public class MediaPlayerMpris: MediaPlayer {
 			this.fetch_playlists ();
 	}
 
-	void update_current_track (Variant metadata) {
+	void update_current_track (Variant? metadata) {
 		if (metadata != null) {
 			this.current_track = new Track (
 				sanitize_metadata_value (metadata.lookup_value ("xesam:artist", null)),
diff --git a/src/service.vala b/src/service.vala
index 4e02769..8287b7f 100644
--- a/src/service.vala
+++ b/src/service.vala
@@ -38,8 +38,8 @@ public class IndicatorSound.Service: Object {
 		this.actions.add_action (this.create_mic_volume_action ());
 
 		this.menus = new HashTable<string, SoundMenu> (str_hash, str_equal);
-		this.menus.insert ("desktop_greeter", new SoundMenu (null, SoundMenu.DisplayFlags.SHOW_MUTE | SoundMenu.DisplayFlags.HIDE_PLAYERS));
-		this.menus.insert ("phone_greeter", new SoundMenu (null, SoundMenu.DisplayFlags.HIDE_INACTIVE_PLAYERS));
+		this.menus.insert ("desktop_greeter", new SoundMenu (null, SoundMenu.DisplayFlags.SHOW_MUTE | SoundMenu.DisplayFlags.HIDE_PLAYERS | SoundMenu.DisplayFlags.GREETER_PLAYERS));
+		this.menus.insert ("phone_greeter", new SoundMenu (null, SoundMenu.DisplayFlags.HIDE_INACTIVE_PLAYERS | SoundMenu.DisplayFlags.GREETER_PLAYERS));
 		this.menus.insert ("desktop", new SoundMenu ("indicator.desktop-settings", SoundMenu.DisplayFlags.SHOW_MUTE));
 		this.menus.insert ("phone", new SoundMenu ("indicator.phone-settings", SoundMenu.DisplayFlags.HIDE_INACTIVE_PLAYERS));
 
@@ -47,9 +47,17 @@ public class IndicatorSound.Service: Object {
 			this.volume_control.bind_property ("active-mic", menu, "show-mic-volume", BindingFlags.SYNC_CREATE);
 		});
 
-		/* Setup handling for the greeter-export setting */
-		this.settings.changed["greeter-export"].connect( () => this.build_accountsservice() );
-		build_accountsservice();
+		/* If we're on the greeter, don't export */
+		if (GLib.Environment.get_user_name() != "lightdm") {
+			this.accounts_service = new AccountsServiceUser();
+
+			this.accounts_service.notify["showDataOnGreeter"].connect(() => {
+				this.export_to_accounts_service = this.accounts_service.showDataOnGreeter;
+				eventually_update_player_actions();
+			});
+
+			this.export_to_accounts_service = this.accounts_service.showDataOnGreeter;
+		}
 
 		this.sync_preferred_players ();
 		this.settings.changed["interested-media-players"].connect ( () => {
@@ -74,25 +82,8 @@ public class IndicatorSound.Service: Object {
 		}
 	}
 
-	void build_accountsservice () {
-		clear_acts_player();
-		this.accounts_service = null;
-
-		/* If we're not exporting, don't build anything */
-		if (!this.settings.get_boolean("greeter-export")) {
-			debug("Accounts service export disabled due to user setting");
-			return;
-		}
-
-		/* If we're on the greeter, don't export */
-		if (GLib.Environment.get_user_name() == "lightdm") {
-			debug("Accounts service export disabled due to being used on the greeter");
-			return;
-		}
-
-		this.accounts_service = new AccountsServiceUser();
-
-		this.eventually_update_player_actions();
+	bool greeter_show_track () {
+		return export_to_accounts_service;
 	}
 
 	void clear_acts_player () {
@@ -167,6 +158,7 @@ public class IndicatorSound.Service: Object {
 	Notify.Notification notification;
 	bool syncing_preferred_players = false;
 	AccountsServiceUser? accounts_service = null;
+	bool export_to_accounts_service = false;
 
 	/* Maximum volume as a scaling factor between the volume action's state and the value in
 	 * this.volume_control. See create_volume_action().
@@ -379,11 +371,11 @@ public class IndicatorSound.Service: Object {
 		this.loop.quit ();
 	}
 
-	Variant action_state_for_player (MediaPlayer player) {
+	Variant action_state_for_player (MediaPlayer player, bool show_track = true) {
 		var builder = new VariantBuilder (new VariantType ("a{sv}"));
 		builder.add ("{sv}", "running", new Variant ("b", player.is_running));
 		builder.add ("{sv}", "state", new Variant ("s", player.state));
-		if (player.current_track != null) {
+		if (player.current_track != null && show_track) {
 			builder.add ("{sv}", "title", new Variant ("s", player.current_track.title));
 			builder.add ("{sv}", "artist", new Variant ("s", player.current_track.artist));
 			builder.add ("{sv}", "album", new Variant ("s", player.current_track.album));
@@ -402,8 +394,14 @@ public class IndicatorSound.Service: Object {
 				action.set_enabled (player.can_raise);
 			}
 			
+			SimpleAction? greeter_action = this.actions.lookup_action (player.id + ".greeter") as SimpleAction;
+			if (greeter_action != null) {
+				greeter_action.set_state (this.action_state_for_player (player, greeter_show_track()));
+				greeter_action.set_enabled (player.can_raise);
+			}
+			
 			/* If we're playing then put that data in accounts service */
-			if (player.is_running && accounts_service != null) {
+			if (player.is_running && export_to_accounts_service && accounts_service != null) {
 				accounts_service.player = player;
 				clear_accounts_player = false;
 			}
@@ -446,6 +444,11 @@ public class IndicatorSound.Service: Object {
 		action.activate.connect ( () => { player.activate (); });
 		this.actions.add_action (action);
 
+		SimpleAction greeter_action = new SimpleAction.stateful (player.id + ".greeter", null, this.action_state_for_player (player, greeter_show_track()));
+		greeter_action.set_enabled (player.can_raise);
+		greeter_action.activate.connect ( () => { player.activate (); });
+		this.actions.add_action (greeter_action);
+
 		var play_action = new SimpleAction.stateful ("play." + player.id, null, player.state);
 		play_action.activate.connect ( () => player.play_pause () );
 		this.actions.add_action (play_action);
diff --git a/src/sound-menu.vala b/src/sound-menu.vala
index e37c4e9..f5e2627 100644
--- a/src/sound-menu.vala
+++ b/src/sound-menu.vala
@@ -23,7 +23,8 @@ public class SoundMenu: Object
 		NONE = 0,
 		SHOW_MUTE = 1,
 		HIDE_INACTIVE_PLAYERS = 2,
-		HIDE_PLAYERS = 4
+		HIDE_PLAYERS = 4,
+		GREETER_PLAYERS = 8
 	}
 
 	public SoundMenu (string? settings_action, DisplayFlags flags) {
@@ -59,6 +60,8 @@ public class SoundMenu: Object
 		this.hide_players = (flags & DisplayFlags.HIDE_PLAYERS) != 0;
 		this.hide_inactive = (flags & DisplayFlags.HIDE_INACTIVE_PLAYERS) != 0;
 		this.notify_handlers = new HashTable<MediaPlayer, ulong> (direct_hash, direct_equal);
+
+		this.greeter_players = (flags & DisplayFlags.GREETER_PLAYERS) != 0;
 	}
 
 	public void export (DBusConnection connection, string object_path) {
@@ -133,6 +136,7 @@ public class SoundMenu: Object
 	bool hide_inactive;
 	bool hide_players = false;
 	HashTable<MediaPlayer, ulong> notify_handlers;
+	bool greeter_players = false;
 
 	/* returns the position in this.menu of the section that's associated with @player */
 	int find_player_section (MediaPlayer player) {
@@ -166,7 +170,11 @@ public class SoundMenu: Object
 		if (icon == null)
 			icon = new ThemedIcon.with_default_fallbacks ("application-default-icon");
 
-		var player_item = new MenuItem (player.name, "indicator." + player.id);
+		var base_action = "indicator." + player.id;
+		if (this.greeter_players)
+			base_action += ".greeter";
+
+		var player_item = new MenuItem (player.name, base_action);
 		player_item.set_attribute ("x-canonical-type", "s", "com.canonical.unity.media-player");
 		if (icon != null)
 			player_item.set_attribute_value ("icon", icon.serialize ());
diff --git a/src/volume-control.vala b/src/volume-control.vala
index 2efa186..afcca15 100644
--- a/src/volume-control.vala
+++ b/src/volume-control.vala
@@ -327,7 +327,8 @@ public class VolumeControl : Object
 
 	bool set_volume_internal (double volume)
 	{
-		return_val_if_fail (context.get_state () == Context.State.READY, false);
+		if (context.get_state () != Context.State.READY)
+			return false;
 
 		if (_volume != volume) {
 			_volume = volume;