diff options
| author | Ted Gould <ted@gould.cx> | 2014-01-31 21:09:51 +0000 |
|---|---|---|
| committer | Tarmac <Unknown> | 2014-01-31 21:09:51 +0000 |
| commit | c06f1a5e6864c047a705a4b99188e0794688ec30 (patch) | |
| tree | 604911b969b45aef3612e3620632c255baa70611 /MERGE-REVIEW | |
| parent | 61c6ebe13c20c87711276541d29c20f39cf33ecf (diff) | |
| parent | 8174c565f1315fb007363a8956152c978553af7d (diff) | |
| download | ayatana-indicator-sound-c06f1a5e6864c047a705a4b99188e0794688ec30.tar.gz ayatana-indicator-sound-c06f1a5e6864c047a705a4b99188e0794688ec30.tar.bz2 ayatana-indicator-sound-c06f1a5e6864c047a705a4b99188e0794688ec30.zip | |
Adding acceptance tests and merge review policies.
Approved by Charles Kerr, PS Jenkins bot.
Diffstat (limited to 'MERGE-REVIEW')
| -rw-r--r-- | MERGE-REVIEW | 19 |
1 files changed, 19 insertions, 0 deletions
diff --git a/MERGE-REVIEW b/MERGE-REVIEW new file mode 100644 index 0000000..1b7ff95 --- /dev/null +++ b/MERGE-REVIEW @@ -0,0 +1,19 @@ + +This documents the expections that the project has on what both submitters +and reviewers should ensure that they've done for a merge into the project. + +== Submitter Responsibilities == + + * Ensure the project compiles and the test suite executes without error + * Ensure that non-obvious code has comments explaining it + * If the change works on specific profiles, please include those in the merge description. + +== Reviewer Responsibilities == + + * Did the Jenkins build compile? Pass? Run unit tests successfully? + * Are there appropriate tests to cover any new functionality? + * If the description says this effects the phone profile: + * Run tests indicator-sound/unity8* + * If the description says this effects the desktop profile: + * Run tests indicator-sound/unity7* + |