aboutsummaryrefslogtreecommitdiff
path: root/src/mpris2-controller.vala
diff options
context:
space:
mode:
authorKen VanDine <ken.vandine@canonical.com>2012-03-20 12:40:24 -0400
committerPackage Import Robot <package-import@ubuntu.com>2012-03-20 12:40:24 -0400
commit5ef25627db7821695c39e9ee125b20fbdc3312e6 (patch)
treef425c9177a38d3dae527fb00fc121c3d79e158b0 /src/mpris2-controller.vala
parent8d4403e2ddc138d5a329141dc577d64bf43f1756 (diff)
parent2f7ca45863f691c05b4dcae9d732c176cf4fdab0 (diff)
downloadayatana-indicator-sound-5ef25627db7821695c39e9ee125b20fbdc3312e6.tar.gz
ayatana-indicator-sound-5ef25627db7821695c39e9ee125b20fbdc3312e6.tar.bz2
ayatana-indicator-sound-5ef25627db7821695c39e9ee125b20fbdc3312e6.zip
* debian/patches/lp_945827.patch
- fix for a playlist crasher (LP: #945827)
Diffstat (limited to 'src/mpris2-controller.vala')
-rw-r--r--src/mpris2-controller.vala22
1 files changed, 19 insertions, 3 deletions
diff --git a/src/mpris2-controller.vala b/src/mpris2-controller.vala
index 0fa7b6c..9cd02c4 100644
--- a/src/mpris2-controller.vala
+++ b/src/mpris2-controller.vala
@@ -92,7 +92,7 @@ public class Mpris2Controller : GLib.Object
}
Variant? playlist_v = changed_properties.lookup("ActivePlaylist");
if ( playlist_v != null && this.owner.use_playlists == true ){
- Timeout.add (300, this.fetch_active_playlist);
+ Timeout.add (500, this.fetch_active_playlist);
}
Variant? playlist_count_v = changed_properties.lookup("PlaylistCount");
if ( playlist_count_v != null && this.owner.use_playlists == true ){
@@ -240,14 +240,30 @@ public class Mpris2Controller : GLib.Object
playlists_item.update(current_playlists);
}
else{
- warning(" Playlists are on but its returning no current_playlists" );
+ warning(" Playlists are on but %s is returning no current_playlists ?",
+ this.owner.app_info.get_name());
this.owner.use_playlists = false;
}
}
+ private bool validate_playlists_details()
+ {
+ if (this.playlists.ActivePlaylist.valid == false){
+ return false;
+ }
+ if (this.playlists.ActivePlaylist.details == null){
+ return false;
+ }
+ if (this.playlists.ActivePlaylist.details.path == null ||
+ this.playlists.ActivePlaylist.details.name == null){
+ return false;
+ }
+ return true;
+ }
+
private bool fetch_active_playlist()
{
- if (this.playlists.ActivePlaylist.valid == false){
+ if (this.validate_playlists_details() == false){
return false;
}
PlaylistsMenuitem playlists_item = this.owner.custom_items[PlayerController.widget_order.PLAYLISTS] as PlaylistsMenuitem;