aboutsummaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* VolumeControl: don't pass vala closures into libpulseLars Uebernickel2013-10-281-15/+29
|\ | | | | | | | | | | | | | | | | | | Libpulse's vala bindings don't specify that callbacks passed into some of its functions (e.g., get_server_info) can be called after the function returns. Vala thus frees closure data after these functions return. This can't easily be fixed in the bindings, because libpulse doesn't provide variants of these functions with destroy_notifies. This patch works around this problem by only passing non-closure functions into libpulse. Fixes: https://bugs.launchpad.net/bugs/1244386. Approved by Charles Kerr, PS Jenkins bot.
| * VolumeControl: don't pass vala closures into libpulseLars Uebernickel2013-10-261-15/+29
| | | | | | | | | | | | | | | | | | | | | | | | | | Libpulse's vala bindings don't specify that callbacks passed into some of its functions (e.g., get_server_info) can be called after the function returns. Vala thus frees closure data after these functions return. This can't easily be fixed in the bindings, because libpulse doesn't provide variants of these functions with destroy_notifies. This patch works around this problem by only passing non-closure functions into libpulse.
* | In Service's volume_changed() function, explicitly instantiate the GVariant ↵Charles Kerr2013-10-251-7/+7
|\ \ | | | | | | | | | | | | | | | to avoid leaking it. See the description in bug #1244468 for before & after C code and more information. Fixes: https://bugs.launchpad.net/bugs/1244468. Approved by Lars Uebernickel, PS Jenkins bot.
| * | fix similar variant leaksCharles Kerr2013-10-241-6/+6
| | |
| * | in Service's volume_changed(), explicitly instantiate the GVariant to avoid ↵Charles Kerr2013-10-241-1/+1
|/ / | | | | | | leaking it
* | Don't special case Unity sessions, that's not needed sinceSebastien Bacher2013-10-241-3/+1
|\ \ | | | | | | | | | | | | | | | | | | gnome-control-center is doing the right thing, the session name used was also wrong and couldn't work (lp: #1239545). Fixes: https://bugs.launchpad.net/bugs/1239545. Approved by Charles Kerr, PS Jenkins bot.
| * | Don't special case Unity sessions, that's not needed sinceSebastien Bacher2013-10-241-3/+1
|/ / | | | | | | | | | | gnome-control-center is doing the right thing, the session name used was also wrong and couldn't work (lp: #1239545)
* | Only display running players in the phone's sound menuLars Uebernickel2013-10-242-28/+62
|\ \ | | | | | | | | | | | | | | | The design says to only display the _one_ running player. This will have that effect, as there's only one player allowed to run at a time on the phone. Approved by PS Jenkins bot, Ted Gould.
| * | Only display running players in the phone's sound menuLars Uebernickel2013-10-102-25/+54
| | |
| * | Replace 'mute' boolean by a flag in the SoundMenu constructorLars Uebernickel2013-10-102-5/+10
| | | | | | | | | | | | | | | | | | This makes the code calling the constructor more readable and allows for extensibility.
* | | When we can't connect to pulse, wait a moment before retrying. Fixes: ↵Charles Kerr2013-10-241-1/+18
|\ \ \ | | | | | | | | | | | | | | | | | | | | https://bugs.launchpad.net/bugs/1244010. Approved by Lars Uebernickel, PS Jenkins bot.
| * | | when we fail to connect to pulse, wait a moment before retrying.Charles Kerr2013-10-231-1/+18
| | | |
* | | | Define "ubiquity" indicator profile, reusing the greeter object. (LP: ↵Dmitrijs Ledkovs2013-10-182-0/+10
|\ \ \ \ | |/ / / |/| | | | | | | | | | | | | | | #1241539). Fixes: https://bugs.launchpad.net/bugs/1241539. Approved by Lars Uebernickel, PS Jenkins bot.
| * | | Define "ubiquity" indicator profile, reusing the greeter object. (LP:Dmitrijs Ledkovs2013-10-182-0/+10
|/ / / | | | | | | | | | #1241539)
* | | Releasing 12.10.2+13.10.20131011-0ubuntu1 (revision 389 from ↵Automatic PS uploader2013-10-111-0/+11
|\ \ \ | | | | | | | | | | | | | | | | | | | | lp:indicator-sound). Approved by PS Jenkins bot.
| * | | Releasing 12.10.2+13.10.20131011-0ubuntu1, based on r389Automatic PS uploader2013-10-111-0/+11
|/ / /
* | | Allow activating the 'volume' actionLars Uebernickel2013-10-102-3/+10
|\ \ \ | |/ / |/| / | |/ | | | | It does the same as the 'scroll' action except showing a notification. Fixes: https://bugs.launchpad.net/bugs/1236292. Approved by Charles Kerr, PS Jenkins bot.
| * Give the volume menu item a target, because the 'volume' action now has a ↵Lars Uebernickel2013-10-101-1/+1
| | | | | | | | parameter
| * Allow activating the 'volume' actionLars Uebernickel2013-10-091-2/+9
|/ | | | | It does the same as the 'scroll' action except showing a notification.
* Releasing 12.10.2+13.10.20131004-0ubuntu1 (revision 387 from ↵Automatic PS uploader2013-10-041-0/+19
|\ | | | | | | | | | | lp:indicator-sound). Approved by PS Jenkins bot.
| * Releasing 12.10.2+13.10.20131004-0ubuntu1, based on r387Automatic PS uploader2013-10-041-0/+19
|/
* Add a desktop_greeter menu without settings.Ted Gould2013-10-023-4/+14
|\ | | | | | | Approved by PS Jenkins bot, Lars Uebernickel.
| * Make sure to set the initial value of settings shownTed Gould2013-10-021-1/+1
| |
| * Changing the indicator fileTed Gould2013-10-021-1/+1
| |
| * Making the settings action optionalTed Gould2013-10-022-3/+13
|/
* Fix translation supportPete Woods2013-10-011-1/+1
|\ | | | | | | | | | | dh_translations doesn't perform variable substitution when parsing the CMakeLists.txt file. Fixes: https://bugs.launchpad.net/bugs/1233679. Approved by PS Jenkins bot, Charles Kerr.
| * Work around dh_translations not understanding CMake variable substitutionPete Woods2013-10-011-1/+1
| |
* | Show synchronous notification when changing the volume by scrolling over the ↵Lars Uebernickel2013-10-015-6/+36
|\ \ | |/ |/| | | | | | | indicator. Fixes: https://bugs.launchpad.net/bugs/1225335. Approved by PS Jenkins bot, Sebastien Bacher.
| * Show synchronous notification when changing the volume by scrolling over the ↵Lars Uebernickel2013-10-015-0/+35
| | | | | | | | indicator
| * service: use vala's double.clamp()Lars Uebernickel2013-10-011-6/+1
|/
* Reconnect when pulseaudio terminates (or crashes). Fixes: ↵Lars Uebernickel2013-09-301-25/+40
|\ | | | | | | | | | | https://bugs.launchpad.net/bugs/1231942. Approved by Ted Gould, PS Jenkins bot.
| * Reconnect when pulseaudio terminates (or crashes)Lars Uebernickel2013-09-301-25/+40
| |
* | Releasing 12.10.2+13.10.20130930-0ubuntu1 (revision 382 from ↵Automatic PS uploader2013-09-301-0/+14
|\ \ | |/ |/| | | | | | | lp:indicator-sound). Approved by PS Jenkins bot.
| * Releasing 12.10.2+13.10.20130930-0ubuntu1, based on r382Automatic PS uploader2013-09-301-0/+14
|/
* Update settings URL to settings:///system. Fixes: ↵Ted Gould2013-09-271-1/+1
|\ | | | | | | | | | | https://bugs.launchpad.net/bugs/1231444. Approved by Lars Uebernickel, PS Jenkins bot.
| * Update settings URL to settings:///systemTed Gould2013-09-261-1/+1
|/
* Use url-dispatcher instead of invoking system-settings directly. Fixes: ↵Charles Kerr2013-09-265-6/+15
|\ | | | | | | | | | | https://bugs.launchpad.net/bugs/1230819. Approved by Ted Gould, PS Jenkins bot.
| * oops, forgot to bzr add the vapiCharles Kerr2013-09-251-0/+9
| |
| * Use url-dispatcher instead of invoking system-settings directly.Charles Kerr2013-09-254-6/+6
|/
* Releasing 12.10.2+13.10.20130924-0ubuntu1 (revision 379 from ↵Automatic PS uploader2013-09-251-0/+10
|\ | | | | | | | | | | lp:indicator-sound). Approved by PS Jenkins bot.
| * Releasing 12.10.2+13.10.20130924-0ubuntu1, based on r379Automatic PS uploader2013-09-241-0/+10
|/
* Recommending gnome-control-center first.Ted Gould2013-09-241-1/+1
|\ | | | | | | Approved by PS Jenkins bot, Stéphane Graber.
| * Recommending gnome-control-center firstTed Gould2013-09-241-1/+1
|/
* Releasing 12.10.2+13.10.20130918-0ubuntu1 (revision 377 from ↵Automatic PS uploader2013-09-181-0/+10
|\ | | | | | | | | | | lp:indicator-sound). Approved by PS Jenkins bot.
| * Releasing 12.10.2+13.10.20130918-0ubuntu1, based on r377Automatic PS uploader2013-09-181-0/+10
|/
* Don't show the "Mute" menu item in the phone profile. Fixes: ↵Lars Uebernickel2013-09-162-8/+12
|\ | | | | | | | | | | https://bugs.launchpad.net/bugs/1220215. Approved by Ted Gould, PS Jenkins bot.
| * sound-menu.vala: make the logic for showing the mic volume more explicitLars Uebernickel2013-09-151-4/+7
| | | | | | | | | | | | | | Before, this was done by counting the items that are currently in the volume section. This broke with the last commit, because with that, the section might not contain a mute menu item.
| * Don't show the "Mute" menu item in the phone profileLars Uebernickel2013-09-152-4/+5
| |
* | Releasing 12.10.2+13.10.20130913-0ubuntu1 (revision 375 from ↵Automatic PS uploader2013-09-131-0/+19
|\ \ | |/ |/| | | | | | | lp:indicator-sound). Approved by PS Jenkins bot.
| * Releasing 12.10.2+13.10.20130913-0ubuntu1, based on r375Automatic PS uploader2013-09-131-0/+19
|/