aboutsummaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* fix a pair of minor memory leaks when processing blacklist requests via dbus.Charles Kerr2012-03-161-8/+8
|
* set the player name on the transport item so as hud can identify the default ↵Conor Curran2012-03-163-2/+3
| | | | player
* don't abort isound via g_error() if it can't connect to the bus. ↵Charles Kerr2012-03-162-13/+12
|\ | | | | | | lp:~cjcurran/indicator-sound/use_g_critical_instead_of_g_error
| * don't g_error just use g_criticalConor Curran2012-03-162-13/+12
| |
* | merge lp:~cjcurran/indicator-sound/excessive-redraws-fix to not call ↵Charles Kerr2012-03-151-19/+30
|\ \ | |/ |/| | | gtk_image_clear() when there's already no album art.
| * make sure to clear the old image for gtk2 aswellConor Curran2012-03-151-1/+2
| |
| * fixes excessive draw calls Conor Curran2012-03-151-19/+29
| |
* | fix pa_operation_unref(NULL) crash by merging ↵Charles Kerr2012-03-141-11/+17
|\ \ | | | | | | | | | ~cjcurran/indicator-sound/global-mute-defensive
| * | make sure to be defensive if pulse goes away in the middle of a global mute ↵Conor Curran2012-03-141-11/+17
| |/ | | | | | | operation
* | remove crudConor Curran2012-03-141-164/+0
| |
* | make the code clear so as coverity stops whinging.Conor Curran2012-03-141-11/+23
|/
* Makes sure to accommodate for null player titles as supplied by the mpris ↵Conor Curran2012-03-131-1/+1
| | | | interface of the player, redundant code spotted by Coverity
* make sure to comply with the mpris specConor Curran2012-03-131-1/+1
|\
| * signature on the GetPlaylists mpris in the interface correctedConor Curran2012-03-121-1/+1
| |
* | use the new signals from lp:~charlesk/ido/lp-921065 to fix lp bug #921065Charles Kerr2012-03-101-28/+28
|/
* fix static overrun in lp Bug #944250Charles Kerr2012-03-031-1/+1
|
* merge the dynamic removal of player items from menu on app uninstallConor Curran2012-03-013-4/+64
|\
| * make sure we are dynamically sensitive to players being uninstalled whilst ↵Conor Curran2012-02-273-4/+64
| | | | | | | | they still have an entry in the menu
* | realign the padding on the player titleConor Curran2012-03-011-1/+1
|\ \
| * | push it down another 2 pixelsConor Curran2012-02-241-1/+1
| | |
| * | pad appication name text by 2 pixelsConor Curran2012-02-241-1/+1
| |/
* | play it safe branchConor Curran2012-03-013-34/+93
|\ \
| * | check the state of the pulse context to ensure it's ready for interactionConor Curran2012-03-011-0/+24
| | |
| * | play it safe around UI pulse interactions - hopefully circumvents odd ↵Conor Curran2012-03-011-26/+62
| | | | | | | | | | | | crashes that have been reported
| * | how can we be sure the details struct is not null, is this the fix to that ↵Conor Curran2012-03-011-1/+1
| | | | | | | | | | | | memory corruption
| * | make sure to return if there is no valid playlistConor Curran2012-02-292-7/+6
| |/
* | fix charles coverity fixesConor Curran2012-03-011-12/+22
|\ \ | |/ |/|
| * Fix LP Bug #937461Charles Kerr2012-02-211-12/+22
| | | | | | | | | | Coverity is complaining that we don't check the return value of g_dbus_connection_register_object(). IMO this is harmless, but is fixed here by remembering the returned registration_id and using it to unregister the object in our object's dispose() function.
* | putting in place more checks for transport-widget and the slider, also fixed ↵Conor Curran2012-02-223-6/+16
| | | | | | | | some more ui glitches
* | play defensively around setting the volume related to lp#90017Conor Curran2012-02-222-12/+14
| |
* | fix layout of the metadata widgetConor Curran2012-02-221-11/+10
|/
* fixed typo in makefile amConor Curran2012-02-141-1/+1
|
* tidy upConor Curran2012-02-131-1/+0
|
* Fixing includes to not have the '3' on themTed Gould2012-01-316-24/+0
|
* add visibility toggle support for (lp:#829648)Charles Kerr2012-01-241-1/+65
|
* fix hashtable leak reported by valgrindCharles Kerr2012-01-241-0/+7
|
* fix a minor memory leak reported by valigrindCharles Kerr2012-01-241-0/+4
|
* fix Free Memory Read error found by valgrindCharles Kerr2012-01-241-0/+1
|
* fix minor memory leak detected by valgrindCharles Kerr2012-01-241-2/+3
|
* fixes minor warningConor Curran2012-01-171-4/+4
|\
| * fix minor runtime warning.Charles Kerr2012-01-111-2/+2
| | | | | | | | | | The debug call in delete_album_art_contents() generates a runtime warning if the directory is empty. Moving the debug call to come after the "file == null" test silences the warning.
| * When creating indicator-sound's cache directory, use ↵Charles Kerr2012-01-111-2/+2
| | | | | | | | | | | | | | DirUtils.create_with_parents() instead of DirUtils.create(). Rationale described @ https://bugs.launchpad.net/indicator-sound/+bug/799383
* | merged indicator address format to bring inline with other indicatorsConor Curran2012-01-178-13/+13
|\|
| * make indicator-sound's schema and path naming consistent with other indicators.Charles Kerr2012-01-108-13/+13
| | | | | | | | | | indicator-sound uses a different schema prefix ("/com/canonical/indicators" vs "/com/canonical/indicator") and different path prefix ("/apps/indicators" vs "/com/canonical/indicator") than other indicators use. When I asked ronoc about the latter, he confirmed it's an error and suggested that the former be fixed at the same time to make indicator naming more consistent.
* | add Allans initial tdd workConor Curran2012-01-131-3/+13
|\ \
| * | Added coverage reporting via gcov config and targets.Allan LeSage2011-12-061-3/+13
| |/
* | fix the gtk3 deprecationsConor Curran2012-01-131-4/+28
|\ \
| * | deprecated gtk fixesConor Curran2012-01-131-4/+28
| | |
* | | make rhythmbox the default appConor Curran2012-01-131-2/+2
|\ \ \
| * | | revert to rhythmbox for the default playerConor Curran2012-01-131-2/+2
| |/ /