Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | fix a pair of minor memory leaks when processing blacklist requests via dbus. | Charles Kerr | 2012-03-16 | 1 | -8/+8 |
| | |||||
* | set the player name on the transport item so as hud can identify the default ↵ | Conor Curran | 2012-03-16 | 3 | -2/+3 |
| | | | | player | ||||
* | don't abort isound via g_error() if it can't connect to the bus. ↵ | Charles Kerr | 2012-03-16 | 2 | -13/+12 |
|\ | | | | | | | lp:~cjcurran/indicator-sound/use_g_critical_instead_of_g_error | ||||
| * | don't g_error just use g_critical | Conor Curran | 2012-03-16 | 2 | -13/+12 |
| | | |||||
* | | merge lp:~cjcurran/indicator-sound/excessive-redraws-fix to not call ↵ | Charles Kerr | 2012-03-15 | 1 | -19/+30 |
|\ \ | |/ |/| | | | gtk_image_clear() when there's already no album art. | ||||
| * | make sure to clear the old image for gtk2 aswell | Conor Curran | 2012-03-15 | 1 | -1/+2 |
| | | |||||
| * | fixes excessive draw calls | Conor Curran | 2012-03-15 | 1 | -19/+29 |
| | | |||||
* | | fix pa_operation_unref(NULL) crash by merging ↵ | Charles Kerr | 2012-03-14 | 1 | -11/+17 |
|\ \ | | | | | | | | | | ~cjcurran/indicator-sound/global-mute-defensive | ||||
| * | | make sure to be defensive if pulse goes away in the middle of a global mute ↵ | Conor Curran | 2012-03-14 | 1 | -11/+17 |
| |/ | | | | | | | operation | ||||
* | | remove crud | Conor Curran | 2012-03-14 | 1 | -164/+0 |
| | | |||||
* | | make the code clear so as coverity stops whinging. | Conor Curran | 2012-03-14 | 1 | -11/+23 |
|/ | |||||
* | Makes sure to accommodate for null player titles as supplied by the mpris ↵ | Conor Curran | 2012-03-13 | 1 | -1/+1 |
| | | | | interface of the player, redundant code spotted by Coverity | ||||
* | make sure to comply with the mpris spec | Conor Curran | 2012-03-13 | 1 | -1/+1 |
|\ | |||||
| * | signature on the GetPlaylists mpris in the interface corrected | Conor Curran | 2012-03-12 | 1 | -1/+1 |
| | | |||||
* | | use the new signals from lp:~charlesk/ido/lp-921065 to fix lp bug #921065 | Charles Kerr | 2012-03-10 | 1 | -28/+28 |
|/ | |||||
* | fix static overrun in lp Bug #944250 | Charles Kerr | 2012-03-03 | 1 | -1/+1 |
| | |||||
* | merge the dynamic removal of player items from menu on app uninstall | Conor Curran | 2012-03-01 | 3 | -4/+64 |
|\ | |||||
| * | make sure we are dynamically sensitive to players being uninstalled whilst ↵ | Conor Curran | 2012-02-27 | 3 | -4/+64 |
| | | | | | | | | they still have an entry in the menu | ||||
* | | realign the padding on the player title | Conor Curran | 2012-03-01 | 1 | -1/+1 |
|\ \ | |||||
| * | | push it down another 2 pixels | Conor Curran | 2012-02-24 | 1 | -1/+1 |
| | | | |||||
| * | | pad appication name text by 2 pixels | Conor Curran | 2012-02-24 | 1 | -1/+1 |
| |/ | |||||
* | | play it safe branch | Conor Curran | 2012-03-01 | 3 | -34/+93 |
|\ \ | |||||
| * | | check the state of the pulse context to ensure it's ready for interaction | Conor Curran | 2012-03-01 | 1 | -0/+24 |
| | | | |||||
| * | | play it safe around UI pulse interactions - hopefully circumvents odd ↵ | Conor Curran | 2012-03-01 | 1 | -26/+62 |
| | | | | | | | | | | | | crashes that have been reported | ||||
| * | | how can we be sure the details struct is not null, is this the fix to that ↵ | Conor Curran | 2012-03-01 | 1 | -1/+1 |
| | | | | | | | | | | | | memory corruption | ||||
| * | | make sure to return if there is no valid playlist | Conor Curran | 2012-02-29 | 2 | -7/+6 |
| |/ | |||||
* | | fix charles coverity fixes | Conor Curran | 2012-03-01 | 1 | -12/+22 |
|\ \ | |/ |/| | |||||
| * | Fix LP Bug #937461 | Charles Kerr | 2012-02-21 | 1 | -12/+22 |
| | | | | | | | | | | Coverity is complaining that we don't check the return value of g_dbus_connection_register_object(). IMO this is harmless, but is fixed here by remembering the returned registration_id and using it to unregister the object in our object's dispose() function. | ||||
* | | putting in place more checks for transport-widget and the slider, also fixed ↵ | Conor Curran | 2012-02-22 | 3 | -6/+16 |
| | | | | | | | | some more ui glitches | ||||
* | | play defensively around setting the volume related to lp#90017 | Conor Curran | 2012-02-22 | 2 | -12/+14 |
| | | |||||
* | | fix layout of the metadata widget | Conor Curran | 2012-02-22 | 1 | -11/+10 |
|/ | |||||
* | fixed typo in makefile am | Conor Curran | 2012-02-14 | 1 | -1/+1 |
| | |||||
* | tidy up | Conor Curran | 2012-02-13 | 1 | -1/+0 |
| | |||||
* | Fixing includes to not have the '3' on them | Ted Gould | 2012-01-31 | 6 | -24/+0 |
| | |||||
* | add visibility toggle support for (lp:#829648) | Charles Kerr | 2012-01-24 | 1 | -1/+65 |
| | |||||
* | fix hashtable leak reported by valgrind | Charles Kerr | 2012-01-24 | 1 | -0/+7 |
| | |||||
* | fix a minor memory leak reported by valigrind | Charles Kerr | 2012-01-24 | 1 | -0/+4 |
| | |||||
* | fix Free Memory Read error found by valgrind | Charles Kerr | 2012-01-24 | 1 | -0/+1 |
| | |||||
* | fix minor memory leak detected by valgrind | Charles Kerr | 2012-01-24 | 1 | -2/+3 |
| | |||||
* | fixes minor warning | Conor Curran | 2012-01-17 | 1 | -4/+4 |
|\ | |||||
| * | fix minor runtime warning. | Charles Kerr | 2012-01-11 | 1 | -2/+2 |
| | | | | | | | | | | The debug call in delete_album_art_contents() generates a runtime warning if the directory is empty. Moving the debug call to come after the "file == null" test silences the warning. | ||||
| * | When creating indicator-sound's cache directory, use ↵ | Charles Kerr | 2012-01-11 | 1 | -2/+2 |
| | | | | | | | | | | | | | | DirUtils.create_with_parents() instead of DirUtils.create(). Rationale described @ https://bugs.launchpad.net/indicator-sound/+bug/799383 | ||||
* | | merged indicator address format to bring inline with other indicators | Conor Curran | 2012-01-17 | 8 | -13/+13 |
|\| | |||||
| * | make indicator-sound's schema and path naming consistent with other indicators. | Charles Kerr | 2012-01-10 | 8 | -13/+13 |
| | | | | | | | | | | indicator-sound uses a different schema prefix ("/com/canonical/indicators" vs "/com/canonical/indicator") and different path prefix ("/apps/indicators" vs "/com/canonical/indicator") than other indicators use. When I asked ronoc about the latter, he confirmed it's an error and suggested that the former be fixed at the same time to make indicator naming more consistent. | ||||
* | | add Allans initial tdd work | Conor Curran | 2012-01-13 | 1 | -3/+13 |
|\ \ | |||||
| * | | Added coverage reporting via gcov config and targets. | Allan LeSage | 2011-12-06 | 1 | -3/+13 |
| |/ | |||||
* | | fix the gtk3 deprecations | Conor Curran | 2012-01-13 | 1 | -4/+28 |
|\ \ | |||||
| * | | deprecated gtk fixes | Conor Curran | 2012-01-13 | 1 | -4/+28 |
| | | | |||||
* | | | make rhythmbox the default app | Conor Curran | 2012-01-13 | 1 | -2/+2 |
|\ \ \ | |||||
| * | | | revert to rhythmbox for the default player | Conor Curran | 2012-01-13 | 1 | -2/+2 |
| |/ / |