Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Test that MediaPlayer's icon property isn't NULL before we serialize it. ↵ | Charles Kerr | 2013-10-28 | 1 | -1/+7 |
|\ | | | | | | | | | | | Fixes: https://bugs.launchpad.net/bugs/1229612. Approved by PS Jenkins bot, Lars Uebernickel. | ||||
| * | add the null safeguard back for the pathological case of ↵ | Charles Kerr | 2013-10-28 | 1 | -1/+2 |
| | | | | | | | | 'application-default-icon' also failing | ||||
| * | use 'application-default-icon' as the fallback media player icon | Charles Kerr | 2013-10-28 | 1 | -2/+6 |
| | | |||||
| * | test that player.icon isn't null before we serialize it. | Charles Kerr | 2013-10-25 | 1 | -1/+2 |
| | | |||||
* | | VolumeControl: don't pass vala closures into libpulse | Lars Uebernickel | 2013-10-28 | 1 | -15/+29 |
|\ \ | |/ |/| | | | | | | | | | | | | | | | Libpulse's vala bindings don't specify that callbacks passed into some of its functions (e.g., get_server_info) can be called after the function returns. Vala thus frees closure data after these functions return. This can't easily be fixed in the bindings, because libpulse doesn't provide variants of these functions with destroy_notifies. This patch works around this problem by only passing non-closure functions into libpulse. Fixes: https://bugs.launchpad.net/bugs/1244386. Approved by Charles Kerr, PS Jenkins bot. | ||||
| * | VolumeControl: don't pass vala closures into libpulse | Lars Uebernickel | 2013-10-26 | 1 | -15/+29 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | Libpulse's vala bindings don't specify that callbacks passed into some of its functions (e.g., get_server_info) can be called after the function returns. Vala thus frees closure data after these functions return. This can't easily be fixed in the bindings, because libpulse doesn't provide variants of these functions with destroy_notifies. This patch works around this problem by only passing non-closure functions into libpulse. | ||||
* | | fix similar variant leaks | Charles Kerr | 2013-10-24 | 1 | -6/+6 |
| | | |||||
* | | in Service's volume_changed(), explicitly instantiate the GVariant to avoid ↵ | Charles Kerr | 2013-10-24 | 1 | -1/+1 |
| | | | | | | | | leaking it | ||||
* | | Don't special case Unity sessions, that's not needed since | Sebastien Bacher | 2013-10-24 | 1 | -3/+1 |
| | | | | | | | | | | | | gnome-control-center is doing the right thing, the session name used was also wrong and couldn't work (lp: #1239545) | ||||
* | | Only display running players in the phone's sound menu | Lars Uebernickel | 2013-10-24 | 2 | -28/+62 |
|\ \ | | | | | | | | | | | | | | | | The design says to only display the _one_ running player. This will have that effect, as there's only one player allowed to run at a time on the phone. Approved by PS Jenkins bot, Ted Gould. | ||||
| * | | Only display running players in the phone's sound menu | Lars Uebernickel | 2013-10-10 | 2 | -25/+54 |
| | | | |||||
| * | | Replace 'mute' boolean by a flag in the SoundMenu constructor | Lars Uebernickel | 2013-10-10 | 2 | -5/+10 |
| | | | | | | | | | | | | | | | | | | This makes the code calling the constructor more readable and allows for extensibility. | ||||
* | | | when we fail to connect to pulse, wait a moment before retrying. | Charles Kerr | 2013-10-23 | 1 | -1/+18 |
| |/ |/| | |||||
* | | Give the volume menu item a target, because the 'volume' action now has a ↵ | Lars Uebernickel | 2013-10-10 | 1 | -1/+1 |
| | | | | | | | | parameter | ||||
* | | Allow activating the 'volume' action | Lars Uebernickel | 2013-10-09 | 1 | -2/+9 |
|/ | | | | | It does the same as the 'scroll' action except showing a notification. | ||||
* | Make sure to set the initial value of settings shown | Ted Gould | 2013-10-02 | 1 | -1/+1 |
| | |||||
* | Making the settings action optional | Ted Gould | 2013-10-02 | 2 | -3/+13 |
| | |||||
* | Show synchronous notification when changing the volume by scrolling over the ↵ | Lars Uebernickel | 2013-10-01 | 3 | -0/+33 |
| | | | | indicator | ||||
* | service: use vala's double.clamp() | Lars Uebernickel | 2013-10-01 | 1 | -6/+1 |
| | |||||
* | Reconnect when pulseaudio terminates (or crashes) | Lars Uebernickel | 2013-09-30 | 1 | -25/+40 |
| | |||||
* | Update settings URL to settings:///system | Ted Gould | 2013-09-26 | 1 | -1/+1 |
| | |||||
* | Use url-dispatcher instead of invoking system-settings directly. | Charles Kerr | 2013-09-25 | 2 | -5/+2 |
| | |||||
* | sound-menu.vala: make the logic for showing the mic volume more explicit | Lars Uebernickel | 2013-09-15 | 1 | -4/+7 |
| | | | | | | | Before, this was done by counting the items that are currently in the volume section. This broke with the last commit, because with that, the section might not contain a mute menu item. | ||||
* | Don't show the "Mute" menu item in the phone profile | Lars Uebernickel | 2013-09-15 | 2 | -4/+5 |
| | |||||
* | Add "title" to the root action state dictionary | Lars Uebernickel | 2013-09-12 | 1 | -0/+1 |
| | |||||
* | Remove volume percentage from translatable part of the accessible title | Lars Uebernickel | 2013-09-11 | 1 | -1/+1 |
| | |||||
* | Mark remaining user-visible strings as translatable | Lars Uebernickel | 2013-09-11 | 2 | -3/+3 |
| | |||||
* | Toggle mute on secondary action | Lars Uebernickel | 2013-09-09 | 1 | -0/+1 |
| | | | | | | This depends on the panel supporting x-canonical-secondary-action on the root menu item. | ||||
* | Change volume when scrolling on the indicator | Lars Uebernickel | 2013-09-09 | 2 | -0/+15 |
| | | | | | | | | This depends on a new root menu property: x-canonical-scroll-action. It points to an action that gets activated whenever the user scrolls the mouse over the indicator. The parameter of that action signifies the magnitude and direction of the scroll. | ||||
* | Merge trunk | Lars Uebernickel | 2013-08-26 | 4 | -18/+153 |
|\ | |||||
| * | don't use deprecated GSimpleActionGroup APIs | Charles Kerr | 2013-08-22 | 1 | -14/+14 |
| | | |||||
| * | Clean up the build / installation | Pete Woods | 2013-08-16 | 1 | -1/+1 |
| | | |||||
| * | Build using cmake | Pete Woods | 2013-08-16 | 4 | -40/+131 |
| | | |||||
| * | add accessible-name property to the ng sound indicator | Charles Kerr | 2013-08-08 | 1 | -2/+14 |
| | | |||||
* | | bus-watch-namespace: remove stray semicolon | Lars Uebernickel | 2013-08-26 | 1 | -1/+1 |
| | | |||||
* | | bus-watch-namespace: free name_space | Lars Uebernickel | 2013-08-26 | 1 | -0/+2 |
| | | |||||
* | | Use bus_watch_namespace() to monitor mpris players | Lars Uebernickel | 2013-08-02 | 5 | -211/+398 |
|/ | | | | | | | | | This function is more robust than the current code and uses glib's G_DBUS_SIGNAL_FLAGS_MATCH_ARG0_NAMESPACE instead of creating match rules itself. bus-watch-namespace.[ch] is shared with gnome-settings-daemon. | ||||
* | Fixed max-icon icon source | Nick Dedekind | 2013-07-30 | 1 | -2/+2 |
| | |||||
* | Export phone menu | Lars Uebernickel | 2013-07-25 | 2 | -6/+19 |
| | | | | | | For now, this does the same as the one on the desktop, except for starting the the phone's settings ui. | ||||
* | service.vala: store menus in a hash table, keyed by profile name | Lars Uebernickel | 2013-07-25 | 2 | -8/+14 |
| | |||||
* | service.vala: move menu handling into sound-menu.vala | Lars Uebernickel | 2013-07-25 | 3 | -126/+168 |
| | | | | | | This makes service.vala a lot more readable and makes way for exporting a second - slightly different - menu for the phone profile. | ||||
* | Specify fallback icons | Lars Uebernickel | 2013-07-19 | 1 | -6/+13 |
| | | | | | The *-panel suffix is only used by the ubuntu-mono icon themes. | ||||
* | Use interested-media-players instead of preferred-media-players gsettings key | Lars Uebernickel | 2013-07-11 | 1 | -4/+4 |
| | |||||
* | Expose playlists in the menu if the player exports them | Lars Uebernickel | 2013-07-10 | 2 | -3/+110 |
| | |||||
* | Don't set player state to "Launching" when the player is already running | Lars Uebernickel | 2013-07-06 | 1 | -1/+3 |
| | |||||
* | Launch player when the play action is activated | Lars Uebernickel | 2013-07-06 | 1 | -1/+14 |
| | |||||
* | Set locale and bind text domain | Lars Uebernickel | 2013-07-04 | 1 | -0/+7 |
| | |||||
* | Put service into $pkglibexecdir | Lars Uebernickel | 2013-07-04 | 1 | -1/+1 |
| | |||||
* | media-player-list, mpris2-watcher: remove unneded `public` from methods | Lars Uebernickel | 2013-06-28 | 2 | -4/+4 |
| | |||||
* | service.vala: make removing a player from the menu more readable | Lars Uebernickel | 2013-06-28 | 1 | -10/+17 |
| |