From 1bdef61d49c35e1476117ae80c99610296bab68c Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Tue, 24 Jan 2012 20:11:12 -0600 Subject: fix minor memory leak detected by valgrind --- src/metadata-widget.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'src/metadata-widget.c') diff --git a/src/metadata-widget.c b/src/metadata-widget.c index 8d816de..8304438 100644 --- a/src/metadata-widget.c +++ b/src/metadata-widget.c @@ -790,8 +790,9 @@ metadata_widget_set_icon (MetadataWidget *self) gtk_icon_size_lookup (GTK_ICON_SIZE_MENU, &width, &height); GString* banshee_string = g_string_new ( "banshee" ); - GString* app_panel = g_string_new ( g_utf8_strdown (dbusmenu_menuitem_property_get(priv->twin_item, DBUSMENU_METADATA_MENUITEM_PLAYER_NAME), - -1)); + gchar * tmp = g_utf8_strdown (dbusmenu_menuitem_property_get(priv->twin_item, DBUSMENU_METADATA_MENUITEM_PLAYER_NAME), -1); + GString* app_panel = g_string_new (tmp); + g_free (tmp); GdkPixbuf* icon_buf; // Banshee Special case! -- cgit v1.2.3 From f1fd627d976f56bd47e5b8226c229eaf8cc64158 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Tue, 24 Jan 2012 20:21:21 -0600 Subject: fix Free Memory Read error found by valgrind --- src/metadata-widget.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src/metadata-widget.c') diff --git a/src/metadata-widget.c b/src/metadata-widget.c index 8304438..16e30e5 100644 --- a/src/metadata-widget.c +++ b/src/metadata-widget.c @@ -256,6 +256,7 @@ metadata_widget_dispose (GObject *object) #else gdk_pixbuf_unref(priv->icon_buf); #endif + priv->icon_buf = NULL; } G_OBJECT_CLASS (metadata_widget_parent_class)->dispose (object); } -- cgit v1.2.3 From f174071dd8f98b298509d11f45b67dac77924599 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Tue, 24 Jan 2012 20:52:57 -0600 Subject: fix a minor memory leak reported by valigrind --- src/metadata-widget.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/metadata-widget.c') diff --git a/src/metadata-widget.c b/src/metadata-widget.c index 16e30e5..a3383df 100644 --- a/src/metadata-widget.c +++ b/src/metadata-widget.c @@ -264,6 +264,10 @@ metadata_widget_dispose (GObject *object) static void metadata_widget_finalize (GObject *object) { + MetadataWidgetPrivate * priv = METADATA_WIDGET_GET_PRIVATE(METADATA_WIDGET(object)); + g_string_free (priv->image_path, TRUE); + g_string_free (priv->old_image_path, TRUE); + G_OBJECT_CLASS (metadata_widget_parent_class)->finalize (object); } -- cgit v1.2.3