From a406685399b46b4b2a62b8e580ce7beec2f875f4 Mon Sep 17 00:00:00 2001 From: Conor Curran <conor.curran@canonical.com> Date: Thu, 9 Jun 2011 17:39:03 +0200 Subject: image is appearing inthe gutter hurray --- src/player-item.vala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/player-item.vala') diff --git a/src/player-item.vala b/src/player-item.vala index f71b166..cb21115 100644 --- a/src/player-item.vala +++ b/src/player-item.vala @@ -87,7 +87,7 @@ public class PlayerItem : Dbusmenu.Menuitem this.property_set_bool(property, v.get_boolean()); } } - this.property_set_bool(MENUITEM_PROP_VISIBLE, populated(attributes)); + //this.property_set_bool(MENUITEM_PROP_VISIBLE, populated(attributes)); } public bool populated(HashSet<string> attrs) -- cgit v1.2.3 From ec14b8310dd5b02ed749c2cfade5c1a45ef00bac Mon Sep 17 00:00:00 2001 From: Conor Curran <conor.curran@canonical.com> Date: Mon, 13 Jun 2011 12:04:15 +0200 Subject: number of bugs fixed, more to come --- src/player-item.vala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/player-item.vala') diff --git a/src/player-item.vala b/src/player-item.vala index cb21115..f71b166 100644 --- a/src/player-item.vala +++ b/src/player-item.vala @@ -87,7 +87,7 @@ public class PlayerItem : Dbusmenu.Menuitem this.property_set_bool(property, v.get_boolean()); } } - //this.property_set_bool(MENUITEM_PROP_VISIBLE, populated(attributes)); + this.property_set_bool(MENUITEM_PROP_VISIBLE, populated(attributes)); } public bool populated(HashSet<string> attrs) -- cgit v1.2.3 From 95fdfeacc7b13034ca71aac2fe2e42fef17de253 Mon Sep 17 00:00:00 2001 From: Conor Curran <conor.curran@canonical.com> Date: Tue, 14 Jun 2011 13:17:25 +0200 Subject: spacing fixed --- src/player-item.vala | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'src/player-item.vala') diff --git a/src/player-item.vala b/src/player-item.vala index f71b166..6d9c8e5 100644 --- a/src/player-item.vala +++ b/src/player-item.vala @@ -24,7 +24,7 @@ public class PlayerItem : Dbusmenu.Menuitem { public PlayerController owner {get; construct;} public string item_type { get; construct; } - private const int EMPTY = -1; + public const int EMPTY = -1; public PlayerItem(string type) { @@ -37,7 +37,6 @@ public class PlayerItem : Dbusmenu.Menuitem public void reset(HashSet<string> attrs){ foreach(string s in attrs){ - //debug("attempting to set prop %s to EMPTY", s); this.property_set_int(s, EMPTY); } } @@ -93,9 +92,7 @@ public class PlayerItem : Dbusmenu.Menuitem public bool populated(HashSet<string> attrs) { foreach(string prop in attrs){ - //debug("populated ? - prop: %s", prop); if(property_get_int(prop) != EMPTY){ - //debug("populated - prop %s and value %i", prop, property_get_int(prop)); return true; } } -- cgit v1.2.3 From 2e0dd336905735dc75d3ab7e676ef60af76ae746 Mon Sep 17 00:00:00 2001 From: Conor Curran <conor.curran@canonical.com> Date: Tue, 14 Jun 2011 18:24:46 +0200 Subject: caught most of the little bugs I could find@ --- src/player-item.vala | 1 + 1 file changed, 1 insertion(+) (limited to 'src/player-item.vala') diff --git a/src/player-item.vala b/src/player-item.vala index 6d9c8e5..2af3f36 100644 --- a/src/player-item.vala +++ b/src/player-item.vala @@ -86,6 +86,7 @@ public class PlayerItem : Dbusmenu.Menuitem this.property_set_bool(property, v.get_boolean()); } } + // TODO- is this only relevant for the metadata, if so please call for just that case this.property_set_bool(MENUITEM_PROP_VISIBLE, populated(attributes)); } -- cgit v1.2.3