From 6f293994f8f9c260401fd76a189c7461b1b5f994 Mon Sep 17 00:00:00 2001 From: Allan LeSage Date: Tue, 27 Mar 2012 16:54:01 -0500 Subject: Added coverage tooling. --- src/Makefile.am | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src') diff --git a/src/Makefile.am b/src/Makefile.am index a4bd27a..a267f1f 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -68,12 +68,14 @@ libappindicator_la_SOURCES = \ gen-notification-watcher.xml.c libappindicator_la_LDFLAGS = \ + $(COVERAGE_LDFLAGS) \ -version-info 1:0:0 \ -no-undefined \ -export-symbols-regex "^[^_d].*" libappindicator_la_CFLAGS = \ $(LIBRARY_CFLAGS) \ + $(COVERAGE_CFLAGS) \ -Wall -Werror \ -DG_LOG_DOMAIN=\"libappindicator\" -- cgit v1.2.3 From b894548cd9498d8a96743ca292287c3746d3545e Mon Sep 17 00:00:00 2001 From: Ted Gould Date: Mon, 16 Apr 2012 13:50:43 -0500 Subject: If we don't have a title set, use the application name to output the title --- src/app-indicator.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/app-indicator.c b/src/app-indicator.c index 0d6450c..2e98b48 100644 --- a/src/app-indicator.c +++ b/src/app-indicator.c @@ -1123,7 +1123,18 @@ bus_get_prop (GDBusConnection * connection, const gchar * sender, const gchar * } else if (g_strcmp0(property, "AttentionIconName") == 0) { return g_variant_new_string(priv->attention_icon_name ? priv->attention_icon_name : ""); } else if (g_strcmp0(property, "Title") == 0) { - return g_variant_new_string(priv->title ? priv->title : ""); + const gchar * output = NULL; + if (priv->title == NULL) { + const gchar * name = g_get_application_name(); + if (name != NULL) { + output = name; + } else { + output = ""; + } + } else { + output = priv->title; + } + return g_variant_new_string(output); } else if (g_strcmp0(property, "IconThemePath") == 0) { return g_variant_new_string(priv->icon_theme_path ? priv->icon_theme_path : ""); } else if (g_strcmp0(property, "Menu") == 0) { -- cgit v1.2.3 From 96fc7f90f40b8835d5ab1fbd4169fc35aa17cf18 Mon Sep 17 00:00:00 2001 From: Evgeni Golov Date: Sun, 10 Jun 2012 10:03:43 +0200 Subject: don't include build-time filenames in comments of the enum header files If we do, the header files may be different on each build. This is especially harmful when building multiple times for multiple architectures and expecting the files to be identical. --- src/app-indicator-enum-types.c.in | 2 +- src/app-indicator-enum-types.h.in | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/app-indicator-enum-types.c.in b/src/app-indicator-enum-types.c.in index e200396..26276dc 100644 --- a/src/app-indicator-enum-types.c.in +++ b/src/app-indicator-enum-types.c.in @@ -32,7 +32,7 @@ License version 3 and version 2.1 along with this program. If not, see /*** END file-header ***/ /*** BEGIN file-production ***/ -#include "@filename@" +#include "@basename@" /*** END file-production ***/ /*** BEGIN value-header ***/ diff --git a/src/app-indicator-enum-types.h.in b/src/app-indicator-enum-types.h.in index a055d71..33e501f 100644 --- a/src/app-indicator-enum-types.h.in +++ b/src/app-indicator-enum-types.h.in @@ -44,7 +44,7 @@ G_END_DECLS /*** END file-tail ***/ /*** BEGIN file-production ***/ -/* Enumerations from file: "@filename@" */ +/* Enumerations from file: "@basename@" */ /*** END file-production ***/ /*** BEGIN value-header ***/ -- cgit v1.2.3