From a14b6ddf7db70eff5d831aa1e9e11b46b726002f Mon Sep 17 00:00:00 2001 From: Ted Gould Date: Thu, 5 Feb 2009 15:27:42 +0100 Subject: Changing the DBUS API slightly. Now there is no 'get_desktop' function as desktop is a property. Added a property for type so that we can understand what kind of application this is. And finally adding show/hide signals on the server as they were already on the listener. --- libindicate/indicate-interface.xml | 13 +++++++-- libindicate/server.c | 56 ++++++++++++++------------------------ libindicate/server.h | 4 +-- 3 files changed, 33 insertions(+), 40 deletions(-) diff --git a/libindicate/indicate-interface.xml b/libindicate/indicate-interface.xml index d1fed7e..f1c7c37 100644 --- a/libindicate/indicate-interface.xml +++ b/libindicate/indicate-interface.xml @@ -2,10 +2,11 @@ + + + + - - - @@ -52,6 +53,12 @@ + + + + + + diff --git a/libindicate/server.c b/libindicate/server.c index ab64304..ba86210 100644 --- a/libindicate/server.c +++ b/libindicate/server.c @@ -22,6 +22,8 @@ enum { INDICATOR_ADDED, INDICATOR_REMOVED, INDICATOR_MODIFIED, + SERVER_SHOW, + SERVER_HIDE, LAST_SIGNAL }; @@ -49,7 +51,6 @@ G_DEFINE_TYPE (IndicateServer, indicate_server, G_TYPE_OBJECT); /* Prototypes */ static void indicate_server_finalize (GObject * obj); -static gboolean get_desktop (IndicateServer * server, gchar ** desktop_path, GError **error); static gboolean get_indicator_count (IndicateServer * server, guint * count, GError **error); static gboolean get_indicator_count_by_type (IndicateServer * server, gchar * type, guint * count, GError **error); static gboolean get_indicator_list (IndicateServer * server, GArray ** indicators, GError ** error); @@ -93,11 +94,24 @@ indicate_server_class_init (IndicateServerClass * class) NULL, NULL, g_cclosure_marshal_VOID__UINT_POINTER, G_TYPE_NONE, 2, G_TYPE_UINT, G_TYPE_STRING); + signals[SERVER_SHOW] = g_signal_new("server-show", + G_TYPE_FROM_CLASS (class), + G_SIGNAL_RUN_LAST, + G_STRUCT_OFFSET (IndicateServerClass, server_show), + NULL, NULL, + g_cclosure_marshal_VOID__POINTER, + G_TYPE_NONE, 1, G_TYPE_STRING); + signals[SERVER_HIDE] = g_signal_new("server-hide", + G_TYPE_FROM_CLASS (class), + G_SIGNAL_RUN_LAST, + G_STRUCT_OFFSET (IndicateServerClass, server_hide), + NULL, NULL, + g_cclosure_marshal_VOID__POINTER, + G_TYPE_NONE, 1, G_TYPE_STRING); dbus_g_object_type_install_info(INDICATE_TYPE_SERVER, &dbus_glib_indicate_server_object_info); - class->get_desktop = get_desktop; class->get_indicator_count = get_indicator_count; class->get_indicator_count_by_type = get_indicator_count_by_type; class->get_indicator_list = get_indicator_list; @@ -133,6 +147,9 @@ indicate_server_finalize (GObject * obj) IndicateServer * server = INDICATE_SERVER(obj); IndicateServerPrivate * priv = INDICATE_SERVER_GET_PRIVATE(server); + /* TODO: This probably shouldn't be as far down as finalize, but it's fine here. */ + g_signal_emit(server, signals[SERVER_HIDE], 0, "", TRUE); + if (priv->path) { g_free(priv->path); } @@ -168,6 +185,8 @@ indicate_server_show (IndicateServer * server) priv->path, G_OBJECT(server)); priv->visible = TRUE; + + g_signal_emit(server, signals[SERVER_SHOW], 0, "", TRUE); return; } @@ -277,18 +296,6 @@ indicate_server_set_default (IndicateServer * server) return; } -static gboolean -get_desktop (IndicateServer * server, gchar ** desktop_path, GError **error) -{ - IndicateServerPrivate * priv = INDICATE_SERVER_GET_PRIVATE(server); - - if (priv->path != NULL) { - // TODO: This might be a memory leak, check into that. - *desktop_path = g_strdup(priv->path); - } - return TRUE; -} - static gboolean get_indicator_count (IndicateServer * server, guint * count, GError **error) { @@ -504,27 +511,6 @@ show_indicator_to_user (IndicateServer * server, guint id, GError ** error) /* Virtual Functions */ -gboolean -indicate_server_get_desktop (IndicateServer * server, gchar ** desktop_path, GError **error) -{ - IndicateServerClass * class = INDICATE_SERVER_GET_CLASS(server); - - if (class != NULL) { - return class->get_desktop (server, desktop_path, error); - } - - if (error) { - g_set_error(error, - indicate_server_error_quark(), - NO_GET_DESKTOP, - "get_desktop function doesn't exist for this server class: %s", - G_OBJECT_TYPE_NAME(server)); - return FALSE; - } - - return TRUE; -} - gboolean indicate_server_get_indicator_count (IndicateServer * server, guint * count, GError **error) { diff --git a/libindicate/server.h b/libindicate/server.h index eccf3c6..c2b2191 100644 --- a/libindicate/server.h +++ b/libindicate/server.h @@ -30,9 +30,10 @@ struct _IndicateServerClass { void (* indicator_added) (IndicateServer * server, guint id, gchar * type); void (* indicator_removed) (IndicateServer * server, guint id, gchar * type); void (* indicator_modified) (IndicateServer * server, guint id, gchar * property); + void (* server_show) (IndicateServer * server, gchar * type); + void (* server_hide) (IndicateServer * server, gchar * type); /* Virtual Functions */ - gboolean (*get_desktop) (IndicateServer * server, gchar ** desktop_path, GError **error); gboolean (*get_indicator_count) (IndicateServer * server, guint * count, GError **error); gboolean (*get_indicator_count_by_type) (IndicateServer * server, gchar * type, guint * count, GError **error); gboolean (*get_indicator_list) (IndicateServer * server, GArray ** indicators, GError ** error); @@ -71,7 +72,6 @@ IndicateServer * indicate_server_ref_default (void); void indicate_server_set_default (IndicateServer * server); /* DBus API */ -gboolean indicate_server_get_desktop (IndicateServer * server, gchar ** desktop_path, GError **error); gboolean indicate_server_get_indicator_count (IndicateServer * server, guint * count, GError **error); gboolean indicate_server_get_indicator_count_by_type (IndicateServer * server, gchar * type, guint * count, GError **error); gboolean indicate_server_get_indicator_list (IndicateServer * server, GArray ** indicators, GError ** error); -- cgit v1.2.3 From c4db8e8c0c4978d70540d79df30d22c1afb7803f Mon Sep 17 00:00:00 2001 From: Ted Gould Date: Thu, 5 Feb 2009 17:58:22 +0100 Subject: Adding properties for doing type and desktop --- libindicate/server.c | 84 ++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 84 insertions(+) diff --git a/libindicate/server.c b/libindicate/server.c index ba86210..6139fd0 100644 --- a/libindicate/server.c +++ b/libindicate/server.c @@ -27,6 +27,13 @@ enum { LAST_SIGNAL }; +/* Properties */ +enum { + PROP_0, + PROP_DESKTOP, + PROP_TYPE +}; + static guint signals[LAST_SIGNAL] = { 0 }; /* Private area */ @@ -38,6 +45,9 @@ struct _IndicateServerPrivate gboolean visible; guint current_id; + gchar * desktop; + gchar * type; + // TODO: Should have a more robust way to track this, but this'll work for now guint num_hidden; }; @@ -60,6 +70,8 @@ static gboolean get_indicator_property_group (IndicateServer * server, guint id, static gboolean get_indicator_properties (IndicateServer * server, guint id, gchar *** properties, GError **error); static gboolean show_indicator_to_user (IndicateServer * server, guint id, GError ** error); static guint get_next_id (IndicateServer * server); +static void set_property (GObject * obj, guint id, const GValue * value, GParamSpec * pspec); +static void get_property (GObject * obj, guint id, GValue * value, GParamSpec * pspec); /* Code */ static void @@ -72,6 +84,8 @@ indicate_server_class_init (IndicateServerClass * class) g_type_class_add_private (class, sizeof (IndicateServerPrivate)); gobj->finalize = indicate_server_finalize; + gobj->set_property = set_property; + gobj->get_property = get_property; signals[INDICATOR_ADDED] = g_signal_new("indicator-added", G_TYPE_FROM_CLASS (class), @@ -109,6 +123,17 @@ indicate_server_class_init (IndicateServerClass * class) g_cclosure_marshal_VOID__POINTER, G_TYPE_NONE, 1, G_TYPE_STRING); + g_object_class_install_property (gobj, PROP_DESKTOP, + g_param_spec_string("desktop", "Desktop File", + "The desktop file representing this server", + "", + G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); + g_object_class_install_property (gobj, PROP_TYPE, + g_param_spec_string("type", "Server Type", + "The type of indicators that this server will provide", + "", + G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS)); + dbus_g_object_type_install_info(INDICATE_TYPE_SERVER, &dbus_glib_indicate_server_object_info); @@ -137,6 +162,8 @@ indicate_server_init (IndicateServer * server) priv->num_hidden = 0; priv->visible = FALSE; priv->current_id = 0; + priv->type = NULL; + priv->desktop = NULL; return; } @@ -153,6 +180,63 @@ indicate_server_finalize (GObject * obj) if (priv->path) { g_free(priv->path); } + if (priv->desktop) { + g_free(priv->desktop); + } + if (priv->type) { + g_free(priv->type); + } + + return; +} + +static void +set_property (GObject * obj, guint id, const GValue * value, GParamSpec * pspec) +{ + g_return_if_fail(G_VALUE_HOLDS_STRING(value)); + g_return_if_fail(id == PROP_DESKTOP || id == PROP_TYPE); + + gchar ** outstr; + IndicateServerPrivate * priv = INDICATE_SERVER_GET_PRIVATE(obj); + switch (id) { + case PROP_DESKTOP: + outstr = &(priv->desktop); + break; + case PROP_TYPE: + outstr = &(priv->type); + break; + } + + if (*outstr != NULL) { + g_free(*outstr); + } + + *outstr = g_strdup(g_value_get_string(value)); + + return; +} + +static void +get_property (GObject * obj, guint id, GValue * value, GParamSpec * pspec) +{ + g_return_if_fail(id == PROP_DESKTOP || id == PROP_TYPE); + + gchar * outstr; + IndicateServerPrivate * priv = INDICATE_SERVER_GET_PRIVATE(obj); + switch (id) { + case PROP_DESKTOP: + outstr = priv->desktop; + break; + case PROP_TYPE: + outstr = priv->type; + break; + } + + if (outstr != NULL) { + g_value_set_string(value, outstr); + } else { + g_value_set_static_string(value, ""); + } return; } -- cgit v1.2.3