From 83380695633e0b9dc79ce8eefd3c0e97ff5503c8 Mon Sep 17 00:00:00 2001 From: Mike Gabriel Date: Tue, 20 Apr 2021 22:15:43 +0200 Subject: libayatana-indicator/indicator-service{,-manager}.c: Drop return statements and g_error_free() calls that never get reached. --- libayatana-indicator/indicator-service-manager.c | 1 - libayatana-indicator/indicator-service.c | 4 ---- 2 files changed, 5 deletions(-) diff --git a/libayatana-indicator/indicator-service-manager.c b/libayatana-indicator/indicator-service-manager.c index 049d176..33bcba9 100644 --- a/libayatana-indicator/indicator-service-manager.c +++ b/libayatana-indicator/indicator-service-manager.c @@ -286,7 +286,6 @@ set_property (GObject * object, guint prop_id, const GValue * value, GParamSpec case PROP_NAME: if (priv->name != NULL) { g_error("Name can not be set twice!"); - return; } priv->name = g_value_dup_string(value); start_service(self); diff --git a/libayatana-indicator/indicator-service.c b/libayatana-indicator/indicator-service.c index 06d5a0e..de3a0cf 100644 --- a/libayatana-indicator/indicator-service.c +++ b/libayatana-indicator/indicator-service.c @@ -289,7 +289,6 @@ set_property (GObject * object, guint prop_id, const GValue * value, GParamSpec if (G_VALUE_HOLDS_STRING(value)) { if (priv->name != NULL) { g_error("Name can not be set twice!"); - return; } priv->name = g_value_dup_string(value); try_and_get_name(self); @@ -354,7 +353,6 @@ bus_get_cb (__attribute__((unused)) GObject * object, GAsyncResult * res, gpoint g_warning("Unable to get a connection to the session DBus: %s", error->message); g_error_free(error); exit (0); - return; } IndicatorServicePrivate * priv = indicator_service_get_instance_private(user_data); @@ -377,8 +375,6 @@ bus_get_cb (__attribute__((unused)) GObject * object, GAsyncResult * res, gpoint &error); if (error != NULL) { g_error("Unable to register the object to DBus: %s", error->message); - g_error_free(error); - return; } return; -- cgit v1.2.3