From c4b29527853bd9e1b90a86cfb86b39bcdfee0f88 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marco=20Trevisan=20=28Trevi=C3=B1o=29?= Date: Sun, 1 Apr 2012 20:54:37 +0200 Subject: Indicator Service Manager: we don't have to free values if got with &s from variant See http://is.gd/EyhAhP --- libindicator/indicator-service-manager.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'libindicator') diff --git a/libindicator/indicator-service-manager.c b/libindicator/indicator-service-manager.c index 33b0557..d0771c1 100644 --- a/libindicator/indicator-service-manager.c +++ b/libindicator/indicator-service-manager.c @@ -571,9 +571,6 @@ service_proxy_name_changed (GDBusConnection * connection, const gchar * sender_n } } - g_free (new_name); - g_free (prev_name); - return; } -- cgit v1.2.3 From a9c0407ec259017874929c24ec1fa5ad28ac35a8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marco=20Trevisan=20=28Trevi=C3=B1o=29?= Date: Sun, 1 Apr 2012 21:03:19 +0200 Subject: Setting again the variables as const --- libindicator/indicator-service-manager.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'libindicator') diff --git a/libindicator/indicator-service-manager.c b/libindicator/indicator-service-manager.c index d0771c1..f58c148 100644 --- a/libindicator/indicator-service-manager.c +++ b/libindicator/indicator-service-manager.c @@ -536,8 +536,8 @@ service_proxy_name_changed (GDBusConnection * connection, const gchar * sender_n { IndicatorServiceManagerPrivate * priv = INDICATOR_SERVICE_MANAGER_GET_PRIVATE(user_data); - gchar * new_name = NULL; - gchar * prev_name = NULL; + const gchar * new_name = NULL; + const gchar * prev_name = NULL; g_variant_get(parameters, "(&s&s&s)", NULL, &prev_name, &new_name); if (new_name == NULL || new_name[0] == 0) { -- cgit v1.2.3 From f7eab1e6edb5d5cc1732256c80115f694f444475 Mon Sep 17 00:00:00 2001 From: Charles Kerr Date: Mon, 2 Apr 2012 18:42:07 -0500 Subject: Fix spelling/grammar errors in an error message. --- libindicator/indicator-desktop-shortcuts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libindicator') diff --git a/libindicator/indicator-desktop-shortcuts.c b/libindicator/indicator-desktop-shortcuts.c index 13c1667..0a4e026 100644 --- a/libindicator/indicator-desktop-shortcuts.c +++ b/libindicator/indicator-desktop-shortcuts.c @@ -199,7 +199,7 @@ set_property (GObject * object, guint prop_id, const GValue * value, GParamSpec /* But fallback if we can't */ if (priv->actions == ACTIONS_NONE && g_key_file_has_key(keyfile, G_KEY_FILE_DESKTOP_GROUP, OLD_SHORTCUTS_KEY, NULL)) { priv->actions = ACTIONS_XAYATANA; - g_warning("Desktop file '%s' is using a depracted format for it's actions that will be dropped soon.", g_value_get_string(value)); + g_warning("Desktop file '%s' is using a deprecated format for its actions that will be dropped soon.", g_value_get_string(value)); } if (priv->actions == ACTIONS_NONE) { -- cgit v1.2.3