From f02ca5a6b148d7ab6c33692da84f4601af4fd8c8 Mon Sep 17 00:00:00 2001 From: Lars Uebernickel Date: Thu, 24 Jan 2013 11:39:12 +0100 Subject: indicator-ng: check return value of g_menu_model_get_item_attribute If it returns false, we'd use uninitialized memory. --- libindicator/indicator-ng.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) (limited to 'libindicator') diff --git a/libindicator/indicator-ng.c b/libindicator/indicator-ng.c index 82af030..003ec70 100644 --- a/libindicator/indicator-ng.c +++ b/libindicator/indicator-ng.c @@ -244,9 +244,11 @@ indicator_ng_menu_changed (GMenuModel *menu, gchar *action; g_clear_pointer (&self->header_action, g_free); - g_menu_model_get_item_attribute (self->menu, 0, G_MENU_ATTRIBUTE_ACTION, "s", &action); - if (action && g_str_has_prefix (action, "indicator.")) - self->header_action = g_strdup (action + 10); + if (g_menu_model_get_item_attribute (self->menu, 0, G_MENU_ATTRIBUTE_ACTION, "s", &action) && + g_str_has_prefix (action, "indicator.")) + { + self->header_action = g_strdup (action + 10); + } popup = g_menu_model_get_item_link (self->menu, 0, G_MENU_LINK_SUBMENU); if (popup) -- cgit v1.2.3